Spec URL: http://mizdebsk.fedorapeople.org/review/maven-shared-jarsigner/maven-shared-jarsigner.spec SRPM URL: http://mizdebsk.fedorapeople.org/review/maven-shared-jarsigner/maven-shared-jarsigner-1.3-1.fc21.src.rpm Description: Apache Maven Jarsigner is a component which provides utilities to sign and verify Java archive and other files in your Maven MOJOs. Fedora Account System Username: mizdebsk
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6347748
seem maven-jarsigner 1.3 is not available @ http://repo1.maven.org/maven2/org/apache/maven/shared/maven-jarsigner/ can you use http://svn.apache.org/repos/asf/maven/shared/tags/maven-jarsigner-1.3/ ?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre- built_JAR_files_.2F_Other_bundled_software' maven-jarsigner-1.3/src/test/javax.persistence_2.0.5.v201212031355.jar is available in Fedora repos as eclipselink-persistence-api maven-jarsigner-1.3/src/test/simple.jar is as empty JAR archive. contains only a README txt file with this content "should be signed" please, remove and use system libraries maven-jarsigner-1.3/src/test/keystore ? is provided by some package? please, remove. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)". Detailed output of licensecheck in /home/gil/1047765 -maven-shared-jarsigner/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/java/maven-shared-jarsigner [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/java/maven-shared- jarsigner [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Pom files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in maven- shared-jarsigner-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: maven-shared-jarsigner-1.3-1.fc21.noarch.rpm maven-shared-jarsigner-javadoc-1.3-1.fc21.noarch.rpm maven-shared-jarsigner-1.3-1.fc21.src.rpm maven-shared-jarsigner.src: W: invalid-url Source0: http://repo1.maven.org/maven2/org/apache/maven/shared/maven-jarsigner/1.3/maven-jarsigner-1.3-source-release.zip HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint maven-shared-jarsigner-javadoc maven-shared-jarsigner 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- maven-shared-jarsigner-javadoc (rpmlib, GLIBC filtered): jpackage-utils maven-shared-jarsigner (rpmlib, GLIBC filtered): java jpackage-utils mvn(org.apache.maven.shared:maven-shared-utils) mvn(org.apache.maven:maven-toolchain) mvn(org.codehaus.plexus:plexus-component-annotations) mvn(org.codehaus.plexus:plexus-container-default) Provides -------- maven-shared-jarsigner-javadoc: maven-shared-jarsigner-javadoc maven-shared-jarsigner: maven-shared-jarsigner mvn(org.apache.maven.shared:maven-jarsigner) Jar and class files in source ----------------------------- ./maven-jarsigner-1.3/src/test/simple.jar ./maven-jarsigner-1.3/src/test/javax.persistence_2.0.5.v201212031355.jar Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1047765 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG
Other issues: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
Sorry forgot this issues: [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/java/maven-shared-jarsigner
Please fix listed issues before import
Thank you for the review. The source URL is already valid -- sources are available at Maven Central now. I will remove bundled JARs at import.
New Package SCM Request ======================= Package Name: maven-shared-jarsigner Short Description: Component to assist in signing Java archives Owners: mizdebsk sochotni msrb Branches: f20 InitialCC: java-sig
Git done (by process-git-requests).