Bug 1047787 - Review Request: rubygem-loofah - Manipulate and transform HTML/XML documents and fragments
Summary: Review Request: rubygem-loofah - Manipulate and transform HTML/XML documents ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-02 09:05 UTC by Ken Dreyer
Modified: 2014-02-05 16:34 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-02-05 16:34:16 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ken Dreyer 2014-01-02 09:05:30 UTC
Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-loofah.spec
SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-loofah-1.2.1-1.fc21.src.rpm
Description: Loofah is a general library for manipulating and transforming HTML/XML documents and fragments. It's built on top of Nokogiri and libxml2, so it's fast and has a nice API.
Loofah excels at HTML sanitization (XSS prevention). It includes some nice HTML sanitizers, which are based on HTML5lib's whitelist, so it most likely won't make your codes less secure.
Fedora Account System Username: ktdreyer

F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6347866

Comment 1 Mamoru TASAKA 2014-01-09 05:06:40 UTC
Well, as rubygem-rugged was already in Fedora, taking this.

Comment 2 Mamoru TASAKA 2014-01-12 16:59:13 UTC
Okay, simple package, approving.

* spec / srpm file clean
* builds fine on koji, f21
* binary rpms can be installed
* At least the following works:

$ ruby -e "require 'loofah' ; puts Loofah::VERSION"
1.2.1


------------------------------------------------------------
    This package (rubygem-loofah) is APPROVED by mtasaka
------------------------------------------------------------

Comment 3 Mamoru TASAKA 2014-02-03 08:10:54 UTC
Ken, would you import this into Fedora git?

Comment 4 Ken Dreyer 2014-02-05 01:33:34 UTC
Hi mtasaka, thanks very much for the review! Please accept my apologies for the delay. Work was really busy last month.

New Package SCM Request
=======================
Package Name: rubygem-loofah
Short Description: Manipulate and transform HTML/XML documents and fragments
Owners: ktdreyer
Branches: f20

Comment 5 Gwyn Ciesla 2014-02-05 13:02:17 UTC
Git done (by process-git-requests).

Comment 6 Ken Dreyer 2014-02-05 16:34:16 UTC
Package is built for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6495141

Closing. Thanks again for the review.


Note You need to log in before you can comment on or make changes to this bug.