Bug 1047812 - Make package PSR-0 compliant
Summary: Make package PSR-0 compliant
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: php-aws-sdk
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-02 09:44 UTC by Adam Williamson
Modified: 2014-09-06 20:30 UTC (History)
3 users (show)

Fixed In Version: php-aws-sdk-2.6.15-2.el6
Clone Of:
Environment:
Last Closed: 2014-08-30 03:56:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2014-01-02 09:44:17 UTC
I've been learning stuff today!

If I'm right (and hey, I'm probably not...) I think php-aws-sdk is actually PSR-0 compliant, but because we install it via PEAR it winds up in a subdirectory and so you'd have to get that weird subdirectory - /usr/share/pear/AWSSDKforPHP - into the include_path before you could successfully autoload it.

Would it be appropriate to change the package so it just installs to /usr/share/php/Aws ? it could then be safely autoloaded.

Please do tell me what I'm misunderstanding. I cc Remi. :)

Comment 1 Remi Collet 2014-01-02 14:44:43 UTC
Notice: version 2.5.0-2 in rawhide is totally broken, no file (only empty dir)

I agree this library is PSR-0 so should be in /usr/share/pear/Aws
(pear, not php)

But this need to be reported to upstream:
- drop  baseinstalldir="AWSSDKforPHP" for all files
- provide some doc, at least LICENSE
..

We are exactly in the current bad process where upstream provides both composer and pear installation but don't care of pear channel... :(

Comment 2 Joseph Marrero 2014-05-04 07:01:00 UTC
Reported Upstream via github:
https://github.com/aws/aws-sdk-php/issues/286

Comment 3 Joseph Marrero 2014-06-26 01:31:53 UTC
I can not update any of my packages for the time being, will know If I can continue contributing in about a month. I can pass the ownership to who ever wants to maintain it or we can share ownerships if I can still contributing. But will not know my status until august 1st is my best guess.

Comment 4 Fedora Admin XMLRPC Client 2014-08-06 01:11:34 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 5 Shawn Iwinski 2014-08-06 22:24:34 UTC
Joseph (and Gregor) handed over admin of this package to me.  I will be updating this package to a composer (instead of PEAR) and updating to 2.6.13 with bug #1126610.  Here is the update I will be making in rawhide soon: https://raw.githubusercontent.com/siwinski/fedora-clone-php-aws-sdk/bz1126610-version-2.6.3/php-aws-sdk.spec

Comment 6 Shawn Iwinski 2014-08-06 22:25:23 UTC
(In reply to Shawn Iwinski from comment #5)
> updating this package to a composer (instead of PEAR) and updating to 2.6.13

updating this package to a composer (instead of PEAR) *INSTALL*

Comment 7 Adam Williamson 2014-08-06 22:31:50 UTC
I didn't get around to testing yet, but looking at the upstream docs, I *suspect* ownCloud won't work with 2.5 or 2.6 without modification. I filed an issue on this recently at https://github.com/owncloud/core/issues/9649 , though I'm kinda theoretically on the hook to fix it myself.

I'll throw it on my ever-growing list of 'discretionary work', but I can't promise anything short-term :(

Comment 8 Shawn Iwinski 2014-08-06 22:54:10 UTC
(In reply to Adam Williamson (Red Hat) from comment #7)
> I didn't get around to testing yet, but looking at the upstream docs, I
> *suspect* ownCloud won't work with 2.5 or 2.6 without modification. I filed
> an issue on this recently at https://github.com/owncloud/core/issues/9649 ,
> though I'm kinda theoretically on the hook to fix it myself.
> 
> I'll throw it on my ever-growing list of 'discretionary work', but I can't
> promise anything short-term :(

2.5.3 is already in f20
2.6.1 is already in rawhide/f21
No version is in epel6 or epel7

Also, I don't see a dependency or conflicts in the owncloud pkg for php-aws-sdk

Comment 9 Fedora Update System 2014-08-20 19:25:19 UTC
php-aws-sdk-2.6.15-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-aws-sdk-2.6.15-2.fc20

Comment 10 Fedora Update System 2014-08-20 19:27:51 UTC
php-aws-sdk-2.6.15-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-aws-sdk-2.6.15-2.el6

Comment 11 Shawn Iwinski 2014-08-20 19:40:44 UTC
Notes:
* F20 is an update
* EL6 is a new package
* Changed from PEAR install (/usr/share/pear/AWSSDKforPHP/Aws) to Composer-ish install (/usr/share/php/Aws)

Comment 12 Fedora Update System 2014-08-20 22:59:48 UTC
php-aws-sdk-2.6.15-2.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 13 Fedora Update System 2014-08-30 03:56:19 UTC
php-aws-sdk-2.6.15-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2014-09-06 20:30:40 UTC
php-aws-sdk-2.6.15-2.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.