Bug 1047889 - components do not have severity initialized on engine start
Summary: components do not have severity initialized on engine start
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.4.1
Assignee: Eli Mesika
QA Contact: Lukas Svaty
URL:
Whiteboard: infra
: 1146908 (view as bug list)
Depends On:
Blocks: 1048939
TreeView+ depends on / blocked
 
Reported: 2014-01-02 14:03 UTC by Martin Sivák
Modified: 2016-04-25 13:41 UTC (History)
7 users (show)

Fixed In Version: ovirt-3.4.0-alpha1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1048939 (view as bug list)
Environment:
Last Closed: 2014-05-08 13:36:13 UTC
oVirt Team: ---
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 22735 0 None None None Never
oVirt gerrit 25078 0 None MERGED core: Setting missing severity to audit log... Never
oVirt gerrit 25919 0 None MERGED core: Setting missing severity to audit log... Never

Description Martin Sivák 2014-01-02 14:03:53 UTC 
Description of problem:

The mentioned method is never called and so Audit Log messages related to MoM do not have severity assigned.

Version-Release number of selected component (if applicable):

ovirt-engine-3.3

How reproducible:

Start the engine.

Actual results:

> 2013-12-19 00:50:10,238 WARN
> [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
> (http--0.0.0.0-8080-3) AuditLogType: USER_UPDATED_MOM_POLICIES not have
> severity. Assumed Normal
> 2013-12-19 00:50:10,239 WARN
> [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
> (http--0.0.0.0-8080-3) AuditLogType: USER_FAILED_TO_UPDATE_MOM_POLICIES not
> have severity. Assum

Expected results:

No warnings.
Comment 1 Martin Sivák 2014-01-09 21:40:28 UTC 
This was fixed on master by Moti on master.
Comment 2 Itamar Heim 2014-01-12 08:42:06 UTC 
setting target release to current version for consideration and review. please do not push non-RFE bugs to an undefined target release to make sure bugs are reviewed for relevancy, fix, closure, etc.
Comment 3 Sandro Bonazzola 2014-01-13 13:56:44 UTC 
oVirt 3.4.0 alpha has been released including the fix for this issue.
Comment 4 Lukas Svaty 2014-02-13 09:39:43 UTC 
other similar warnings should be resolved as well
change assignee is necessary

2014-02-13 09:57:23,673 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_FAILED_REMOVE_VM not have severity. Assumed Normal
2014-02-13 09:57:23,673 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_ATTACH_DISK_TO_VM not have severity. Assumed Normal
2014-02-13 09:57:23,674 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_DETACH_DISK_FROM_VM not have severity. Assumed Normal
2014-02-13 09:57:23,675 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_FAILED_DETACH_DISK_FROM_VM not have severity. Assumed Normal
2014-02-13 09:57:23,676 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_RUN_UNLOCK_ENTITY_SCRIPT not have severity. Assumed Normal
2014-02-13 09:57:23,677 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: GLUSTER_VOLUME_OPTION_CHANGED_FROM_CLI not have severity. Assumed Normal
2014-02-13 09:57:23,678 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: GLUSTER_SERVICES_LIST_NOT_FETCHED not have severity. Assumed Normal
2014-02-13 09:57:23,679 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: GLUSTER_VOLUME_BRICK_ADDED not have severity. Assumed Normal
2014-02-13 09:57:23,680 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_EXTEND_DISK_SIZE_UPDATE_VM_FAILURE not have severity. Assumed Normal
2014-02-13 09:57:23,695 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: VM_MIGRATION_START_SYSTEM_INITIATED not have severity. Assumed Normal
2014-02-13 09:57:23,696 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: VDS_NETWORK_MTU_DIFFER_FROM_LOGICAL_NETWORK not have severity. Assumed Normal
2014-02-13 09:57:23,697 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: NETWORK_UPDATE_VM_INTERFACE_LINK_UP not have severity. Assumed Normal
2014-02-13 09:57:23,698 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--
127.0.0.1-8702-6) [6b154c03] AuditLogType: 

NETWORK_UPDATE_VM_INTERFACE_LINK_DOWN not have severity. Assumed Normal
2014-02-13 09:57:23,699 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_ADDED_AFFINITY_GROUP not have severity. Assumed Normal
2014-02-13 09:57:23,700 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_FAILED_TO_ADD_AFFINITY_GROUP not have severity. Assumed Normal
2014-02-13 09:57:23,701 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_UPDATED_AFFINITY_GROUP not have severity. Assumed Normal
2014-02-13 09:57:23,702 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_FAILED_TO_UPDATE_AFFINITY_GROUP not have severity. Assumed Normal
2014-02-13 09:57:23,702 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_REMOVED_AFFINITY_GROUP not have severity. Assumed Normal
2014-02-13 09:57:23,703 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (ajp--127.0.0.1-8702-6) [6b154c03] AuditLogType: USER_FAILED_TO_REMOVE_AFFINITY_GROUP not have severity. Assumed Normal
Comment 5 Martin Sivák 2014-02-18 09:26:24 UTC 
This issue was solved on the log side by changing the way we set severity to AuditLog messages. See gerrit changes http://gerrit.ovirt.org/#/c/24441/ and http://gerrit.ovirt.org/#/c/24442/.

We should still do a review of the above-mentioned messages and set the correct severity there.
Comment 6 Eli Mesika 2014-02-18 21:17:51 UTC 
(In reply to Martin Sivák from comment #5)
> This issue was solved on the log side by changing the way we set severity to
> AuditLog messages. See gerrit changes http://gerrit.ovirt.org/#/c/24441/ and
> http://gerrit.ovirt.org/#/c/24442/.
> 
> We should still do a review of the above-mentioned messages and set the
> correct severity there.

Martin AFAIR after your patches we assume that if we not set the severity explicitly then it is NORMAL , so why do we have to handle this at all ?
Comment 7 Martin Sivák 2014-02-19 09:16:33 UTC 
Well for example USER_EXTEND_DISK_SIZE_UPDATE_VM_FAILURE or USER_FAILED_TO_ADD_AFFINITY_GROUP should be ERRORs I think.

There were couple of messages with no severity and not all of them belong to the NORMAL group. Someone should review them and assign the proper level if needed.
Comment 8 Sandro Bonazzola 2014-03-04 09:26:34 UTC 
This is an automated message.
Re-targeting all non-blocker bugs still open on 3.4.0 to 3.4.1.
Comment 9 Sandro Bonazzola 2014-05-08 13:36:13 UTC 
This is an automated message

oVirt 3.4.1 has been released:
 * should fix your issue
 * should be available at your local mirror within two days.

If problems still persist, please make note of it in this bug report.
Comment 10 Yanir Quinn 2016-04-25 13:41:44 UTC 
*** Bug 1146908 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.