Spec URL: http://smani.fedorapeople.org/review/python-sphinx-theme-better.spec SRPM URL: http://smani.fedorapeople.org/review/python-sphinx-theme-better-0.1.5-1.fc21.src.rpm Description: A Better Sphinx Theme Fedora Account System Username: smani Note: I included the with_python3 conditionals since python-pillow needs this package and python-pillow is in RHEL7 where python3 is not included.
Is this one Fedora-only?
I'll be doing fedora only. Actually, on second thoughts, I guess pillow won't get updated in RHEL7 at this time anyway (since it is already beta), so the conditionals can also be dropped.
I intended to let you change the python2 macro from un-versioned to versioned like %{__python} to %{__python2}. You should add conditional lines for this.
How about just doing %global __python2 %{__python} an possibly wrapping that in a conditional block when python 3 becomes default (F21 or F22 I guess)?
Yes, add this line in the first block of %if 0%{?rhel} == 7, ALSO don't forget %{python_sitelib}. Once new SRPM uploaded, I'll do a full review.
Spec URL: http://smani.fedorapeople.org/review/python-sphinx-theme-better.spec SRPM URL: http://smani.fedorapeople.org/review/python-sphinx-theme-better-0.1.5-2.fc21.src.rpm %changelog * Sun Jan 05 2014 Sandro Mani <manisandro> - 0.1.5-2 - Use %%{__python2} and %%{python2_sitelib}, define these macros for rhel7
Ask upstream of patching these with license header: Unknown or generated -------------------- sphinx-better-theme-0.1.5/better/__init__.py sphinx-better-theme-0.1.5/docs/conf.py sphinx-better-theme-0.1.5/setup.py And notify him of unusual 600 perms of the tarball. -------------------- Hint: Instead of renaming the tarball everytime you download, why not directly download good-named one from pypi? https://pypi.python.org/pypi/sphinx-better-theme -------------------- PACKAGE APPROVED.
Good point, I'll change the download link. Thanks for the review! New Package SCM Request ======================= Package Name: python-sphinx-theme-better Short Description: A Better Sphinx Theme Owners: smani Branches: InitialCC:
Git done (by process-git-requests).