Spec URL: http://freevariable.com/fmpp/fmpp.spec SRPM URL: http://freevariable.com/fmpp/fmpp-0.9.14-1.fc19.src.rpm Description: FMPP is a general-purpose text file preprocessor tool that uses FreeMarker templates. Fedora Account System Username: willb
Please change BuildRequires: mvn(bsh:bsh) Requires: mvn(bsh:bsh) with BuildRequires: mvn(org.beanshell:bsh) Requires: mvn(org.beanshell:bsh)
Please remove Class-Path frpm manifest <attribute name="Class-Path" value="/usr/share/java/oro.jar /usr/share/java/freemarker.jar /usr/share/java/bsh.jar /usr/share/java/xml-resolver.jar" /> and can use maven-upload task disabling only maven-ant-tasks support ...? in this way don't need anymore SOURCE1 e.g. <target name="maven-upload"> <echo file="build/pom.xml"><![CDATA[<?xml version="1.0" encoding="utf-8"?> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> <modelVersion>4.0.0</modelVersion> <groupId>net.sourceforge.fmpp</groupId> <artifactId>fmpp</artifactId> <version>${version}</version> <packaging>jar</packaging> <name>FMPP</name> <description> General-purpose text file preprocessor tool that uses FreeMarker templates. </description> <url>http://fmpp.sourceforge.net</url> <licenses> <license> <name>BSD license</name> <url>http://fmpp.sourceforge.net/license.html</url> </license> </licenses> <scm> <url>http://fmpp.svn.sourceforge.net/viewvc/fmpp/</url> <connection>scm:svn:https://fmpp.svn.sourceforge.net/svnroot/fmpp</connection> </scm> <dependencies> <dependency> <groupId>org.freemarker</groupId> <artifactId>freemarker</artifactId> <!-- 2.4 will be somewhat non-BC --> <version>[2.3.15,2.4)</version> </dependency> <dependency> <groupId>oro</groupId> <artifactId>oro</artifactId> <!-- I guess there will not be non-BC changes anymore. --> <version>[2.0.8,)</version> </dependency> <dependency> <groupId>org.beanshell</groupId> <artifactId>bsh</artifactId> <!-- Regarding 2.1 it's just a wild guess... --> <version>[1.3,2.1)</version> </dependency> <dependency> <groupId>xml-resolver</groupId> <artifactId>xml-resolver</artifactId> <!-- I guess there will not be non-BC changes anymore. --> <version>[1.1,)</version> </dependency> </dependencies> </project> ]]></echo> /> </target>
javac target and souce *must* be set at least to 1.5 and source to UTF-8 <javac bootclasspath="${bootclasspath.path}" srcdir="src/java" destdir="build/compile" deprecation="off" debug="on" source="1.5" target="1.5" encoding="UTF-8" > <javadoc destdir="docs/api" doctitle="FMPP ${version} API" packagenames="fmpp.*" excludepackagenames="fmpp.test" sourcepath="src/java" overview="src/java/fmpp/overview.html" windowtitle="FMPP ${version} API" classpathref="classpath.path" version="false" author="false" source="1.5" encoding="UTF-8" /> Please change license field as: License: BSD or Public Domain Public Domain fmpp_0.9.14/lib/forbuild/classes/imageinfo/ImageInfo.java
BuildRequires: jpackage-utils Requires: jpackage-utils must be replaced by BuildRequires: jpackage-utils Requires: jpackage-utils rm -rf %{buildroot} is superfluous, please remove %package javadoc Group: Documentation is superfluous, please remove Summary: Javadoc for %{name} BuildArch: noarch is superfluous, please remove
Sorry BuildRequires: jpackage-utils Requires: jpackage-utils must be replaced by BuildRequires: javapackage-tools Requires: javapackage-tools
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "Unknown or generated". 12 files have unknown license. Detailed output of licensecheck in /home/gil/1048299-fmpp/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [.]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: Pom files have correct Maven mapping Note: Some add_maven_depmap calls found. Please check if they are correct or update to latest guidelines [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fmpp- javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [ ]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fmpp-0.9.14-1.fc21.noarch.rpm fmpp-javadoc-0.9.14-1.fc21.noarch.rpm fmpp-0.9.14-1.fc21.src.rpm fmpp.noarch: E: devel-dependency java-devel fmpp.noarch: W: spelling-error %description -l en_US preprocessor -> processor, predecessor, process's fmpp.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/fmpp/LICENSE.txt fmpp.noarch: W: file-not-utf8 /usr/share/doc/fmpp/LICENSE.txt fmpp.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/fmpp/README.txt fmpp.noarch: W: class-path-in-manifest /usr/share/java/fmpp.jar fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/src/test.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/inherit_config/config_red.fmpp fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/qtour_step2/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/freemarker/api/package-list fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/dtds/xhtml-lat1.ent fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/qtour_step3/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/src/bigwidget.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/session/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/local_data/src/sub/3_j.html.bsh fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/LICENSE_RESOLVER.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/eval/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/capture/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/img_dims/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step3/src/data/style.tdd fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/local_data/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/session/src/include/page.ftl fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml2/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml/src/data/test.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/fmpp-javadoc/LICENSE.txt fmpp-javadoc.noarch: W: file-not-utf8 /usr/share/doc/fmpp-javadoc/LICENSE.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/tdd/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/multipage_list/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step1/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/src/normalwidget.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step2/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_try/src/data/test.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/src/smallwidget.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/inherit_config/README.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/ant3/build.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/src/example2.xml fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml2/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/check_links/src/include/a.ftl fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step3/src/data/birds.csv fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/border/src/include/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step4/src/data/style.tdd fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/capture/src/include/page.ftl fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/tdd/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/inherit_config/config_dark.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/dtds/xhtml-special.ent fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/LICENSE_ANT.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/src/example1.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/csv/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/csv/src/data/test.csv fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/csv/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/LICENSE_ORO.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/dtds/xhtml1-transitional.dtd fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/fmpp-javadoc/README.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step2/src/data/style.tdd fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml2/src/data/manufacturers.xml fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/session/src/include/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/tdd/src/data/test.tdd fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/dtds/xhtml-symbol.ent fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/ant/build.xml fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/freemarker/api/stylesheet.css fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/freemarker/docgen.css fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/local_data/src/sub/1.html.bsh fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/README.txt fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/capture/src/include/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/api/package-list fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/api/stylesheet.css fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/qtour_step4/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/check_links/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/ant2/src/test.txt fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml_try/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/border/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/LICENSE_FREEMARKER.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_try/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/ant/src/test.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml2/src/data/products.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step3/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step4/src/data/birds.csv fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/dtds/catalog.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/border/src/test.c fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step4/config.fmpp fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml_rendering/src/renderer/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/inherit_config/config.fmpp fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/check_links/src/include/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/build.xml fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml_validating/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/ant2/build.xml fmpp.src: W: spelling-error %description -l en_US preprocessor -> processor, predecessor, process's fmpp.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 11) 3 packages and 0 specfiles checked; 15 errors, 77 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint fmpp fmpp-javadoc fmpp.noarch: E: devel-dependency java-devel fmpp.noarch: W: spelling-error %description -l en_US preprocessor -> processor, predecessor, process's fmpp.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/fmpp/LICENSE.txt fmpp.noarch: W: file-not-utf8 /usr/share/doc/fmpp/LICENSE.txt fmpp.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/fmpp/README.txt fmpp.noarch: W: class-path-in-manifest /usr/share/java/fmpp.jar fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/src/test.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/inherit_config/config_red.fmpp fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/qtour_step2/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/freemarker/api/package-list fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/dtds/xhtml-lat1.ent fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/qtour_step3/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/src/bigwidget.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/session/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/local_data/src/sub/3_j.html.bsh fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/LICENSE_RESOLVER.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/eval/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/capture/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/img_dims/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step3/src/data/style.tdd fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/local_data/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/session/src/include/page.ftl fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml2/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml/src/data/test.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/fmpp-javadoc/LICENSE.txt fmpp-javadoc.noarch: W: file-not-utf8 /usr/share/doc/fmpp-javadoc/LICENSE.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/tdd/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/multipage_list/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step1/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/src/normalwidget.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step2/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_try/src/data/test.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/src/smallwidget.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/inherit_config/README.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/ant3/build.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/src/example2.xml fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml2/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/check_links/src/include/a.ftl fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step3/src/data/birds.csv fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/border/src/include/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step4/src/data/style.tdd fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/capture/src/include/page.ftl fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/tdd/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/inherit_config/config_dark.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/dtds/xhtml-special.ent fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/LICENSE_ANT.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/src/example1.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/csv/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/csv/src/data/test.csv fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/csv/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/LICENSE_ORO.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/dtds/xhtml1-transitional.dtd fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/fmpp-javadoc/README.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step2/src/data/style.tdd fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml2/src/data/manufacturers.xml fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/session/src/include/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/tdd/src/data/test.tdd fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/dtds/xhtml-symbol.ent fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/ant/build.xml fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/freemarker/api/stylesheet.css fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/freemarker/docgen.css fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/local_data/src/sub/1.html.bsh fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/README.txt fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/capture/src/include/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_rendering/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/api/package-list fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/api/stylesheet.css fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/qtour_step4/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/check_links/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/ant2/src/test.txt fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml_try/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/border/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/LICENSE_FREEMARKER.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_try/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/ant/src/test.txt fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml2/src/data/products.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step3/config.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step4/src/data/birds.csv fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/xml_validating/dtds/catalog.xml fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/border/src/test.c fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/qtour_step4/config.fmpp fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml_rendering/src/renderer/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/inherit_config/config.fmpp fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/check_links/src/include/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/build.xml fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml_validating/src/data/ignoredir.fmpp fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/ant2/build.xml 2 packages and 0 specfiles checked; 15 errors, 75 warnings. # echo 'rpmlint-done:' Requires -------- fmpp (rpmlib, GLIBC filtered): java-devel jpackage-utils mvn(bsh:bsh) mvn(org.freemarker:freemarker) mvn(oro:oro) mvn(xml-apis:xml-apis) mvn(xml-resolver:xml-resolver) fmpp-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- fmpp: fmpp mvn(net.sourceforge.fmpp:fmpp) fmpp-javadoc: fmpp-javadoc Source checksums ---------------- http://prdownloads.sourceforge.net/fmpp/fmpp_0.9.14.tar.gz : CHECKSUM(SHA256) this package : 64d5261a1c7aefb4ba209edab1cae958518254cf80c61a1909a157bfa1e65004 CHECKSUM(SHA256) upstream package : 64d5261a1c7aefb4ba209edab1cae958518254cf80c61a1909a157bfa1e65004 http://repo1.maven.org/maven2/net/sourceforge/fmpp/fmpp/0.9.14/fmpp-0.9.14.pom : CHECKSUM(SHA256) this package : cbbfb646fa0b8a4fb12c0c1aba36a01a5f72b734df6238152d3775017b7e95ba CHECKSUM(SHA256) upstream package : cbbfb646fa0b8a4fb12c0c1aba36a01a5f72b734df6238152d3775017b7e95ba Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1048299 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG Please fix the issues also in thr previous comments and the javadocs files encoding and the files with "zero-length" e.g. fmpp-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/fmpp/examples/border/src/test.c fmpp-javadoc.noarch: E: zero-length /usr/share/javadoc/fmpp/examples/xml_validating/src/data/ignoredir.fmpp
Sorry fmpp_0.9.14/lib/forbuild/classes/imageinfo/ImageInfo.java should be consider as bundled libraries [!]: Package contains no bundled libraries without FPC exception.
Hi Gil, Thanks for your review. I've updated the package in place to fix all of your concerns, including replacing the bundled code with equivalent functionality from the Java standard library. (It seems like a lot of projects use that ImageInfo class as a copylib; it might be a good candidate for a separate package, but this was less effort.) Although it no longer applies to this package, you should note that "or" in a license is appropriate only for dual-licensed packages and would not apply to a BSD-licensed package that incorporated public-domain code. In the case of a package with, e.g., both BSD and LGPL code, the license would be an "and" license, but public domain code has no restrictions on use. See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Dual_Licensing_Scenarios Here are the remaining rpmlint issues, with explanations: fmpp.src: W: spelling-error %description -l en_US preprocessor -> processor, predecessor, process's fmpp.noarch: W: spelling-error %description -l en_US preprocessor -> processor, predecessor, process's This is not actually a spelling error. fmpp.noarch: W: file-not-utf8 /usr/share/doc/fmpp-0.9.14/LICENSE.txt fmpp-javadoc.noarch: W: file-not-utf8 /usr/share/doc/fmpp-javadoc-0.9.14/LICENSE.txt We aren't allowed to modify licenses for legal reasons, so I can't munge the character set.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Packages have proper BuildRequires/Requires on jpackage-utils ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [z]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/gil/1048299-fmpp/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: Pom files have correct Maven mapping Note: Some add_maven_depmap calls found. Please check if they are correct or update to latest guidelines [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fmpp- javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fmpp-0.9.14-1.fc21.noarch.rpm fmpp-javadoc-0.9.14-1.fc21.noarch.rpm fmpp-0.9.14-1.fc21.src.rpm fmpp.noarch: W: spelling-error %description -l en_US preprocessor -> processor, predecessor, process's fmpp.noarch: W: file-not-utf8 /usr/share/doc/fmpp/LICENSE.txt fmpp-javadoc.noarch: W: file-not-utf8 /usr/share/doc/fmpp-javadoc/LICENSE.txt fmpp.src: W: spelling-error %description -l en_US preprocessor -> processor, predecessor, process's 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint fmpp fmpp-javadoc fmpp.noarch: W: spelling-error %description -l en_US preprocessor -> processor, predecessor, process's fmpp.noarch: W: file-not-utf8 /usr/share/doc/fmpp/LICENSE.txt fmpp-javadoc.noarch: W: file-not-utf8 /usr/share/doc/fmpp-javadoc/LICENSE.txt 2 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- fmpp (rpmlib, GLIBC filtered): java javapackages-tools jpackage-utils mvn(org.beanshell:bsh) mvn(org.freemarker:freemarker) mvn(oro:oro) mvn(xml-apis:xml-apis) mvn(xml-resolver:xml-resolver) fmpp-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- fmpp: fmpp mvn(net.sourceforge.fmpp:fmpp) fmpp-javadoc: fmpp-javadoc Source checksums ---------------- http://prdownloads.sourceforge.net/fmpp/fmpp_0.9.14.tar.gz : CHECKSUM(SHA256) this package : 64d5261a1c7aefb4ba209edab1cae958518254cf80c61a1909a157bfa1e65004 CHECKSUM(SHA256) upstream package : 64d5261a1c7aefb4ba209edab1cae958518254cf80c61a1909a157bfa1e65004 Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1048299 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG Please use cp -p lib/fmpp.jar %{buildroot}/%{_javadir} cp -p build/pom.xml %{buildroot}/%{_mavenpomdir}/JPP-fmpp.pom [?]: Packages should try to preserve timestamps of original installed files. Thanks for your work!
(In reply to gil cattaneo from comment #9) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Packages have proper BuildRequires/Requires on > Please ignore jpackage-utils was replaced by javapackages-tools
New Package SCM Request ======================= Package Name: fmpp Short Description: FreeMarker based preprocessor Owners: willb Branches: f20 InitialCC: willb
Git done (by process-git-requests).
fmpp-0.9.14-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/fmpp-0.9.14-1.fc20
fmpp-0.9.14-1.fc20 has been pushed to the Fedora 20 testing repository.
fmpp-0.9.14-1.fc20 has been pushed to the Fedora 20 stable repository.