Bug 1048367 - ocaml-lwt is compiled without ocaml-react support
Summary: ocaml-lwt is compiled without ocaml-react support
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ocaml-lwt
Version: 20
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-03 20:45 UTC by Edvard Fagerholm
Modified: 2014-03-01 14:05 UTC (History)
3 users (show)

Fixed In Version: ocaml-lwt-2.4.2-3.fc19
Clone Of:
Environment:
Last Closed: 2014-01-18 04:22:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
This enables the missing features. (1.38 KB, patch)
2014-01-03 22:10 UTC, Edvard Fagerholm
no flags Details | Diff

Description Edvard Fagerholm 2014-01-03 20:45:49 UTC
Compiling a package expecting lwt to be built with react support gives:

$ ocaml setup.ml -configure
ocamlfind: Package `lwt.react' not found
W: Field 'pkg_lwt_react' is not set: Command ''/bin/ocamlfind' query -format %d lwt.react > '/tmp/oasis-1a814d.txt'' terminated with error code 2
E: Cannot find findlib package lwt.react
E: Failure("1 configuration error")

Compiling lwt without react seems unintended, because ocaml-lwt.spec has the following requirements:

BuildRequires:  ocaml >= 3.10.0
BuildRequires:  ocaml-findlib-devel
BuildRequires:  ocaml-ocamldoc
BuildRequires:  ocaml-camlp4-devel
BuildRequires:  ocaml-ssl >= 0.4.0
BuildRequires:  ocaml-react >= 0.9.0
BuildRequires:  chrpath
BuildRequires:  libev-devel

I checked that if ocaml-react is installed, but ocaml-react-devel is not, then the configure script will build lwt without react support. Therefore, the build environment has probably kept react disabled.

I expect that the build requirement should be ocaml-react-devel instead.

Comment 1 Richard W.M. Jones 2014-01-03 20:50:54 UTC
I wonder if it is the META file which is wrong, because looking
at the build log it does look as if react is picked up:
http://kojipkgs.fedoraproject.org//packages/ocaml-lwt/2.4.3/4.fc21/data/logs/x86_64/build.log

However let me play with this for a bit ...

Comment 2 Edvard Fagerholm 2014-01-03 22:10:30 UTC
Created attachment 845113 [details]
This enables the missing features.

Comment 3 Edvard Fagerholm 2014-01-03 22:16:28 UTC
Looking at the build log you posted, I have the following line

Glib integration: .................................... true

set to "false" when I compile it with my machine using the spec file I posted as well as the original one. The package also has no build requirements for anything related to Glib. I wonder if this should be made more explicit (whatever the choice for that feature should be)?

Comment 4 Richard W.M. Jones 2014-01-03 22:20:44 UTC
I've done it a bit differently, see:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6355110 (F20)
http://koji.fedoraproject.org/koji/taskinfo?taskID=6354933 (Rawhide)

Comment 5 Fedora Update System 2014-01-03 22:30:04 UTC
ocaml-lwt-2.4.2-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ocaml-lwt-2.4.2-4.fc20

Comment 6 Fedora Update System 2014-01-04 19:52:01 UTC
Package ocaml-lwt-2.4.2-4.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ocaml-lwt-2.4.2-4.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-0180/ocaml-lwt-2.4.2-4.fc20
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2014-01-18 04:22:59 UTC
ocaml-lwt-2.4.2-4.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2014-02-19 02:48:20 UTC
ocaml-lwt-2.4.2-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ocaml-lwt-2.4.2-3.fc19

Comment 9 Fedora Update System 2014-03-01 14:05:29 UTC
ocaml-lwt-2.4.2-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.