Bug 1048567 - Packaging issues (a.k.a. Please ship CMake file in the RPM)
Summary: Packaging issues (a.k.a. Please ship CMake file in the RPM)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: openobex
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Tomáš Hozza
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: openOBEX-1.7.1-porting
TreeView+ depends on / blocked
 
Reported: 2014-01-05 08:57 UTC by Christopher Meng
Modified: 2014-01-09 12:37 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-01-09 12:37:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Christopher Meng 2014-01-05 08:57:56 UTC
1. I don't quite understand the reason of not shipping CMake files in the RPM, and it causes FTBFS of obexftp as it can't find openobex:

CMake Error at CMakeLists.txt:48 (find_package):
  By not providing "FindOpenObex.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "OpenObex",
  but CMake did not find one.

  Could not find a package configuration file provided by "OpenObex" with any
  of the following names:

    OpenObexConfig.cmake
    openobex-config.cmake

  Add the installation prefix of "OpenObex" to CMAKE_PREFIX_PATH or set
  "OpenObex_DIR" to a directory containing one of the above files.  If
  "OpenObex" provides a separate development package or SDK, be sure it has
  been installed.


-- Configuring incomplete, errors occurred!
See also "/home/rpmaker/rpmbuild/BUILD/obexftp-0.24-Source/CMakeFiles/CMakeOutput.log".
error: Bad exit status from /var/tmp/rpm-tmp.8GZYX7 (%build)


-----------------

It's not why we don't want to update this package, it's we're unable to update.

Please re-add them to the RPM.

2. Why don't you use %cmake macro in %build?

3. Docdir should be replaced by new macro:

%{_docdir}/openobex --> %{_pkgdocdir}/

4. Please remove old packaging lines:

%define udevdir %{_prefix}/lib/udev

-->

%global udevdir %{_prefix}/lib/udev

5. These lines are only needed by EPEL5, please remove them also:

BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

rm -rf $RPM_BUILD_ROOT in %install

%clean section

%defattr in %files

Comment 1 Tomáš Hozza 2014-01-06 14:13:14 UTC
Hi.

Thank you for your report.

(In reply to Christopher Meng from comment #0)
> 1. I don't quite understand the reason of not shipping CMake files in the
> RPM, and it causes FTBFS of obexftp as it can't find openobex:

In older versions, OpenOBEX didn't use CMake, but autotools, the CMake file
was never packaged.


> It's not why we don't want to update this package, it's we're unable to
> update.
> 
> Please re-add them to the RPM.
> 
> 2. Why don't you use %cmake macro in %build?
> 
> 3. Docdir should be replaced by new macro:
> 
> %{_docdir}/openobex --> %{_pkgdocdir}/
> 
> 4. Please remove old packaging lines:
> 
> %define udevdir %{_prefix}/lib/udev
> 
> -->
> 
> %global udevdir %{_prefix}/lib/udev
> 
> 5. These lines are only needed by EPEL5, please remove them also:
> 
> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> 
> rm -rf $RPM_BUILD_ROOT in %install
> 
> %clean section
> 
> %defattr in %files

Everything seems reasonable.

Comment 2 Christopher Meng 2014-01-07 04:33:23 UTC
Please fix ALL issues above(hopefully) and bump to -2 release in rawhide later, I will then build obexftp.

Thanks.

Comment 3 Tomáš Hozza 2014-01-09 12:37:59 UTC
Fixed in openobex-1.7.1-2.fc21


Note You need to log in before you can comment on or make changes to this bug.