Bug 1048569 - Suspend to disk on Acer C720P by closing the lid or power button does not work [NEEDINFO]
Summary: Suspend to disk on Acer C720P by closing the lid or power button does not work
Keywords:
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 20
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-05 10:04 UTC by Yannick Defais
Modified: 2014-10-10 16:08 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-17 18:45:16 UTC
Type: Bug
Embargoed:
wierdlmate: needinfo?


Attachments (Terms of Use)

Description Yannick Defais 2014-01-05 10:04:29 UTC
Description of problem:
Default install of F20 on the Acer C720P, suspend to disk is broken and block the system.

Version-Release number of selected component (if applicable):
I'm not it really aplly to the kernel...
$ uname -a
Linux mirmidon 3.12.6-300.fc20.x86_64 #1 SMP Mon Dec 23 16:44:31 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

How reproducible:
Always

Steps to Reproduce:
1.Close the lid or push the power button on the keyboard.
2.
3.

Actual results:
Block the system

Expected results:
Should suspend to disk gracefully.

Additional info:
FIX for Suspend to disk :
Create the file: /etc/tmpfiles.d/cros-acpi-wakeup.conf

# /etc/tmpfiles.d/cros-acpi-wakeup.conf
w /proc/acpi/wakeup - - - - EHCI
w /proc/acpi/wakeup - - - - HDEF
w /proc/acpi/wakeup - - - - XHCI
w /proc/acpi/wakeup - - - - LID0
w /proc/acpi/wakeup - - - - TPAD
w /proc/acpi/wakeup - - - - TSCR

Create the file: /usr/lib/systemd/system-sleep/cros-sound-suspend.sh

#!/bin/bash

case $1/$2 in
  pre/*)
    # Unbind ehci for preventing error 
    echo -n "0000:00:1d.0" | tee /sys/bus/pci/drivers/ehci-pci/unbind
    # Unbind snd_hda_intel for sound
    echo -n "0000:00:1b.0" | tee /sys/bus/pci/drivers/snd_hda_intel/unbind
    echo -n "0000:00:03.0" | tee /sys/bus/pci/drivers/snd_hda_intel/unbind
    ;;
  post/*)
    # Bind ehci for preventing error 
    echo -n "0000:00:1d.0" | tee /sys/bus/pci/drivers/ehci-pci/bind
    # bind snd_hda_intel for sound
    echo -n "0000:00:1b.0" | tee /sys/bus/pci/drivers/snd_hda_intel/bind
    echo -n "0000:00:03.0" | tee /sys/bus/pci/drivers/snd_hda_intel/bind
    ;;
esac

Make the second file executable:

# chmod +x /usr/lib/systemd/system-sleep/cros-sound-suspend.sh

Edit GRUB config file: /etc/default/grub :
Add this line:

GRUB_CMDLINE_LINUX_DEFAULT="quiet splash tpm_tis.force=1"

Update grub :

# grub2-mkconfig -o /boot/grub2/grub.cfg

Reboot.

It is not 100% working fine on my system yet: I've issue with sound playing by the flash plugin in firefox if I try to suspend to disk, but seems to work pretty well exept that particular issue.

Comment 2 Oleg Drokin 2014-01-05 17:39:12 UTC
I think you need more stuff in kernel command line.
Using just tpm_tis.force I get:
Jan  4 16:39:04 shampoo kernel: [    4.023145] genirq: Flags mismatch irq 8. 00000080 (tpm0) vs. 00000000 (rtc0)
Jan  4 16:39:04 shampoo kernel: [    4.023151] CPU: 1 PID: 310 Comm: systemd-udevd Tainted: GF          O 3.12.6-300.fc20.x86_64 #1
... (stacktrace)
Jan  4 16:39:04 shampoo kernel: [    4.023279] tpm_tis tpm_tis: Unable to request irq: 8 for probe

so to avoid this I am adding: tpm_tis.force=1 tpm_tis.interrupts=0

Comment 3 Justin M. Forbes 2014-02-24 14:04:16 UTC
*********** MASS BUG UPDATE **************

We apologize for the inconvenience.  There is a large number of bugs to go through and several of them have gone stale.  Due to this, we are doing a mass bug update across all of the Fedora 20 kernel bugs.

Fedora 20 has now been rebased to 3.13.4-200.fc20.  Please test this kernel update and let us know if you issue has been resolved or if it is still present with the newer kernel.

If you experience different issues, please open a new bug report for those.

Comment 4 Justin M. Forbes 2014-03-17 18:45:16 UTC
*********** MASS BUG UPDATE **************

This bug has been in a needinfo state for several weeks and is being closed with insufficient data due to inactivity. If this is still an issue with Fedora 20, please feel free to reopen the bug and provide the additional information requested.

Comment 5 Máté Wierdl 2014-10-06 00:09:40 UTC
In order to have suspend work longer than a few seconds, the following is needed

echo TPAD > /proc/acpi/wakeup
echo TSCR > /proc/acpi/wakeup


It is suggested at http://blog.sergiodj.net/post/2014-09-26-fedora-on-acer-c720p/ that this is made permanent in rc.local.  Is that the best place?

The tpm_tis.interrupts=0 option to the kernel made no difference for me.  After the suspend, I get 

 # dmesg|grep ERROR
[   71.514293] [drm:ivybridge_irq_handler] *ERROR* Unclaimed register before interrupt
[   71.514313] [drm:ivybridge_irq_handler] *ERROR* Unclaimed register before interrupt
[   71.514343] [drm:ivybridge_irq_handler] *ERROR* Unclaimed register before interrupt
[   71.514661] [drm:hsw_unclaimed_reg_check] *ERROR* Unclaimed write to 41000
[   71.514678] [drm:ivybridge_irq_handler] *ERROR* Unclaimed register before interrupt

This is on a Fedora 20 system right after installation, so nothing got updated and I have

# uname -r
3.11.10-301.fc20.x86_64

On the other hand, on another c720 (I have two kids), I have everything updated, and the workaround described in this bug report were *all* needed to make suspenmd work, and not get ehci errors fill the kernel logs, make the system work increasingly slowly (like wifi) and eventually lock the system. 

In other words, the bug is there both in the 3.16 and in the rawhide 3.17 kernels!

Comment 6 Máté Wierdl 2014-10-06 00:40:52 UTC
OK, so after updating the (vanilla except the workarounds of this bugreport) system, I have

[marci@localhost ~]$ dmesg|grep ERROR
[marci@localhost ~]$ sudo pm-suspend
[sudo] password for marci: 
[marci@localhost ~]$ dmesg|grep ERROR
[   97.805952] xhci_hcd 0000:00:14.0: Setup ERROR: setup context command for slot 1.
[   97.958772] xhci_hcd 0000:00:14.0: Setup ERROR: setup context command for slot 1.

This is with the latest official kernel of Fedora 20

[marci@localhost ~]$ uname -r
3.16.3-200.fc20.x86_64

Comment 7 Máté Wierdl 2014-10-10 03:10:11 UTC
How do you reopen this bug: as I wrote here, it's still present in kernel 3.17, and there is only a workaround that still gives some errors.  Thanks.


Note You need to log in before you can comment on or make changes to this bug.