Spec URL: http://fedorapeople.org/~brouhaha/wp34s/wp34s.spec SRPM URL: http://fedorapeople.org/~brouhaha/wp34s/wp34s-3.2-1.svn3467.fc19.src.rpm Description: The WP 34s project develops alternative scientific calculator firmware for the HP 20b and HP 30b calculators. This package is a build of WP 34s to run natively on Linux. Fedora Account System Username: brouhaha
I had a quick run through fedora-review, and noticed that there are many files under decNumber/ that have the ICU license. That license is not listed in the approved license list: https://fedoraproject.org/wiki/Licensing:Main#Software_License_List so probably needs an email to legal.org and adding to the License: field. There are also a few files that have a 2-clause BSD license (under atmel/), which is not listed in License:. Additionally, most of the files which originate with the project are GPLv3+, but with no copyright claim, which it would be good to clarify upstream. The output from licensecheck was: *No copyright* GPL (v3 or later) -------------------------------- wp34s-svn3467/QtFlash/WP34sFlash.cpp wp34s-svn3467/QtFlash/WP34sFlash.h wp34s-svn3467/QtFlash/WP34sFlashCommand.cpp wp34s-svn3467/QtFlash/WP34sFlashConsole.cpp wp34s-svn3467/QtFlash/WP34sFlashConsole.h wp34s-svn3467/QtFlash/WP34sFlashDialog.cpp wp34s-svn3467/QtFlash/WP34sFlashDialog.h wp34s-svn3467/QtFlash/WP34sFlashGui.cpp wp34s-svn3467/QtFlash/WP34sFlashGui.h wp34s-svn3467/QtFlash/WP34sFlashMain.cpp wp34s-svn3467/QtFlash/WP34sTextConsole.cpp wp34s-svn3467/QtFlash/WP34sTextConsole.h wp34s-svn3467/QtGui/QtAccentedTextPainter.cpp wp34s-svn3467/QtGui/QtAccentedTextPainter.h wp34s-svn3467/QtGui/QtBackgroundImage.cpp wp34s-svn3467/QtGui/QtBackgroundImage.h wp34s-svn3467/QtGui/QtBoldTextPainter.cpp wp34s-svn3467/QtGui/QtBoldTextPainter.h wp34s-svn3467/QtGui/QtBuildDate.c wp34s-svn3467/QtGui/QtBuildDate.h wp34s-svn3467/QtGui/QtCalculatorThread.cpp wp34s-svn3467/QtGui/QtCalculatorThread.h wp34s-svn3467/QtGui/QtCatalogMenu.cpp wp34s-svn3467/QtGui/QtCatalogMenu.h wp34s-svn3467/QtGui/QtCatalogMenuItem.cpp wp34s-svn3467/QtGui/QtCatalogMenuItem.h wp34s-svn3467/QtGui/QtDebugger.cpp wp34s-svn3467/QtGui/QtDebugger.h wp34s-svn3467/QtGui/QtEmulator.cpp wp34s-svn3467/QtGui/QtEmulator.h wp34s-svn3467/QtGui/QtEmulatorAdapter.c wp34s-svn3467/QtGui/QtEmulatorAdapter.h wp34s-svn3467/QtGui/QtGuiMain.cpp wp34s-svn3467/QtGui/QtHeartBeatThread.cpp wp34s-svn3467/QtGui/QtHeartBeatThread.h wp34s-svn3467/QtGui/QtIrPrint.cpp wp34s-svn3467/QtGui/QtKey.cpp wp34s-svn3467/QtGui/QtKey.h wp34s-svn3467/QtGui/QtKeyCode.cpp wp34s-svn3467/QtGui/QtKeyCode.h wp34s-svn3467/QtGui/QtKeyboard.cpp wp34s-svn3467/QtGui/QtKeyboard.h wp34s-svn3467/QtGui/QtNormalTextPainter.cpp wp34s-svn3467/QtGui/QtNormalTextPainter.h wp34s-svn3467/QtGui/QtNumberPaster.h wp34s-svn3467/QtGui/QtPreferencesDialog.cpp wp34s-svn3467/QtGui/QtPreferencesDialog.h wp34s-svn3467/QtGui/QtPrinterSymbolTextPainter.cpp wp34s-svn3467/QtGui/QtPrinterSymbolTextPainter.h wp34s-svn3467/QtGui/QtRegistersModel.cpp wp34s-svn3467/QtGui/QtRegistersModel.h wp34s-svn3467/QtGui/QtScreen.cpp wp34s-svn3467/QtGui/QtScreen.h wp34s-svn3467/QtGui/QtScreenPainter.cpp wp34s-svn3467/QtGui/QtScreenPainter.h wp34s-svn3467/QtGui/QtSerialPort.cpp wp34s-svn3467/QtGui/QtSerialPort.h wp34s-svn3467/QtGui/QtSkin.cpp wp34s-svn3467/QtGui/QtSkin.h wp34s-svn3467/QtGui/QtSpecialDigitPainter.cpp wp34s-svn3467/QtGui/QtSpecialDigitPainter.h wp34s-svn3467/QtGui/QtSubscriptTextPainter.cpp wp34s-svn3467/QtGui/QtSubscriptTextPainter.h wp34s-svn3467/QtGui/QtSuperscriptTextPainter.cpp wp34s-svn3467/QtGui/QtSuperscriptTextPainter.h wp34s-svn3467/QtGui/QtTextPainter.cpp wp34s-svn3467/QtGui/QtTextPainter.h wp34s-svn3467/QtPrinterEmulator/PaperWidget.cpp wp34s-svn3467/QtPrinterEmulator/PaperWidget.h wp34s-svn3467/QtPrinterEmulator/PrintDataReader.cpp wp34s-svn3467/QtPrinterEmulator/PrintDataReader.h wp34s-svn3467/QtPrinterEmulator/PrinterEmulator.cpp wp34s-svn3467/QtPrinterEmulator/PrinterEmulator.h wp34s-svn3467/QtPrinterEmulator/PrinterEmulatorMain.cpp wp34s-svn3467/QtPrinterEmulator/ScrollablePaper.cpp wp34s-svn3467/QtPrinterEmulator/ScrollablePaper.h wp34s-svn3467/QtSerial/QtSerialPortHelper.cpp wp34s-svn3467/QtSerial/QtSerialPortHelper.h wp34s-svn3467/alpha.c wp34s-svn3467/alpha.h wp34s-svn3467/asone.c wp34s-svn3467/commands.c wp34s-svn3467/compile_cats.c wp34s-svn3467/compile_consts.c wp34s-svn3467/complex.c wp34s-svn3467/complex.h wp34s-svn3467/data.h wp34s-svn3467/date.c wp34s-svn3467/date.h wp34s-svn3467/decn.c wp34s-svn3467/decn.h wp34s-svn3467/display.c wp34s-svn3467/display.h wp34s-svn3467/features.h wp34s-svn3467/font.inc wp34s-svn3467/font_alias.inc wp34s-svn3467/genchars7.c wp34s-svn3467/genfont.c wp34s-svn3467/int.c wp34s-svn3467/int.h wp34s-svn3467/keys.c wp34s-svn3467/keys.h wp34s-svn3467/lcd.c wp34s-svn3467/lcd.h wp34s-svn3467/lcdgen.c wp34s-svn3467/licence.h wp34s-svn3467/matrix.c wp34s-svn3467/matrix.h wp34s-svn3467/post_process.c wp34s-svn3467/pretty.c wp34s-svn3467/printer.c wp34s-svn3467/printer.h wp34s-svn3467/prt.c wp34s-svn3467/serial.c wp34s-svn3467/serial.h wp34s-svn3467/stats.c wp34s-svn3467/stats.h wp34s-svn3467/stopwatch.c wp34s-svn3467/stopwatch.h wp34s-svn3467/storage.c wp34s-svn3467/storage.h wp34s-svn3467/string.c wp34s-svn3467/tools/wp34s_asm.pl wp34s-svn3467/tools/wp34s_conv.pl wp34s-svn3467/tools/wp34s_lib.pl wp34s-svn3467/tools/wp34s_pp.pl wp34s-svn3467/unused/agm.c wp34s-svn3467/unused/beta.c wp34s-svn3467/unused/complex.c wp34s-svn3467/unused/date.c wp34s-svn3467/unused/distributions.c wp34s-svn3467/unused/error-function.c wp34s-svn3467/unused/fibonacci.c wp34s-svn3467/unused/lambertW.c wp34s-svn3467/unused/orthopolys.c wp34s-svn3467/unused/parallel.c wp34s-svn3467/unused/percent.c wp34s-svn3467/unused/sign.c wp34s-svn3467/unused/stats-cont-discrete.c wp34s-svn3467/unused/stats-uppertail-cdf.c wp34s-svn3467/unused/zeta.c wp34s-svn3467/utilities/font.c wp34s-svn3467/utilities/gausslegendre.c wp34s-svn3467/utilities/zetaconsts.c wp34s-svn3467/winserial.c wp34s-svn3467/xeq.h wp34s-svn3467/xrom.h BSD (2 clause) -------------- wp34s-svn3467/QtGui/QtNumberPaster.cpp wp34s-svn3467/atmel/aic.c wp34s-svn3467/atmel/aic.h wp34s-svn3467/atmel/at91sam7l128/AT91SAM7L128.h wp34s-svn3467/atmel/board.h wp34s-svn3467/atmel/board_lowlevel.c wp34s-svn3467/atmel/board_lowlevel.h wp34s-svn3467/atmel/board_memories.c wp34s-svn3467/atmel/board_memories.h wp34s-svn3467/atmel/dbgu.c wp34s-svn3467/atmel/dbgu.h wp34s-svn3467/atmel/pmc.c wp34s-svn3467/atmel/pmc.h wp34s-svn3467/atmel/rtc.c wp34s-svn3467/atmel/rtc.h wp34s-svn3467/atmel/slcdc.c wp34s-svn3467/atmel/slcdc.h wp34s-svn3467/atmel/supc.c wp34s-svn3467/atmel/supc.h GPL (v3 or later) ----------------- wp34s-svn3467/console.c wp34s-svn3467/unused/permutations.c Unknown or generated -------------------- wp34s-svn3467/QtPrinterEmulator/font82240b.cpp wp34s-svn3467/QtPrinterEmulator/font82240b.h wp34s-svn3467/create_revision.c wp34s-svn3467/decNumber/decContext.c wp34s-svn3467/decNumber/decContext.h wp34s-svn3467/decNumber/decDPD.h wp34s-svn3467/decNumber/decNumber.c wp34s-svn3467/decNumber/decNumber.h wp34s-svn3467/decNumber/decNumberLocal.h wp34s-svn3467/decNumber/decPacked.c wp34s-svn3467/decNumber/decPacked.h wp34s-svn3467/decNumber/decimal128.c wp34s-svn3467/decNumber/decimal128.h wp34s-svn3467/decNumber/decimal32.c wp34s-svn3467/decNumber/decimal32.h wp34s-svn3467/decNumber/decimal64.c wp34s-svn3467/decNumber/decimal64.h wp34s-svn3467/decNumber/example1.c wp34s-svn3467/decNumber/example2.c wp34s-svn3467/decNumber/example3.c wp34s-svn3467/decNumber/example4.c wp34s-svn3467/decNumber/example5.c wp34s-svn3467/decNumber/example6.c wp34s-svn3467/errors.h wp34s-svn3467/main.c wp34s-svn3467/unused/bessel.c wp34s-svn3467/unused/digamma.c wp34s-svn3467/unused/dist-q-helper.c wp34s-svn3467/unused/elliptic.c wp34s-svn3467/unused/factorial.c wp34s-svn3467/unused/int.c wp34s-svn3467/unused/solver.c wp34s-svn3467/xeq.c
Actually ICU has been accepted by Fedora as a variant of the MIT license: http://fedoraproject.org/wiki/Licensing:MIT#Modern_style_28ICU_Variant.29 Note also that the License tag is for the effective license of the files in the binary RPM: http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License:_field http://fedoraproject.org/wiki/Licensing:FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F The effective license when linking GPLv3+, ICU, and BSD is the most restrictive of the three, which is GPLv3+.
Ah, that looks fine then. Thanks for the explanation!
Updated to latest upstream. Spec URL: http://fedorapeople.org/~brouhaha/wp34s/wp34s.spec SRPM URL: http://fedorapeople.org/~brouhaha/wp34s/wp34s-3.3-1.svn3679.fc19.src.rpm
BuildRequires: dos2unix may not keep the timestamp, you should use sed and touch to keep that. for f in `find . -type f` do if `file $f | grep -q CRLF` then sed '/\/usr\/bin\/env/d' $f > $f.new && touch -r $f $f.new && mv $f.new $f fi done
The spec file is using the -k option to dos2unix, which preserves the timestamp.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.