Spec URL: http://mizdebsk.fedorapeople.org/review/jsch-agent-proxy/jsch-agent-proxy.spec SRPM URL: http://mizdebsk.fedorapeople.org/review/jsch-agent-proxy/jsch-agent-proxy-0.0.7-1.fc21.src.rpm Description: jsch-agent-proxy is a proxy program to OpenSSH ssh-agent and Pageant included Putty. It will be easily integrated into JSch, and users will be allowed to use those programs in authentications. This software has been developed for JSch, but it will be easily applicable to other ssh2 implementations in Java. This software is licensed under BSD style license. Fedora Account System Username: mizdebsk
I'll do the review
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ====== We have trilead-ssh2 in Fedora (https://apps.fedoraproject.org/packages/trilead-ssh2), therefore trilead submodule needn't be disabled. There is README and README.md, which could go to %doc. typo in javadoc %description - privides -> provides ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 21 files have unknown license. Detailed output of licensecheck in /home/msimacek/1048734-jsch-agent-proxy/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/java/jsch-agent-proxy [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/java/jsch-agent-proxy [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Pom files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jsch-agent- proxy-connector-factory , jsch-agent-proxy-core , jsch-agent-proxy-jsch , jsch-agent-proxy-pageant , jsch-agent-proxy-sshagent , jsch-agent-proxy- sshj , jsch-agent-proxy-usocket-jna , jsch-agent-proxy-usocket-nc , jsch- agent-proxy-javadoc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jsch-agent-proxy-connector-factory-0.0.7-1.fc21.noarch.rpm jsch-agent-proxy-core-0.0.7-1.fc21.noarch.rpm jsch-agent-proxy-jsch-0.0.7-1.fc21.noarch.rpm jsch-agent-proxy-pageant-0.0.7-1.fc21.noarch.rpm jsch-agent-proxy-sshagent-0.0.7-1.fc21.noarch.rpm jsch-agent-proxy-sshj-0.0.7-1.fc21.noarch.rpm jsch-agent-proxy-usocket-jna-0.0.7-1.fc21.noarch.rpm jsch-agent-proxy-usocket-nc-0.0.7-1.fc21.noarch.rpm jsch-agent-proxy-javadoc-0.0.7-1.fc21.noarch.rpm jsch-agent-proxy-0.0.7-1.fc21.src.rpm jsch-agent-proxy-connector-factory.noarch: W: no-documentation jsch-agent-proxy-core.noarch: W: summary-not-capitalized C jsch-agent-proxy core module jsch-agent-proxy-jsch.noarch: W: no-documentation jsch-agent-proxy-pageant.noarch: W: no-documentation jsch-agent-proxy-sshagent.noarch: W: summary-not-capitalized C ssh-agent connector for jsch-agent-proxy jsch-agent-proxy-sshagent.noarch: W: no-documentation jsch-agent-proxy-sshj.noarch: W: summary-not-capitalized C sshj connector for jsch-agent-proxy jsch-agent-proxy-sshj.noarch: W: no-documentation jsch-agent-proxy-usocket-jna.noarch: W: no-documentation jsch-agent-proxy-usocket-nc.noarch: W: no-documentation jsch-agent-proxy-javadoc.noarch: W: spelling-error %description -l en_US privides -> provides, privies, deprives 10 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint jsch-agent-proxy-sshagent jsch-agent-proxy-sshj jsch-agent-proxy-core jsch-agent-proxy -jsch jsch-agent-proxy-usocket-nc jsch-agent-proxy-pageant jsch-agent-proxy-connector-factory jsch-agent-proxy-usocke t-jna jsch-agent-proxy-javadoc jsch-agent-proxy-sshagent.noarch: W: summary-not-capitalized C ssh-agent connector for jsch-agent-proxy jsch-agent-proxy-sshagent.noarch: W: no-documentation jsch-agent-proxy-sshj.noarch: W: summary-not-capitalized C sshj connector for jsch-agent-proxy jsch-agent-proxy-sshj.noarch: W: no-documentation jsch-agent-proxy-core.noarch: W: summary-not-capitalized C jsch-agent-proxy core module jsch-agent-proxy-jsch.noarch: W: no-documentation jsch-agent-proxy-usocket-nc.noarch: W: no-documentation jsch-agent-proxy-pageant.noarch: W: no-documentation jsch-agent-proxy-connector-factory.noarch: W: no-documentation jsch-agent-proxy-usocket-jna.noarch: W: no-documentation jsch-agent-proxy-javadoc.noarch: W: spelling-error %description -l en_US privides -> provides, privies, deprives 9 packages and 0 specfiles checked; 0 errors, 11 warnings. # echo 'rpmlint-done:' Requires -------- jsch-agent-proxy-sshagent (rpmlib, GLIBC filtered): java jpackage-utils mvn(com.jcraft:jsch.agentproxy.core) jsch-agent-proxy-sshj (rpmlib, GLIBC filtered): java jpackage-utils mvn(com.jcraft:jsch.agentproxy.core) mvn(net.schmizz:sshj) jsch-agent-proxy-core (rpmlib, GLIBC filtered): java jpackage-utils jsch-agent-proxy-jsch (rpmlib, GLIBC filtered): java jpackage-utils mvn(com.jcraft:jsch) mvn(com.jcraft:jsch.agentproxy.core) jsch-agent-proxy-usocket-nc (rpmlib, GLIBC filtered): java jpackage-utils mvn(com.jcraft:jsch.agentproxy.core) jsch-agent-proxy-pageant (rpmlib, GLIBC filtered): java jpackage-utils mvn(com.jcraft:jsch.agentproxy.core) mvn(net.java.dev.jna:jna) mvn(net.java.dev.jna:platform) jsch-agent-proxy-connector-factory (rpmlib, GLIBC filtered): java jpackage-utils mvn(com.jcraft:jsch.agentproxy.core) mvn(com.jcraft:jsch.agentproxy.pageant) mvn(com.jcraft:jsch.agentproxy.sshagent) mvn(com.jcraft:jsch.agentproxy.usocket-jna) mvn(com.jcraft:jsch.agentproxy.usocket-nc) jsch-agent-proxy-usocket-jna (rpmlib, GLIBC filtered): java jpackage-utils mvn(com.jcraft:jsch.agentproxy.core) mvn(net.java.dev.jna:jna) mvn(net.java.dev.jna:platform) jsch-agent-proxy-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- jsch-agent-proxy-sshagent: jsch-agent-proxy-sshagent mvn(com.jcraft:jsch.agentproxy.sshagent) osgi(com.jcraft.jsch.agentproxy.sshagent) jsch-agent-proxy-sshj: jsch-agent-proxy-sshj mvn(com.jcraft:jsch.agentproxy.sshj) jsch-agent-proxy-core: jsch-agent-proxy-core mvn(com.jcraft:jsch.agentproxy) mvn(com.jcraft:jsch.agentproxy.core) mvn(com.jcraft:jsch.agentproxy:pom:) osgi(com.jcraft.jsch.agentproxy.core) jsch-agent-proxy-jsch: jsch-agent-proxy-jsch mvn(com.jcraft:jsch.agentproxy.jsch) jsch-agent-proxy-usocket-nc: jsch-agent-proxy-usocket-nc mvn(com.jcraft:jsch.agentproxy.usocket-nc) osgi(com.jcraft.jsch.agentproxy.usocket-nc) jsch-agent-proxy-pageant: jsch-agent-proxy-pageant mvn(com.jcraft:jsch.agentproxy.pageant) osgi(com.jcraft.jsch.agentproxy.pageant) jsch-agent-proxy-connector-factory: jsch-agent-proxy-connector-factory mvn(com.jcraft:jsch.agentproxy.connector-factory) osgi(com.jcraft.jsch.agentproxy.connector-factory) jsch-agent-proxy-usocket-jna: jsch-agent-proxy-usocket-jna mvn(com.jcraft:jsch.agentproxy.usocket-jna) osgi(com.jcraft.jsch.agentproxy.usocket-jna) jsch-agent-proxy-javadoc: jsch-agent-proxy-javadoc Source checksums ---------------- https://github.com/ymnk/jsch-agent-proxy/archive/0.0.7.tar.gz#/jsch-agent-proxy-0.0.7.tar.gz : CHECKSUM(SHA256) this package : 13b2f13c6ab6f35762629ebfc6534ea08b2a166f72061f0a0f2fa61c7980b606 CHECKSUM(SHA256) upstream package : 13b2f13c6ab6f35762629ebfc6534ea08b2a166f72061f0a0f2fa61c7980b606 Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1048734 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG
Typo fixed. While trilead-ssh2 is available in Fedora, it doesn't provide necessary depmap. I've filed a request for that (bug #1048829), but the package fails to build and maintainer seems to be unresponsive (see bug #992812, last package activity in Mar 2009). trilead-ssh2 submodule is not needed for now, but I will enable it when trilead-ssh2 maintainer adds appropriate depmap (if ever). I would prefer trilead-ssh2 not to block this review. Readme files installed as %doc. Spec URL: http://mizdebsk.fedorapeople.org/review/jsch-agent-proxy/jsch-agent-proxy.spec SRPM URL: http://mizdebsk.fedorapeople.org/review/jsch-agent-proxy/jsch-agent-proxy-0.0.7-2.fc21.src.rpm
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6364023 One last thing: it seems like it doesn't own its directory /usr/share/java/jsch-agent-proxy (I missed it the first time) Other than that, it looks ok to me. APPROVED
I'll fix directory ownership during import. New Package SCM Request ======================= Package Name: jsch-agent-proxy Short Description: Proxy to ssh-agent and Pageant in Java Owners: mizdebsk sochotni msrb Branches: f20 InitialCC: java-sig
Git done (by process-git-requests).