Spec URL: http://petersen.fedorapeople.org/reviews/ghc-regex-posix.spec SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-regex-posix-0.95.2-29.fc20.src.rpm Description: The posix regex backend for regex-base.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6368329
This is a re-review to move this library out of haskell-platform. The original review is bug 556723. regex-posix has about 15 reverse deps in Fedora and 73 on Hackage. http://packdeps.haskellers.com/reverse/regex-posix
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [-]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "Unknown or generated", "BSD (4 clause)". 9 files have unknown license. Detailed output of licensecheck: BSD (2 clause) -------------- regex-posix-0.95.2/cbits/reallocf.c BSD (4 clause) -------------- regex-posix-0.95.2/cbits/cclass.h regex-posix-0.95.2/cbits/cname.h regex-posix-0.95.2/cbits/engine.c regex-posix-0.95.2/cbits/regcomp.c regex-posix-0.95.2/cbits/regex.h regex-posix-0.95.2/cbits/regex2.h regex-posix-0.95.2/cbits/regexec.c regex-posix-0.95.2/cbits/regfree.c regex-posix-0.95.2/cbits/utils.h Unknown or generated -------------------- regex-posix-0.95.2/Setup.hs regex-posix-0.95.2/Text/Regex/Posix.hs regex-posix-0.95.2/Text/Regex/Posix/ByteString.hs regex-posix-0.95.2/Text/Regex/Posix/ByteString/Lazy.hs regex-posix-0.95.2/Text/Regex/Posix/Sequence.hs regex-posix-0.95.2/Text/Regex/Posix/String.hs regex-posix-0.95.2/c-finalizer/myfree.c regex-posix-0.95.2/c-finalizer/myfree.h regex-posix-0.95.2/cbits/regerror.c [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 634880 bytes in 32 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Haskell: [x]: This should never happen ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: ghc-regex-posix-0.95.2-29.fc21.i686.rpm ghc-regex-posix-devel-0.95.2-29.fc21.i686.rpm ghc-regex-posix-0.95.2-29.fc21.src.rpm ghc-regex-posix.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end ghc-regex-posix.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ghc-regex-posix-devel ghc-regex-posix ghc-regex-posix.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end 2 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- ghc-regex-posix-devel (rpmlib, GLIBC filtered): /bin/sh ghc(regex-posix-0.95.2-a8ee0515a738a6310edfb0e4b226b857) ghc-compiler ghc-devel(array-0.4.0.1-6380782b62ead58fec616aa07dc0e15c) ghc-devel(base-4.6.0.1-ced5f3d8c90960e9f372129163296e44) ghc-devel(bytestring-0.10.0.2-0b6617b9eb506e75e23ac8e02aca9a35) ghc-devel(containers-0.5.0.0-3b8b869ec10d44736414ab5bea776319) ghc-devel(regex-base-0.93.2-6a541a53412d1d7d310fa69bca50c85f) ghc-regex-posix(x86-32) ghc-regex-posix (rpmlib, GLIBC filtered): ghc(array-0.4.0.1-6380782b62ead58fec616aa07dc0e15c) ghc(base-4.6.0.1-ced5f3d8c90960e9f372129163296e44) ghc(bytestring-0.10.0.2-0b6617b9eb506e75e23ac8e02aca9a35) ghc(containers-0.5.0.0-3b8b869ec10d44736414ab5bea776319) ghc(regex-base-0.93.2-6a541a53412d1d7d310fa69bca50c85f) libHSarray-0.4.0.1-ghc7.6.3.so libHSbase-4.6.0.1-ghc7.6.3.so libHSbytestring-0.10.0.2-ghc7.6.3.so libHScontainers-0.5.0.0-ghc7.6.3.so libHSdeepseq-1.3.0.1-ghc7.6.3.so libHSghc-prim-0.3.0.0-ghc7.6.3.so libHSinteger-gmp-0.5.0.0-ghc7.6.3.so libHSmtl-2.1.2-ghc7.6.3.so libHSregex-base-0.93.2-ghc7.6.3.so libHStransformers-0.3.0.0-ghc7.6.3.so libc.so.6 libgmp.so.10 rtld(GNU_HASH) Provides -------- ghc-regex-posix-devel: ghc-devel(regex-posix-0.95.2-a8ee0515a738a6310edfb0e4b226b857) ghc-regex-posix-devel ghc-regex-posix-devel(x86-32) ghc-regex-posix-static ghc-regex-posix: ghc(regex-posix-0.95.2-a8ee0515a738a6310edfb0e4b226b857) ghc-regex-posix ghc-regex-posix(x86-32) libHSregex-posix-0.95.2-ghc7.6.3.so Unversioned so-files -------------------- ghc-regex-posix: /usr/lib/ghc-7.6.3/regex-posix-0.95.2/libHSregex-posix-0.95.2-ghc7.6.3.so Source checksums ---------------- http://hackage.haskell.org/packages/archive/regex-posix/0.95.2/regex-posix-0.95.2.tar.gz : CHECKSUM(SHA256) this package : 56019921cd4a4c9682b81ec614236fea816ba8ed8785a1640cd66d8b24fc703e CHECKSUM(SHA256) upstream package : 56019921cd4a4c9682b81ec614236fea816ba8ed8785a1640cd66d8b24fc703e Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn ghc-regex-posix-0.95.2-29.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Haskell, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG -------------------- PACKAGE APPROVED.
Thank you for reviewing the package. Package Change Request ====================== Package Name: ghc-regex-posix New Branches: f20 f19 Owners: petersen InitialCC: haskell-sig
Git done (by process-git-requests).
Thanks again - built for f21 rawhide. I will backport before too long to F20.
ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, haskell-platform-2013.2.0.0-33.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-async-2.0.1.4-30.fc20,ghc-html-1.0.1.2-28.fc20,ghc-HTTP-4000.2.8-32.fc20,ghc-HUnit-1.2.5.2-31.fc20,ghc-network-2.4.1.2-31.fc20,ghc-parsec-3.1.3-30.fc20,ghc-QuickCheck-2.6-32.fc20,ghc-regex-base-0.93.2-28.fc20,ghc-regex-posix-0.95.2-29.fc20,ghc-transformers-0.3.0.0-33.fc20,haskell-platform-2013.2.0.0-33.fc20
ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, alex-3.0.5-36.fc20, cabal-install-1.16.0.2-34.fc20, ghc-parallel-3.2.0.3-34.fc20, ghc-regex-compat-0.95.1-34.fc20, ghc-syb-0.4.0-35.fc20, happy-1.18.10-34.fc20, haskell-platform-2013.2.0.0-36.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.