Bug 1049364 - mockchain ignores site-defaults.cfg
Summary: mockchain ignores site-defaults.cfg
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: mock
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-07 13:28 UTC by Daniel Narvaez
Modified: 2014-11-16 17:43 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-11-16 17:43:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
/etc/mock/site-defaults.cfg (7.25 KB, text/plain)
2014-01-12 17:53 UTC, Julian Sikorski
no flags Details
mockchain's site-defaults.cfg (7.25 KB, text/plain)
2014-01-12 17:54 UTC, Julian Sikorski
no flags Details
repo.cfg (7.32 KB, text/plain)
2014-01-12 17:56 UTC, Julian Sikorski
no flags Details

Description Daniel Narvaez 2014-01-07 13:28:37 UTC
I tried to disable the root_cache plugin in my /etc/mock/site-defaults.cfg, but mockchain apparently ignored the change.

If I understand things correctly, mockchain is putting all the defaults into the fedora-*.cfg (mockbuild.util.setup_default_config_opts), and that overrides site-defaults.cfg.

Comment 1 Julian Sikorski 2014-01-12 17:53:26 UTC
Same here. I have disabled ccache and enabled tmpfs in my site-defaults.cfg. mockchain carries them over to the site-defaults.cfg it generates, but then not to repo.cfg file.

Comment 2 Julian Sikorski 2014-01-12 17:53:58 UTC
Created attachment 848959 [details]
/etc/mock/site-defaults.cfg

Comment 3 Julian Sikorski 2014-01-12 17:54:44 UTC
Created attachment 848960 [details]
mockchain's site-defaults.cfg

Comment 4 Julian Sikorski 2014-01-12 17:56:50 UTC
Created attachment 848961 [details]
repo.cfg

Comment 5 Clark Williams 2014-01-20 18:28:41 UTC
Daniel (and Julian), 

The config specified on the command line is applied after the site-defaults, so if you change the root_cache plugin in the config, that overrides the site-defaults file. If you're using a stock config, it shouldn't touch any plugin configs, so changing it in site-defaults should work. 

Can you give me steps for reproducing the failure so that I can debug locally? I'm guessing I can use the /etc/mock/site-defaults that was attached so what I'm looking for is the mockchain command line you're using that is failing.

Comment 6 Julian Sikorski 2014-01-20 18:37:09 UTC
Clark,

the command line wasn't anything fancy - just -l and -r parameters and a few source rpms.

Comment 7 Julian Sikorski 2014-01-21 06:22:54 UTC
This is the exact command I used:
$ mockchain -l /var/tmp/mock-chain-julas-28957-WJWpel -r fedora-20-x86_64-rpmfusion_free ../../gmtk/devel/gmtk-1.0.9b-0.fc21.src.rpm gnome-mplayer-1.0.9b-0.fc21.src.rpm ../../gecko-mediaplayer/devel/gecko-mediaplayer-1.0.9b-0.fc21.src.rpm

Comment 8 Julian Sikorski 2014-03-24 06:56:43 UTC
Dear Clark,

is there any additional information you need?

Comment 9 Julian Sikorski 2014-09-25 05:38:26 UTC
This is still a problem with 1.1.41:

$ mockchain --continue -l . -r fedora-rawhide-x86_64-rpmfusion_free ../free/ffmpeg/devel/ffmpeg-2.4-1.fc21.src.rpm ../free/mplayer/devel/mplayer-1.1-26.20140919svn.fc21.src.rpm

Comment 10 Julian Sikorski 2014-09-25 06:17:25 UTC
I think the problem is that the default options are generated (line 204) before the site-defaults.cfg file is copied over (line 274). I tried correcting this by moving files around but I unfortunately don't have enough python knowledge to make it work.

Comment 11 Miroslav Suchý 2014-11-13 14:44:51 UTC
taking

Comment 12 Miroslav Suchý 2014-11-16 17:43:08 UTC
I tested it with mock-1.2.1 (I just released it and it may take few days to reach fedora repo) and it seems to be fixed. I'm not sure which commit fixed it.


Note You need to log in before you can comment on or make changes to this bug.