Spec URL: http://fedorapeople.org/~pahuang/enunciate-core-annotations.spec SRPM URL: http://fedorapeople.org/~pahuang/enunciate-core-annotations-1.27-1.fc19.src.rpm Description: Build-time enhancement tool for Java-based Web services projects. This package only builds the annotations which allow projects using enunciate to compile. Fedora Account System Username: pahuang
Running rpmlint rpmlint -i RPMS/noarch/enunciate-core-annotations-1.27-1.fc20.noarch.rpm enunciate-core-annotations.noarch: W: spurious-executable-perm /usr/share/doc/enunciate-core-annotations/license.txt The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. enunciate-core-annotations.noarch: W: spurious-executable-perm /usr/share/doc/enunciate-core-annotations/notice.txt The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not.
cmake-fedora-1.2.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/cmake-fedora-1.2.3-1.fc20
Sorry, wrong number in bodhi update.
updated: Spec URL: http://fedorapeople.org/~pahuang/enunciate-core-annotations.spec SRPM URL: http://fedorapeople.org/~pahuang/enunciate-core-annotations-1.27-2.fc19.src.rpm
===== MUST items ===== Maven: [!]: If package contains pom.xml files install it (including depmaps) even when building with ant The pom.xml does not shown in outputted rpm. ===== SHOULD items ===== [!]: Latest version is packaged. The latest version is now 1.28.
rpm -qlp enunciate-core-annotations-1.27-1.fc20.noarch.rpm /usr/share/doc/enunciate-core-annotations-1.27 /usr/share/doc/enunciate-core-annotations-1.27/README.md /usr/share/doc/enunciate-core-annotations-1.27/license.txt /usr/share/doc/enunciate-core-annotations-1.27/notice.txt /usr/share/java/enunciate-core-annotations /usr/share/java/enunciate-core-annotations/enunciate-core-annotations.jar /usr/share/maven-effective-poms/JPP.enunciate-core-annotations-enunciate-core-annotations.pom /usr/share/maven-fragments/enunciate-core-annotations.xml /usr/share/maven-poms/JPP.enunciate-core-annotations-enunciate-core-annotations.pom /usr/share/maven-poms/JPP.enunciate-core-annotations-org.codehaus.enunciate The pom.xml file is installed as /usr/share/maven-poms/JPP.enunciate-core-annotations-enunciate-core-annotations.pom See https://fedoraproject.org/wiki/Packaging:Java?rd=Packaging/Java#Maven_pom.xml_files_and_depmaps for detail.
Also, out put of rpmlint: enunciate-core-annotations.noarch: E: non-standard-dir-perm /usr/share/doc/enunciate-core-annotations 0644L
fixed permission: Spec URL: http://fedorapeople.org/~pahuang/enunciate-core-annotations.spec SRPM URL: http://fedorapeople.org/~pahuang/enunciate-core-annotations-1.27-3.fc19.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks - Javadoc subpackages should not have Requires: jpackage-utils Note: jpackage-utils requires are automatically generated by the buildsystem See: https://fedoraproject.org/wiki/Packaging:Java - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: http://fedoraproject.org/wiki/Packaging:Java#Pre- built_JAR_files_.2F_Other_bundled_software' ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "BSD (3 clause)", "Unknown or generated". 362 files have unknown license. Detailed output of licensecheck in /home/dchen/tmp /enunciate-core-annotations/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: enunciate-core-annotations-1.27-3.fc20.noarch.rpm enunciate-core-annotations-javadoc-1.27-3.fc20.noarch.rpm enunciate-core-annotations-1.27-3.fc20.src.rpm enunciate-core-annotations-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint enunciate-core-annotations-javadoc enunciate-core-annotat ions enunciate-core-annotations-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 2 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- enunciate-core-annotations-javadoc (rpmlib, GLIBC filtered): enunciate-core-annotations jpackage-utils enunciate-core-annotations (rpmlib, GLIBC filtered): java jpackage-utils mvn(javax.annotation:jsr250-api) Provides -------- enunciate-core-annotations-javadoc: enunciate-core-annotations-javadoc enunciate-core-annotations: enunciate-core-annotations mvn(org.codehaus.enunciate:enunciate-core-annotations) mvn(org.codehaus.enunciate:enunciate-parent) mvn(org.codehaus.enunciate:enunciate-parent:pom:) APPROVED
New Package SCM Request ======================= Package Name: enunciate-core-annotations Short Description: Build-time enhancement tool for Java-based Web services projects Owners: pahuang seanf Branches: f19 f20 InitialCC:
Git done (by process-git-requests).
enunciate-core-annotations-1.27-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/enunciate-core-annotations-1.27-3.fc19
enunciate-core-annotations-1.27-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/enunciate-core-annotations-1.27-3.fc20
enunciate-core-annotations-1.27-3.fc20 has been pushed to the Fedora 20 testing repository.
enunciate-core-annotations-1.27-3.fc19 has been pushed to the Fedora 19 stable repository.
enunciate-core-annotations-1.27-3.fc20 has been pushed to the Fedora 20 stable repository.