Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://ktdreyer.fedorapeople.org/reviews/perl-Test-Carp.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/perl-Test-Carp-0.2-1.fc21.src.rpm Description: Call given code (with given arguments) and tests whether the given Carp function (or their imported versions) are called (with a given value) or not. Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6377047
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- Test-Carp-0.2/lib/Test/Carp.pm [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Test(perl-Test-Harness, perl-Test-Requires, perl-Test-Pod, perl-Test-SharedFork, perl-Test-Deep, perl-Test- MockObject, perl-Test-TCP, perl-CPAN-Changes, perl-Test-Pod-Coverage, perl-Test-Simple) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: perl-Test-Carp-0.2-1.fc21.noarch.rpm perl-Test-Carp-0.2-1.fc21.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint perl-Test-Carp 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- perl-Test-Carp (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.18.1) perl(Carp) perl(Data::Dumper) perl(Test::More) perl(strict) perl(warnings) Provides -------- perl-Test-Carp: perl(Test::Carp) perl-Test-Carp Source checksums ---------------- http://www.cpan.org/modules/by-module/Test/Test-Carp-0.2.tar.gz : CHECKSUM(SHA256) this package : 8d0ea8edebc81b3ba4128ad8ef2238b76a1993db5d434758ceaec336b7ae743c CHECKSUM(SHA256) upstream package : 8d0ea8edebc81b3ba4128ad8ef2238b76a1993db5d434758ceaec336b7ae743c Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn perl-Test-Carp-0.2-1.fc21.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG ---------------------------- 1. Add BR of: perl(Carp) perl(strict) perl(warnings) 2. Remove lin not needed anymore: find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
Hi Christopher, thanks very much for the review. I've incorporated both of your suggestions in Release 2. Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/perl-Test-Carp.git/commit/?id=293ef329ad3158a9d5b9f40e37f2eecae4f6fe45 Spec URL: http://ktdreyer.fedorapeople.org/reviews/perl-Test-Carp.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/perl-Test-Carp-0.2-1.fc21.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6493131
Whoops, the SRPM URL is wrong. Fixing here: Spec URL: http://ktdreyer.fedorapeople.org/reviews/perl-Test-Carp.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/perl-Test-Carp-0.2-2.fc21.src.rpm
Built for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6496628 Closing. Thanks again.
Darn it, wrong bug. Sorry about that. Reopening.
PACKAGE APPROVED.
Thanks Christopher very much for the review. New Package SCM Request ======================= Package Name: perl-Test-Carp Short Description: Test your code for calls to Carp functions Owners: ktdreyer Branches: el6 epel7
Git done (by process-git-requests).
Built for Rawhide (F21): http://koji.fedoraproject.org/koji/buildinfo?buildID=496798 Thanks again for the review. Closing.