Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1051061

Summary: [notifier] MAIL_PORT=0 is nonsense as we are not binding but connecting to remote host
Product: Red Hat Enterprise Virtualization Manager Reporter: Jiri Belka <jbelka>
Component: ovirt-engine-notification-serviceAssignee: Martin Perina <mperina>
Status: CLOSED CURRENTRELEASE QA Contact: Tareq Alayan <talayan>
Severity: medium Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: aberezin, acathrow, emesika, gklein, iheim, pstehlik, Rhev-m-bugs, talayan, yeylon
Target Milestone: ---   
Target Release: 3.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: ovirt-3.4.0-beta2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-12 14:05:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
notifier.log none

Description Jiri Belka 2014-01-09 16:23:06 UTC 
Created attachment 847719 [details]
notifier.log

Description of problem:
MAIL_PORT=0 is nonsense as we are not binding but connecting to remote host.

http://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers#cite_note-TCP_port_0_usage-2

"Port 0 sometimes takes on a special meaning in network programming, particularly Unix socket programming. In that environment, port 0 is a programming technique for specifying system-allocated (dynamic) ports.

How would specify port 0, in C, to trigger the operating system to automatically search for and return the next available port in the dynamic port number range."

Version-Release number of selected component (if applicable):
is31 - rhevm-tools-3.3.0-0.44.el6ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. MAIL_PORT=0 ; restart of the app
2. tcpdump, notifier.log
3.

Actual results:
the apps tries to connect to remote tcp port '0'. nothing like tcp port '0' exists (IIUC)

Expected results:
fail

Additional info:
maybe it should be reported upstream (java lib)
Comment 1 Yair Zaslavsky 2014-01-10 02:40:17 UTC 
I would add validations not just that mail_port is numercial but also a non zero number (any other validations are required?)
Comment 2 Tareq Alayan 2014-02-17 17:18:05 UTC 
/etc/init.d/ovirt-engine-notifier restart
Stopping oVirt Engine Notifier:                            [FAILED]
Starting oVirt Engine Notifier: 
Validation result:
stderr: Check configuration file, MAIL_PORT value has to be in range from 1 to 65535, currently '0'
Validation failed returncode is 1:
                                                           [FAILED]


tested on ovirt-engine-tools-3.4.0-0.7.beta2.el6.noarch
Comment 3 Itamar Heim 2014-06-12 14:05:06 UTC 
Closing as part of 3.4.0