Spec URL: http://goldmann.fedorapeople.org/package_review/netty-xnio-transport/1/netty-xnio-transport.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/netty-xnio-transport/1/netty-xnio-transport-0.1.1-0.1.CR2.fc20.src.rpm Fedora Account System Username: goldmann Description: This is a Netty Transport powered by XNIO. It can be used to either wrap an existing StreamConnection and AcceptingChannel or to bootstrap a Netty powered server directly. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6383980 Please make sure you review this package on *Fedora 20*, since we're in the process of changing the versions of netty in Rawhide.
Sorry, i cant review this package cause: problem/s with mock on my system INFO: Installed packages: Finish: run None Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/FedoraReview/mock.py", line 491, in init self._rpm_eval('%{_libdir}') File "/usr/lib/python2.7/site-packages/FedoraReview/mock.py", line 259, in _rpm_eval return check_output(cmd).decode('utf-8').strip() File "/usr/lib/python2.7/subprocess.py", line 575, in check_output raise CalledProcessError(retcode, cmd, output=output) CalledProcessError: Command '['mock', '--no-cleanup-after', '--no-clean', '--resultdir=/home/gil/1051485-netty-xnio-transport/srpm/review-netty-xnio-transport/results', '--quiet', '--shell', 'rpm --eval \\"%{_libdir}\\"']' returned non-zero exit status 90 DEBUG: Url download completed: 562.876 DEBUG: Exception down the road... Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 232, in run self._do_run(outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 222, in _do_run self._do_report(outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 96, in _do_report self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 105, in _run_checks self.checks = Checks(spec, srpm) File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 268, in __init__ _ChecksLoader.__init__(self) File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 166, in __init__ self._load_checks() File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 204, in _load_checks tests = registry.register(plugin) File "/usr/lib/python2.7/site-packages/FedoraReview/registry.py", line 130, in register obj = (c[1])(self.checks) File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic_should.py", line 80, in __init__ if self.flags['EPEL5']: KeyError: 'EPEL5' ERROR: Exception down the road...(logs in /home/gil/.cache/fedora-review.log) DEBUG: Report completed: 563.257 seconds
Spec URL: http://goldmann.fedorapeople.org/package_review/netty-xnio-transport/2/netty-xnio-transport.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/netty-xnio-transport/2/netty-xnio-transport-0.1.1-0.2.CR2.fc20.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6396008 You can now review it in Rawhide too.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - This seems like a Java package, please install fedora-review-plugin-java to get additional checks ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 20 files have unknown license. Detailed output of licensecheck in /home/gil/1051485-netty-xnio-transport/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in netty-xnio- transport-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint IGNORE [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.1.33 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.33 INFO: Mock Version: 1.1.33 Start: lock buildroot INFO: installing package(s): /home/gil/1051485-netty-xnio-transport/results/netty-xnio-transport-0.1.1-0.2.CR2.fc21.noarch.rpm /home/gil/1051485-netty-xnio-transport/results/netty-xnio-transport-javadoc-0.1.1-0.2.CR2.fc21.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/', 'install', '/home/gil/1051485-netty-xnio-transport/results/netty-xnio-transport-0.1.1-0.2.CR2.fc21.noarch.rpm', '/home/gil/1051485-netty-xnio-transport/results/netty-xnio-transport-javadoc-0.1.1-0.2.CR2.fc21.noarch.rpm', '--setopt=tsflags=nocontexts'] Errore: Pacchetto: netty-xnio-transport-0.1.1-0.2.CR2.fc21.noarch (/netty-xnio-transport-0.1.1-0.2.CR2.fc21.noarch) Richiede: mvn(io.netty:netty-buffer:4) Errore: Pacchetto: netty-xnio-transport-0.1.1-0.2.CR2.fc21.noarch (/netty-xnio-transport-0.1.1-0.2.CR2.fc21.noarch) Richiede: mvn(io.netty:netty-transport:4) Si può provare ad usare --skip-broken per aggirare il problema Provare ad eseguire: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: netty-xnio-transport-0.1.1-0.2.CR2.fc21.noarch.rpm netty-xnio-transport-javadoc-0.1.1-0.2.CR2.fc21.noarch.rpm netty-xnio-transport-0.1.1-0.2.CR2.fc21.src.rpm netty-xnio-transport-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- netty-xnio-transport-javadoc (rpmlib, GLIBC filtered): jpackage-utils netty-xnio-transport (rpmlib, GLIBC filtered): java jpackage-utils mvn(io.netty:netty-buffer:4) mvn(io.netty:netty-transport:4) mvn(org.jboss.xnio:xnio-api) Provides -------- netty-xnio-transport-javadoc: netty-xnio-transport-javadoc netty-xnio-transport: mvn(org.jboss.xnio.netty:netty-xnio-transport) netty-xnio-transport Source checksums ---------------- https://github.com/xnio/netty-xnio-transport/archive/netty-xnio-transport-0.1.1.CR2.tar.gz : CHECKSUM(SHA256) this package : 63cec666ab6b4985fa85d5d83c6bdc44a3b5da9beb7d1332783b238d24a40e7a CHECKSUM(SHA256) upstream package : 63cec666ab6b4985fa85d5d83c6bdc44a3b5da9beb7d1332783b238d24a40e7a Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -v -b 1051485 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thanks! New Package SCM Request ======================= Package Name: netty-xnio-transport Short Description: Netty Transport powered by XNIO Owners: goldmann Branches: f20
Git done (by process-git-requests).