Bug 1051604 - Add ppc64le to the exclude arch in libbluray
Summary: Add ppc64le to the exclude arch in libbluray
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libbluray
Version: rawhide
Hardware: ppc64le
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Xavier Bachelot
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F-ExcludeArch-ppc64le, PPC64LETracker
TreeView+ depends on / blocked
 
Reported: 2014-01-10 16:46 UTC by Brent Baude
Modified: 2014-01-10 19:29 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-10 19:29:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Brent Baude 2014-01-10 16:46:03 UTC
Please consider the following patch to enable ppc64le for libbluray.  As you can see, it closely follows the enablement for ppc64 and ppc.


diff --git a/libbluray.spec b/libbluray.spec
index 9ae9103..28d299c 100644
--- a/libbluray.spec
+++ b/libbluray.spec
@@ -32,7 +32,7 @@ BuildRequires:  autoconf
 BuildRequires:  automake
 BuildRequires:  libtool
 %endif
-%ifnarch ppc ppc64
+%ifnarch ppc ppc64 ppc64le
 BuildRequires:  java-devel >= 1:1.6.0 
 BuildRequires:  jpackage-utils
 BuildRequires:  ant
@@ -52,7 +52,7 @@ current titles, and will be easily portable and embeddable in standard players
 such as mplayer and vlc.
 
 
-%ifnarch ppc ppc64
+%ifnarch ppc ppc64 ppc64le
 %package        bdj
 Summary:        BDJ support for %{name}
 Group:          Development/Libraries
@@ -108,7 +108,7 @@ export JDK_HOME="%{_jvmdir}/java-1.7.0"
            --disable-doxygen-ps \
            --enable-doxygen-html \
            --enable-examples \
-%ifnarch ppc ppc64
+%ifnarch ppc ppc64 ppc64le
            --enable-bdjava
 %endif
 
@@ -133,7 +133,7 @@ do install -Dp -m 0755 src/examples/$i $RPM_BUILD_ROOT%{_bindir}/$i; done;
 for i in bd_info bdsplice hdmv_test libbluray_test list_titles;
 do install -Dp -m 0755 src/examples/.libs/$i %{buildroot}%{_bindir}/$i; done;
 
-%ifnarch ppc ppc64
+%ifnarch ppc ppc64 ppc64le
 install -Dp -m755 src/examples/.libs/bdj_test %{buildroot}%{_bindir}/bdj_test;
 %endif
 
@@ -152,7 +152,7 @@ rm -rf $RPM_BUILD_ROOT
 %doc COPYING README.txt
 %{_libdir}/*.so.*
 
-%ifnarch ppc ppc64
+%ifnarch ppc ppc64 ppc64le
 %files bdj
 %defattr(-,root,root,-)
 %{_libdir}/libbluray/libbluray.jar

Comment 1 Xavier Bachelot 2014-01-10 17:03:44 UTC
Adding ppc64le to the %ifnarch would actually disable building of the BD-J support for ppc64le. BD-J support is disabled for PPC variants because there's no openjdk packages for these archs. If there is indeed no openjdk for ppc64le, then disabling BD-J on this arch will allow it to build. So the change might actually be right but the subject of the bug would be wrong.

Comment 2 Brent Baude 2014-01-10 18:21:17 UTC
I've changed the title to your point.  There is no openjdk for ppc64le yet, but eventually will be.  In the meanwhile, this allows me to build libbluray for ppc64le.  Thanks.

ps. there certainly IS an openjdk for ppc64 and ppc; it does however lack the JIT component (http://ppc.koji.fedoraproject.org/koji/buildinfo?buildID=203062)

Comment 3 Xavier Bachelot 2014-01-10 19:29:51 UTC
I've just built a package with the change in Rawhide.


Note You need to log in before you can comment on or make changes to this bug.