Spec URL: http://asrob.fedorapeople.org/drupal7-webform.spec SRPM URL: http://asrob.fedorapeople.org/drupal7-webform-4.0-0.1.beta1.fc21.src.rpm Description: Webform is the module for making surveys in Drupal. After a submission, users may be sent an e-mail "receipt" as well as sending a notification to administrators. Results can be exported into Excel or other spreadsheet applications. Webform also provides some basic statistical review and has and extensive API for expanding its features. Some good examples could be contests, personalized contact forms, or petitions. Each of these could have a customized form for end-users to fill out. If you need to build a lot of customized, one-off forms, Webform is a more suitable solution than creating content types and using CCK or Field module. Fedora Account System Username: asrob Koji build url: http://koji.fedoraproject.org/koji/taskinfo?taskID=6389618 $ rpmlint drupal7-webform-4.0-0.1.beta1.fc21.noarch.rpm drupal7-webform-4.0-0.1.beta1.fc21.src.rpm ../rpmbuild/SPECS/drupal7-webform.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Created attachment 850460 [details] phpcompatinfo.log phpcompatinfo version 2.26.0
Created attachment 850461 [details] fedora-review.txt Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --define EPEL5 -b 1051753 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, BATCH, DISTTAG
Created attachment 850462 [details] fedora-review.txt Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --define EPEL5 -b 1051753 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, BATCH, DISTTAG
[x]: Package consistently uses macros (instead of hard-coded directory names). Since you define the "prerelease" global, instead of 0.1.beta1%{?dist} should use 0.1.%{prerelease}%{?dist} [!]: Requires correct, justified where necessary. Instead of Requires: php >= 5.3 need to use Requires: php-common >= 5.3 (see https://fedoraproject.org/wiki/Packaging:PHP#Requiring_a_Minimum_PHP_version) (side note: if not packaging for EPEL5 "php(language)" would be used) According to phpcompatinfo (version 2.26.0), need to add the following: # phpcompatinfo (computed from version 4.0-beta1) Requires: php-date Requires: php-mbstring Requires: php-pcre Requires: php-pdo Requires: php-pecl(zip) Requires: php-session (see https://fedoraproject.org/wiki/Packaging:PHP#Extensions_Requires) Only the requires is a blocker. The macro usage one is just a "should" note.
Hi Shawn! First of all, thanks for reviewing! I updated .spec and src files, I hope they will be good.
I updated .spec and src files.
Sorry for the delay! In the future, will you bump the release (and add a changelog entry) for every change? It makes it easier to diff the changes you made. [x]: Requires correct, justified where necessary. No blockers. ===== APPROVED =====
Hi Shawn! No problem! :) Yes, I'll bump the release for every change. Now, I just wanted to create a proper release. Thank you!
New Package SCM Request ======================= Package Name: drupal7-webform Short Description: Webform is the module for making surveys in Drupal Owners: asrob Branches: f20 f19 el6 InitialCC:
Git done (by process-git-requests).
drupal7-webform-4.0-0.1.beta1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/drupal7-webform-4.0-0.1.beta1.fc20
drupal7-webform-4.0-0.1.beta1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/drupal7-webform-4.0-0.1.beta1.fc19
drupal7-webform-4.0-0.1.beta1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal7-webform-4.0-0.1.beta1.el6
drupal7-webform-4.0-0.1.beta1.fc19 has been pushed to the Fedora 19 stable repository.
drupal7-webform-4.0-0.1.beta1.fc20 has been pushed to the Fedora 20 stable repository.
drupal7-webform-4.0-0.1.beta1.el6 has been pushed to the Fedora EPEL 6 stable repository.
drupal7-webform-4.0-0.2.beta1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/drupal7-webform-4.0-0.2.beta1.fc19
drupal7-webform-4.0-0.2.beta1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.