Please continue the work of splitting setup to multiple subpackages.
1. split constants to [at least] base and engine-common.
2. rename packages within setup/ovirt_engine_setup to have some prefix or submodules so that can be included only in correct packages.
alon, can you check current status and see if we're missing still something?
(In reply to Sandro Bonazzola from comment #1)
> alon, can you check current status and see if we're missing still something?
I hope so, I did not follow your changes, nor if you completed the last round of comments.
Moving to QA. Nothing to verify here really. package names and functions remained basically the same as in 3.4, the actual content was cleaned up and dependencies were loosened. Main reason was to allow setup of engine/websocket-proxy/dwh/reports on separate hosts.
ok based on #3. fyi separate setup of websocket proxy works, iirc the same applies for dwh/reports.