Spec URL: http://ojuba.org/oji/SPECS/python-tashaphyne.spec SRPM URL: http://ojuba.org/oji/SRPMS/python-tashaphyne-0.2-1.fc20.src.rpm Description: Arabic language text Stemmer and segmenter to be used by Python. Fedora Account System Username: moceap
Same like other packages of this upstream, please query license info from him also. Others are fine.
Sorry, - Infact it's GPLv1 not v2. Spec URL: http://ojuba.org/oji/SPECS/python-tashaphyne.spec SRPM URL: http://ojuba.org/oji/SRPMS/python-tashaphyne-0.2-2.fc20.src.rpm
I hope you can ask upstream to include a license in the tarball and reupload to pypi if possible. Thoughts?
I'll do >>>
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 6 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- Tashaphyne-0.2/setup.py Tashaphyne-0.2/tashaphyne/__init__.py Tashaphyne-0.2/tashaphyne/arabic_const.py Tashaphyne-0.2/tashaphyne/normalize.py Tashaphyne-0.2/tashaphyne/stem_const.py Tashaphyne-0.2/tashaphyne/stemming.py [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python-tashaphyne-0.2-2.fc21.noarch.rpm python-tashaphyne-0.2-2.fc21.src.rpm python-tashaphyne.noarch: W: spelling-error Summary(en_US) segmenter -> segmented, segment er, segment-er python-tashaphyne.noarch: I: enchant-dictionary-not-found ar python-tashaphyne.noarch: W: spelling-error %description -l en_US segmenter -> segmented, segment er, segment-er python-tashaphyne.noarch: W: invalid-url URL: https://pypi.python.org/pypi/Tashaphyne <urlopen error timed out> python-tashaphyne.noarch: W: no-documentation python-tashaphyne.src: W: spelling-error Summary(en_US) segmenter -> segmented, segment er, segment-er python-tashaphyne.src: W: spelling-error %description -l en_US segmenter -> segmented, segment er, segment-er python-tashaphyne.src: W: strange-permission Tashaphyne-0.2.zip 0600L 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-tashaphyne python-tashaphyne.noarch: W: spelling-error Summary(en_US) segmenter -> segmented, segment er, segment-er python-tashaphyne.noarch: I: enchant-dictionary-not-found ar python-tashaphyne.noarch: W: spelling-error %description -l en_US segmenter -> segmented, segment er, segment-er python-tashaphyne.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- python-tashaphyne (rpmlib, GLIBC filtered): python(abi) Provides -------- python-tashaphyne: python-tashaphyne Source checksums ---------------- https://pypi.python.org/packages/source/T/Tashaphyne/Tashaphyne-0.2.zip : CHECKSUM(SHA256) this package : cf9f6fae718e527c3242f23a8b15db068d262a85f9c27b69ff034ac4c0b6832c CHECKSUM(SHA256) upstream package : cf9f6fae718e527c3242f23a8b15db068d262a85f9c27b69ff034ac4c0b6832c Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn python-tashaphyne-0.2-2.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG --------8<-------------------- 1. Add %doc README 2. %description: Arabic language text Stemmer and segmenter to be used by Python. --> Arabic language text Stemmer and segmenter to be used by Python. --------------------->8------- FIX ABOVE BEFORE SCM. PACKAGE APPROVED.
Thanks , OK . New Package SCM Request ======================= Package Name: python-tashaphyne Short Description: Arabic Light Stemmer and segmenter Owners: moceap Branches: f19 f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
python-tashaphyne-0.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-tashaphyne-0.2-1.fc19
python-tashaphyne-0.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-tashaphyne-0.2-1.el6
python-tashaphyne-0.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-tashaphyne-0.2-1.fc20
python-tashaphyne-0.2-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
python-tashaphyne-0.2-1.fc19 has been pushed to the Fedora 19 stable repository.
python-tashaphyne-0.2-1.fc20 has been pushed to the Fedora 20 stable repository.
python-tashaphyne-0.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
Package Change Request ====================== Package Name: python-tashaphyne New Branches: epel7 Owners: moceap