Bug 1052149 - no square-loading-animation when changing left-pane-tree selection
Summary: no square-loading-animation when changing left-pane-tree selection
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-webadmin
Version: 3.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.4.0
Assignee: Alexander Wels
QA Contact: Petr Beňas
URL:
Whiteboard: ux
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-13 12:11 UTC by Juan Pablo Lorier
Modified: 2015-01-04 23:05 UTC (History)
9 users (show)

Fixed In Version: ovirt-3.4.0-beta3
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-31 12:27:53 UTC
oVirt Team: ---
Embargoed:


Attachments (Terms of Use)
webadmin snapshot (141.98 KB, image/jpeg)
2014-01-13 12:19 UTC, Juan Pablo Lorier
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 23951 0 None None None Never
oVirt gerrit 24120 0 None None None Never

Description Juan Pablo Lorier 2014-01-13 12:11:54 UTC
Description of problem:

By selecting a particular item (not a category)  in left tree it doesn't display selected item info

Version-Release number of selected component (if applicable):

3.3.1 & 3.3.2

How reproducible:

Steps to Reproduce:
1.select an item (ie a host or a storage) from the left tree
2.
3.

Actual results:

It keeps showing the last info in the right panel

Expected results:

Should show the info related to the item selected

Additional info:

in some cases, it also happens with chrome, but with firefox happens in every case

Comment 1 Juan Pablo Lorier 2014-01-13 12:19:50 UTC
Created attachment 849295 [details]
webadmin snapshot

Here you can see that after been at storage category, by selecting a host, it still stays in the storage category.

Comment 2 Einav Cohen 2014-01-13 13:51:01 UTC
take a look at the search bar: you will notice that the search bar text-box now contains: "Storage: host.name = Dell3", and the 'Storage' main tab indeed contains all the storage domains that belong to the Data-Center ('Gluster') to which 'Dell3' belong. 

This is a correct, by design behavior: If we are on a certain main-tab, and then selecting a different tree-node, we won't change the selected main-tab (unless absolutely necessary). 

This is the behavior since http://gerrit.ovirt.org/#/c/13516/ has been merged. 

So this is not a bug; However, in order to improve the visual feedback to the user (i.e. show him that "something is happening due to his tree-node selection change, even if displayed results will eventually remain unchanged), we will make sure to display a loading animation when changing the left-pane tree selection -> changing the BZ subject accordingly. thanks.

Comment 3 Juan Pablo Lorier 2014-01-14 11:57:05 UTC
Hi Elinav,

I'm sorry but I don't get the benefit of not changing the view to what the user selects. By my understanding, if I click something is because I want to see that, otherwise I wouldn't even clikc anything.
For instance, if I'm looking at the vms and then I choose a host, what's the porpouse of showing the vms tab with no info (even when that host has running vms in wich case you may show them and at least it acts as a filter) and then I have to move to hosts tab, then choose again the host, etc... doesn't seem logical to me.
Regards,

Comment 4 Einav Cohen 2014-01-14 20:49:38 UTC
(In reply to Juan Pablo Lorier from comment #3)
> Hi Einav,
> 
> I'm sorry but I don't get the benefit of not changing the view to what the
> user selects. By my understanding, if I click something is because I want to
> see that, otherwise I wouldn't even clikc anything.
> For instance, if I'm looking at the vms and then I choose a host, what's the
> porpouse of showing the vms tab with no info (even when that host has
> running vms in wich case you may show them and at least it acts as a filter)
> and then I have to move to hosts tab, then choose again the host, etc...
> doesn't seem logical to me.
> Regards,

Hi Juan, I guess that different people have different use cases. 

For instance, if I would like to conveniently go through all Clusters and for each Cluster - see the list of VMs that are associated with that Cluster, it is very convenient for me to do so by selecting the Clusters, one after another, in the tree, while keeping "focus" on the VMs main tab. 

Your suggestion would result in jumping back and forth to the Clusters/VMs main tabs (since after each tree selection change, the "focused" main tab will become the "Clusters" one, so each time I will have to navigate back to the VMs main tab in order to see the relevant list of VMs). 

If you want to scroll through the list of Hosts in the tree while being in the Hosts main tab - no problem; you may need to change the "focused" main tab for the first Host that you select, but after that - you will remain on the Hosts main tab for the following tree-selection changes. 

So overall, I believe that the current behavior is a better one. 

If you are still not convinced, please send an open question to the users mailing list. 

thanks.

Comment 5 Juan Pablo Lorier 2014-01-17 12:01:17 UTC
Hi Einav,

Sorry for the late reply. I undestand that others may take adventage of this beheavior, so I assume it as the right one.
Regards,

Comment 6 Alexander Wels 2014-02-01 00:34:21 UTC
Einav,

After testing the associated patch, I was concerned about basically the same thing that Juan Pablo mentioned, that the main tab didn't change based on what I selected in the system tree. Your explanation also makes sense but I definitely had a what is going on moment and I had to read the explanation to understand what was going on.

Maybe we can have a discussion with our UIX people (if we haven't done so already) about this issue. In the meantime I fixed the loading animation happening when you click the different items in the system tree.

Comment 7 Sandro Bonazzola 2014-02-19 12:27:46 UTC
This bug is referenced in ovirt-engine-3.4.0-beta3 logs. Moving to ON_QA

Comment 8 Petr Beňas 2014-02-19 16:31:37 UTC
Verified in 3.4.0-0.11.beta3.el6.

Comment 9 Sandro Bonazzola 2014-03-31 12:27:53 UTC
this is an automated message: moving to Closed CURRENT RELEASE since oVirt 3.4.0 has been released


Note You need to log in before you can comment on or make changes to this bug.