Created attachment 849813 [details] mikmod plugin fix for xmms Description of problem: xmms mikmod plugin is broken for libmikmod >= 3.2.0 which, AFAIK has been included in Fedora since Fedora9 or something. libmikmod >= 3.2.0 inserts a "char* CmdLineHelp" member into the MDRIVER structure, but xmms' Input/mikmod/drv_xmms.c doesn't handle that. A patch is attached here to fix that. Version-Release number of selected component (if applicable): All xmms-1.2.x in all Fedora releases since f9 including rawhide. How reproducible: Always. Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: Here is a trivial patch to fix the issue: (also attached, in case it gets mangled.) Tested by editing the xmms spec from rawhide and rebuilding+running on x86_64. diff -up xmms-1.2.11/Input/mikmod/drv_xmms.c~ xmms-1.2.11/Input/mikmod/drv_xmms.c --- xmms-1.2.11/Input/mikmod/drv_xmms.c~ 2003-05-20 00:22:06.000000000 +0300 +++ xmms-1.2.11/Input/mikmod/drv_xmms.c 2013-10-01 12:02:10.000000000 +0200 @@ -124,7 +124,15 @@ MDRIVER drv_xmms = "xmms output driver v1.0", 0, 255, #if (LIBMIKMOD_VERSION > 0x030106) +/* Alias string */ "xmms", +#endif +#if (LIBMIKMOD_VERSION >= 0x030200) +/* CmdLineHelp string */ + NULL, +#endif +#if (LIBMIKMOD_VERSION > 0x030106) +/* CommandLine proc */ NULL, #endif xmms_IsThere,
xmms-1.2.11-20.20071117cvs.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/xmms-1.2.11-20.20071117cvs.fc20
xmms-1.2.11-20.20071117cvs.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/xmms-1.2.11-20.20071117cvs.fc19
Package xmms-1.2.11-20.20071117cvs.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing xmms-1.2.11-20.20071117cvs.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-2335/xmms-1.2.11-20.20071117cvs.fc19 then log in and leave karma (feedback).
xmms-1.2.11-20.20071117cvs.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
xmms-1.2.11-20.20071117cvs.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.