Bug 1052918 - Problems with adding java.lang.String as data type
Summary: Problems with adding java.lang.String as data type
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss BPMS Platform 6
Classification: Retired
Component: Eclipse Tooling
Version: 6.0.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ER2
: 6.0.1
Assignee: Robert (Bob) Brodt
QA Contact: Marek Baluch
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-14 11:59 UTC by Andrej Podhradsky
Modified: 2014-08-06 20:02 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-06 20:02:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Eclipse Project 425643 0 None None None Never

Description Andrej Podhradsky 2014-01-14 11:59:49 UTC
Description of problem:
1. Select tab Definitions
2. Add new data type java.lang.String

So many data types and messages are created. And the following error occurs

"Operation has missing or incomplete In Message"

Comment 1 Robert (Bob) Brodt 2014-01-14 14:15:49 UTC
The editor creates Operations for all public methods discovered for the imported Java type; the BPMN2 spec states that an Operation has exactly one input message, zero or one output message and zero or one fault definition. In terms of Java methods, this translates to one method parameter, a void or non-void return type, and an optional, single "throws" declaration.

Should the importer be changed to only look for Java methods that match those criteria? If so, the java.lang.String Interface would still have 35 Operations.

What is the desired behavior here?

Comment 2 Marek Baluch 2014-01-14 14:34:38 UTC
Bob,

IMHO adding/defining a new data type is different then importing it's interface. There are already predefined basic types like Boolean, Integer (and yes also String) without all the types which are referenced in their API.

I think that the scanning process should only be applied when importing an Interface - not when defining a new data type.

What do you think?

Comment 3 Robert (Bob) Brodt 2014-01-14 14:59:34 UTC
Hi Marek,

That seems like a reasonable thing to do. I'd also like to add a selection widget to the Interface Import dialog that allows the user to select the methods (the ones that meet the BPMN2 spec criteria for Operations) for which Operations will be created. Does that sound like a plan?

Comment 4 Marek Baluch 2014-01-14 15:04:45 UTC
Yes it does - actually that sounds great! :)

Comment 5 Robert (Bob) Brodt 2014-01-15 00:42:37 UTC
Done

Comment 6 Marek Baluch 2014-03-20 12:01:29 UTC
Verified on JBDSIS 7.0.1.CR1


Note You need to log in before you can comment on or make changes to this bug.