Description of problem: The oo-diagnostics script does not differentiate between nodes and brokers when checking enterprise rpms. This can cause issues to be reported that are not actually issues. For instance, facter is not usually installed on the broker, but in many cases will be due to it being a dependency for puppet. When facter is installed on the broker, the oo-diagnostics script will complain about the version because it is not the 'el6op' package. It should not be complaining about this at all because it has no reason to check the broker for the facter package. Version-Release number of selected component (if applicable): 2.0 How reproducible: Always Steps to Reproduce: 1. Install puppet on a broker, which requires a thrid-party facter package 2. Run oo-diagnostics Actual results: FAIL: test_enterprise_rpms The following problems were found with your RPMs: facter should be an OpenShift Enterprise RPM but installed version 1.7.4-1.el6 does not have 'el6op' in it Please ensure that you have not enabled EPEL or other third-party repositories, and do not have any of these RPMs pre-installed in your install image. These RPMs must come from your OpenShift Enterprise subscription in order to be supported. Expected results: No errors
I removed that test from oo-diagnostics in Origin since it didn't make sense there anyway.