Bug 1053483 - RHQ Admin UI references 'Cassandra' rather than storage node
Summary: RHQ Admin UI references 'Cassandra' rather than storage node
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Storage Node
Version: JON 3.2
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: DR01
: JON 3.3.0
Assignee: Libor Zoubek
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-15 10:29 UTC by Alan Santos
Modified: 2015-11-02 00:43 UTC (History)
5 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2014-12-11 14:00:03 UTC


Attachments (Terms of Use)

Description Alan Santos 2014-01-15 10:29:12 UTC
Inventory tree label is:

/storage nodes/RHQ Storage Node/"Cassandra Server JVM "


Should not refer to storage node JVM with an implementation detail. Simple 'JVM' seems sufficient in the context of a tree. In other views that may not be sufficient.

Comment 1 Libor Zoubek 2014-07-14 11:28:28 UTC
I can see 2 ways of fixing this.

1. rename resource type. This would cause the original "Cassandra Server JVM" resources to disappear (all metrics history is probably gone) and new "JVM" would be discovered.
 - drawback - metric history is lost

2. keep resource type name and update discovery/upgrade code - this approach keeps all metrics and can rename existing resources and give proper name ("JVM") to new resources. 
 - drawback - resource type is still called "Cassandra JVM Server"

3. may be to add support for resource type name change to plugin descriptor (ie. via new attribute oldName), then we can pair old and new resource type and we don't remove the old type and insert new one.

1 and 2 is very easy to implement.

Comment 2 Libor Zoubek 2014-07-16 20:55:05 UTC
in master
commit 2ecfe17b0e6c067c58de7dfef12bcb1c214b0190
Author: Libor Zoubek <lzoubek@redhat.com>
Date:   Mon Jul 14 14:39:16 2014 +0200

    Bug 1053483 - RHQ Admin UI references 'Cassandra' rather than storage node

    Cassandra Server JVM resources renamed to JVM

Based on https://github.com/rhq-project/rhq/pull/84 option #2 was chosen, while option #3 can be easily implemented in future (depends on Bug 1119802).

Comment 3 Simeon Pinder 2014-07-31 15:52:05 UTC
Moving to ON_QA as available to test with brew build of DR01: https://brewweb.devel.redhat.com//buildinfo?buildID=373993


Note You need to log in before you can comment on or make changes to this bug.