Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-statsmodels.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-statsmodels-0.5.0-3.fc20.src.rpm Description: statsmodels is a Python module that provides classes and functions for the estimation of many different statistical models, as well as for conducting statistical tests, and statistical data exploration. An extensive list of result statistics are available for each estimator. The results are tested against existing statistical packages to ensure that they are correct. Fedora Account System Username: sergiopr
This version handles better the matplotlib based tests Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-statsmodels.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-statsmodels-0.5.0-4.fc20.src.rpm
You have my vote. I'm really interested in that package. Thanks
OK, I'll review this one.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) Why is LICENSE.txt is removed? See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - License file installed when any subpackage combination is installed. Part of problem is that LICENSE.txt et. al. are removed. Another is that the subpackages does not require the base package and thus can be installed without license info. Either require the base package or (IMHO better) duplicate the license files in the subpackages. - Package consistently uses macros (instead of hard-coded directory names). Personally, I don't see the need for the upname macro. It just makes things harder to read. Also, since the python3 stuff isn't functional I think it's better to remove for now, re-introducing it once it works. No blockers. - Add a -a option to the cp command in %build to preserve timestamps. - The find command has a '-delete' option which is somewhat cleaner. No blocker. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Public domain", "BSD (2 clause)", "Unknown or generated". 616 files have unknown license. Detailed output of licensecheck in /home/mk/FedoraReview/1053640-python-statsmodels/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- statsmodels-doc I have no problems with this, besides missing license files. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-statsmodels-0.5.0-4.fc21.i686.rpm python-statsmodels-doc-0.5.0-4.fc21.noarch.rpm python-statsmodels-0.5.0-4.fc21.src.rpm python-statsmodels.src:109: W: macro-in-comment %{__python3} 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-statsmodels python-statsmodels-doc 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- python-statsmodels (rpmlib, GLIBC filtered): libc.so.6 libpthread.so.0 libpython2.7.so.1.0 numpy python(abi) python-pandas python-patsy rtld(GNU_HASH) scipy python-statsmodels-doc (rpmlib, GLIBC filtered): Provides -------- python-statsmodels: python-statsmodels python-statsmodels(x86-32) python-statsmodels-doc: python-statsmodels-doc Unversioned so-files -------------------- python-statsmodels: /usr/lib/python2.7/site-packages/statsmodels/nonparametric/_smoothers_lowess.so python-statsmodels: /usr/lib/python2.7/site-packages/statsmodels/nonparametric/linbin.so python-statsmodels: /usr/lib/python2.7/site-packages/statsmodels/tsa/kalmanf/kalman_loglike.so Source checksums ---------------- http://pypi.python.org/packages/source/s/statsmodels/statsmodels-0.5.0.tar.gz : CHECKSUM(SHA256) this package : 65398518bdd414c712362738e61d34ee5ec07b4c084bba17c65af5f20ae109d0 CHECKSUM(SHA256) upstream package : 65398518bdd414c712362738e61d34ee5ec07b4c084bba17c65af5f20ae109d0 Generated by fedora-review 0.5.0 (6defee6) last change: 2013-10-04 Command line :./try-fedora-review -b 1053640 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Python, Shell-api, C/C++ Disabled plugins: Java, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
> > Issues: > ======= > - If (and only if) the source package includes the text of the license(s) in > its own file, then that file, containing the text of the license(s) for the > package is included in %doc. > Note: Cannot find COPYING in rpm(s) > Why is LICENSE.txt is removed? > See: > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text > I remove those files because they are installed in the library directory, /usr/lib64/python2.7/site-packages/statsmodels and are redundant with the LICENSE.txt in %doc statsmodels/LICENSE.txt seems to be an older version of LICENSE.txt Anyway, I have copied it and it is in %doc with LICENSE.txt renamed as LICENSE.statsmodels.txt I will ask upstream to remove/update this file > - License file installed when any subpackage combination is installed. > Part of problem is that LICENSE.txt et. al. are removed. Another is that > the subpackages does not require the base package and thus can be installed > without license info. Either require the base package or (IMHO better) > duplicate the license files in the subpackages. The LICENSE.txt files are duplicated in %doc for pythons-statsmodels and python-statsmodels-doc > > - Package consistently uses macros (instead of hard-coded directory names). > Personally, I don't see the need for the upname macro. It just makes things > harder to read. upname is upstream name. As the python guidelines requires to preappend python- python3- to the package name (which is usually the same as the upstream name), upname is very handy > Also, since the python3 stuff isn't functional I think > it's better to remove for now, re-introducing it once it works. No > blockers. > I'm testing python3 packages of the missing dependencies. > - Add a -a option to the cp command in %build to preserve timestamps. Done > > - The find command has a '-delete' option which is somewhat cleaner. > No blocker. > Updated, thanks New SRPM and spec with the fixes mentioned above Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-statsmodels.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-statsmodels-0.5.0-5.fc20.src.rpm
Hm.. basically, this looks fine. But: we still need to add ./statsmodels/datasets/COPYING to %doc, don't we?
Yes, I have added COPYING and README,txt in datasets as README.datasets.txt and COPYING.datasets in %doc Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-statsmodels.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-statsmodels-0.5.0-6.fc20.src.rpm
All looks good *** Approved
Thanks for the review!
New Package SCM Request ======================= Package Name: python-statsmodels Short Description: Statistics in Python Owners: sergiopr Branches: f20 InitialCC:
Git done (by process-git-requests).