Bug 1053670
| Summary: | "compress" option name for over-wire-compression is extremely misleading and should be changed | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Justin Clift <jclift> |
| Component: | cli | Assignee: | Niels de Vos <ndevos> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | pre-release | CC: | gluster-bugs, kwade, ndevos, ppai |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.5.0 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-04-17 11:52:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 923540, 1049981 | ||
This is the BZ for the new over-the-wire compression code: https://bugzilla.redhat.com/show_bug.cgi?id=923540 s/encryption/compression/ Obviously needed more coffee when typing this. :/ Two more suggestions: * sending_compression * over_the_wire_compression <-- completely clear Discussed in todays meeting, network.compression has at least some acceptance. "network.compression" sounds good. :) +1 for "network.compression" REVIEW: http://review.gluster.org/6765 (features/compress: rename "compress" option to "network.compression") posted (#1) for review on master by Niels de Vos (ndevos) Posted for the master branch, waiting for more comments and inclusion before backporting to release-3.5. REVIEW: http://review.gluster.org/6765 (features/compress: rename "compress" option to "network.compression") posted (#2) for review on master by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/6765 committed in master by Vijay Bellur (vbellur) ------ commit 460ed4184801d5346c58cc32a34704910345a184 Author: Niels de Vos <ndevos> Date: Thu Jan 23 12:12:07 2014 +0100 features/compress: rename "compress" option to "network.compression" Prevent mistaking the "compress" options for storage (at rest) compression. The cdc-xlator is implemented to support compressing of network traffic (READ and WRITE FOPs). URL: http://www.gluster.org/community/documentation/index.php/Features/On-Wire_Compression_+_Decompression Change-Id: I9fedf4106dcb226d135ab92e4b533aff284881d7 BUG: 1053670 CC: Venky Shankar <vshankar> CC: Prashanth Pai <ppai> Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/6765 Reviewed-by: Prashanth Pai <ppai> Reviewed-by: Kaleb KEITHLEY <kkeithle> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6773 (features/compress: rename "compress" option to "network.compression") posted (#1) for review on release-3.5 by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/6773 committed in release-3.5 by Vijay Bellur (vbellur) ------ commit 3744b1dfe3baedfd2f210edd7680454a5e32296f Author: Niels de Vos <ndevos> Date: Fri Jan 24 10:38:16 2014 +0100 features/compress: rename "compress" option to "network.compression" Prevent mistaking the "compress" options for storage (at rest) compression. The cdc-xlator is implemented to support compressing of network traffic (READ and WRITE FOPs). URL: http://www.gluster.org/community/documentation/index.php/Features/On-Wire_Compression_+_Decompression Master-Change-Id: I9fedf4106dcb226d135ab92e4b533aff284881d7 Master-Reviewed-on: http://review.gluster.org/6765 Change-Id: Ib882af855b36df93fac46236c349c33dd4c3ced4 BUG: 1053670 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/6773 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Prashanth Pai <ppai> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report. glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |
Description of problem: Gluster 3.5 will include a useful new "over-the-wire" encryption ability, that can be set at volume level. The option name used to set it is unfortunately extremely misleading, and should be changed before 3.5 is released. At present, the option is set using: # gluster volume set <vol_name> compress on "compress" here is misleading, as it sounds like it's enabling _volume level disk compression_. Better naming is needed, to indicate it's over-the-wire compression only. Possible suggestions: * transfer_compression * wire_compression * client_server_compression * [we can ask on gluster-devel too] Really, almost anything other then just "compress" or "compression" by itself. :) Additional info: http://www.gluster.org/community/documentation/index.php/Features/On-Wire_Compression_%2B_Decompression