Bug 1054697

+++ This bug was initially created as a clone of Bug #1017536 +++

Description of problem:
Create scalable app with empty git repo will return the following warning message twice.

"An empty Git repository has been created for your application.  Use 'git push' to add your code."

Version-Release number of selected component (if applicable):
devenv-stage_491

How reproducible:
always

Steps to Reproduce:
1.Create scalable app with empty git repo
# rhc create-app foo php-5 -s --from-code="empty"


Actual results:
The warning message will show twice.
# rhc create-app foo php-5.3 -s --from-code="empty"

Application Options
-------------------
  Domain:      bmengdev
  Cartridges:  php-5.3
  Source Code: empty
  Gear Size:   default
  Scaling:     yes

Creating application 'foo' ... 
An empty Git repository has been created for your application.  Use 'git push' to add your code.An empty Git repository has been created for your application.  Use 'git push' to add your code.
done


Expected results:
Should not show the duplicate messages.

Additional info:
There is no such issue for non-scalable app.

--- Additional comment from Jakub Hadvig on 2013-11-04 11:54:02 EST ---

Fixed the bug by moving the massage after the app creation.
Had to modify rhc and also origin-server.

part 1 - https://github.com/openshift/origin-server/pull/4077
part 2 - https://github.com/openshift/rhc/pull/499

--- Additional comment from Chris Ryan on 2013-12-09 10:22:45 EST ---

I'm experiencing this behavior on the latest devenv_4111 (ami-aba18cc2):

rhc app create app1 php-5.3 --from-code empty -s -l cryan -p 'redhat' --insecure --server ec2-54-224-225-5.compute-1.amazonaws.com
      Application Options
      -------------------
        Domain:      w11dic
        Cartridges:  php-5.3
        Source Code: empty
        Gear Size:   default
        Scaling:     yes
      
      Creating application 'app1' ... An empty Git repository has been created for your application.  Use 'git push' to add your code.An empty Git repository has been created for your application.  Use 'git push' to add your code.

--- Additional comment from openshift-github-bot on 2013-12-10 09:21:31 EST ---

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/fe05c3bdd3f968d965311b56c29e6520df51cb4a
Bug 1017536 - Duplication warning messages when creating scalable app with empty git repo

--- Additional comment from Jakub Hadvig on 2013-12-10 10:03:51 EST ---

Fixed and merged

PR: https://github.com/openshift/origin-server/commit/fe05c3bdd3f968d965311b56c29e6520df51cb4a

--- Additional comment from Liang Xia on 2013-12-11 02:16:58 EST ---

Verified on devenv_4120.

# rhc create-app foo php-5 -s --from-code="empty" --no-git --no-dns
Using php-5.3 (PHP 5.3) for 'php-5'

Application Options
-------------------
Domain:      lxia
Cartridges:  php-5.3
Source Code: empty
Gear Size:   default
Scaling:     yes

Creating application 'foo' ... An empty Git repository has been created for your application.  Use 'git push' to add your code.
done


Your application 'foo' is now available.

  URL:        http://foo-lxia.dev.rhcloud.com/
  SSH to:     52a81000351e49cff10001a1.rhcloud.com
  Git remote: ssh://52a81000351e49cff10001a1.rhcloud.com/~/git/foo.git/

Run 'rhc show-app foo' for more details about your app.