Bug 1054831 - Review Request: perl-Lucy - Search engine library
Summary: Review Request: perl-Lucy - Search engine library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Filip Andres
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-17 14:53 UTC by Lubomir Rintel
Modified: 2014-01-23 16:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-23 16:05:26 UTC
Type: Bug
Embargoed:
filip: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
Changes to KinoSearch (10.41 KB, text/plain)
2014-01-17 14:54 UTC, Lubomir Rintel
no flags Details

Description Lubomir Rintel 2014-01-17 14:53:26 UTC
SPEC: http://v3.sk/~lkundrak/SPECS/perl-Lucy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Lucy-0.3.3-1.el7.src.rpm

Description

Lucy is a loose port of the Java search engine library Apache Lucene,
written in Perl and C. The archetypal application is website search, but it
can be put to many different uses.

Comment 1 Lubomir Rintel 2014-01-17 14:54:41 UTC
Created attachment 851650 [details]
Changes to KinoSearch

FWIW this is just a modification of KinoSearch

Comment 2 Filip Andres 2014-01-23 11:39:15 UTC
* license OK
* rpmbuild (epel6, x86_64) OK
* rpmlint (rather) OK:
perl-Lucy.x86_64: W: spelling-error %description -l en_US Lucene -> Luce, Lucien, Lucite
perl-Lucy.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/auto/Lucy/Lucy.bs
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

APPROVED

Comment 3 Lubomir Rintel 2014-01-23 13:27:38 UTC
Thank you!

New Package SCM Request
=======================
Package Name: perl-Lucy
Short Description: Search engine library
Owners: lkundrak jplesnik ppisar
Branches: f19 f20 el6 epel7
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2014-01-23 14:14:33 UTC
Git done (by process-git-requests).

Comment 5 Petr Pisar 2014-01-23 15:44:00 UTC
(In reply to Lubomir Rintel from comment #3)
> Thank you!
> 
> New Package SCM Request
> =======================
> Package Name: perl-Lucy
> Short Description: Search engine library
> Owners: lkundrak jplesnik ppisar
> Branches: f19 f20 el6 epel7
> InitialCC: perl-sig

Could you please stop adding random people to your packages?

Comment 6 Lubomir Rintel 2014-01-23 15:45:53 UTC
(In reply to Petr Pisar from comment #5)
> (In reply to Lubomir Rintel from comment #3)
> > Thank you!
> > 
> > New Package SCM Request
> > =======================
> > Package Name: perl-Lucy
> > Short Description: Search engine library
> > Owners: lkundrak jplesnik ppisar
> > Branches: f19 f20 el6 epel7
> > InitialCC: perl-sig
> 
> Could you please stop adding random people to your packages?

No.

Comment 8 Lubomir Rintel 2014-01-23 16:05:26 UTC
Just a small clarification: the "random people" were the maintainers of the perl-KinoSearch package, which is the old name of this. I assumed (and rightly so I believe), that it's appropriate that people who already deal with the code base are granted permissions they have in the original package. (I've mostly seen them do bulk rebuilds of Perl packages.)

Unfortunately, the granularity of what can be specified in an SCM admin request does not reflect what can be done in pkgdb.

If anyone feels that he has an extra permission set in pkgdb he can adjust it according to their needs; some already did. They are notified by mail when they are granted permissions in pkgdb, therefore it does not happen without their knowledge.

Thanks for your understanding!

Tha package was imported and built -- thanks for the review and SCM!

Comment 9 Marcela Mašláňová 2014-01-23 16:09:26 UTC
Funny, I'm maintainer of perl-KinoSearch even if I gave up of all my Fedora packages. I also replied to your email, when I said I'm not interested in EPEL maintenance.
I'll run script to remove me from all EPEL branches.

Comment 10 Lubomir Rintel 2014-01-23 16:35:29 UTC
(In reply to Marcela Mašláňová from comment #9)
> Funny, I'm maintainer of perl-KinoSearch even if I gave up of all my Fedora
> packages. I also replied to your email, when I said I'm not interested in
> EPEL maintenance.
> I'll run script to remove me from all EPEL branches.

Sorry for the hassle. This is exactly the case described above; it's not possible to selectively enable permissions for specific branches via SCM admin requests. I figured that an extra permissions which is easily given up is a better idea than to omit someone with interest.

It might be a good idea to add yourself here -- this is useful when people determine who to ask for maintenance of EPEL branches:
http://fedoraproject.org/wiki/EPEL/ContributorStatusNo

That said, it might be that you got an extra mail or two, despite you explicitly expressed non-interest in EPEL. We rely quite heavily on significant portion of Perl stack being in EPEL and I used to ask packagers about the branching by mailing <package>-owner until I learned it's a really bad idea. Sorry for that.


Note You need to log in before you can comment on or make changes to this bug.