Bug 1054843 - Response Time Units scale
Summary: Response Time Units scale
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Monitoring - CallTime
Version: JON 3.2
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: DR01
: JON 3.2.1
Assignee: Jirka Kremser
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-17 15:14 UTC by dsteigne
Modified: 2018-12-04 17:01 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-05-08 17:44:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description dsteigne 2014-01-17 15:14:55 UTC
Description of problem:
there is a cosmetic bug on response time metrics under monitor/calltime tab.
When one of the columns listed (ex.: Total Time) changes its units (ex. milliseconds to seconds, or seconds to minuts) every column changes in the same way.
So if in a "Call Destination" row the Total Time is listed in minutes also the Minimum column is listed in minutes even if the value is in ms.
In this case is useless because I often see  Minimum response time value of 0 minutes because the real value is for example 30 milliseconds.

Version-Release number of selected component (if applicable):

3.2
How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Jirka Kremser 2014-02-13 13:07:18 UTC
branch:  master
link:    http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=0bc1dff6f
time:    2014-02-13 14:05:44 +0100
commit:  0bc1dff6fcbf00467185ce3b66edbf45c822f7b8
author:  Jirka Kremser - jkremser
message: [BZ 1054843] - Response Time Units scale - Formatting the 'total' field
         independently (it was passed together with min/max/avg to
         MeasurementConverterClient.formatToSignificantPrecision() that
         causes these disproportions in values).

Comment 2 Lukas Krejci 2014-02-13 14:01:17 UTC
commit dc57f62e9637f1d98e702c1fa51ba9b675016e3c
Author: Jirka Kremser <jkremser>
Date:   Thu Feb 13 14:05:29 2014 +0100

    [BZ 1054843] - Response Time Units scale - Formatting the 'total' field independently (it was passed together with min/max/avg to MeasurementConverterClient.formatToSignificantPrecision
    
    (cherry picked from commit 0bc1dff6fcbf00467185ce3b66edbf45c822f7b8)
    Signed-off-by: Lukas Krejci <lkrejci>

Comment 3 Simeon Pinder 2014-02-18 15:08:39 UTC
Moving to ON_QA as available for testing in the following brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=336752

Note: the installed version is still JON 3.2.0.GA by design and this represents part of the payload for JON 3.2.1 also known as cumulative patch 1 for 3.2.0.GA.  How this will be delivered to customers is still being discussed.

Comment 4 Jan Bednarik 2014-02-20 12:07:40 UTC
Moving to ASSIGNED as the fix only works for the field "Total Time" but if the unit changes in another field (e.g. "Maximum") the rest of the fields change their units along with it. Please fix this issue for all fields.

Comment 5 Jirka Kremser 2014-02-24 13:40:23 UTC
It works the same way as all the metric tables in JON. Aggregates (min, max, avg) should be close enough provided the st. deviation (or more precisely range) of the metric is relatively low. (Should be the case for all non trending metrics.)

This should be, however, consistent with the rest of the application. Don't get me wrong, I am not saying it is good as it is, I just say it should be consistent. So either leave it as it is, or change it everywhere (also for the monitoring tables http://${host}:7080/coregui/#Resource/${res_id}/Monitoring/Metrics in web UI). If the second is the case, you can raise a bug for it and once it is triaged and prioritized, I could fix that also for the rest of the UI.

For this bug I've added the own formatting _only_ for the 'Total Time' on purpose, because the column is different as the others. It has the cumulative nature and its value is >> than min/max/avg

Comment 6 Jan Bednarik 2014-02-25 12:34:43 UTC
After consulting this issue with Jiri I am moving this BZ to VERIFIED.

The result is that this behaviour is desirable as it is easier for the user to compare the values between different columns if they are displayed with the same unit. The only exception would be the column "Total time" (as it has the cumulative nature and therefore can reach significantly higher values) for which the behaviour was correctly fixed.

Verified on JON 3.2.1 DR1 (Build Number : c758688:4c03150)

Comment 7 Mike Foley 2014-05-08 17:44:16 UTC
JON 3.2.1 released week of 5/5/2014


Note You need to log in before you can comment on or make changes to this bug.