Spec URL: http://jjames.fedorapeople.org/trinity/trinity.spec SRPM URL: http://jjames.fedorapeople.org/trinity/trinity-1.3-1.fc21.src.rpm Fedora Account System Username: jjames Description: Trinity makes syscalls at random, with random arguments. Where Trinity differs from other fuzz testers is that the arguments it passes are not purely random. We found some bugs in the past by just passing random values, but once the really dumb bugs were found, these dumb fuzzers would just run and run. The problem was if a syscall took for example a file descriptor as an argument, one of the first things it would try to do was validate that fd. Being garbage, the kernel would just reject it as -EINVAL of course. So on startup, Trinity creates a list of file descriptors, by opening pipes, scanning sysfs, procfs, /dev, and creates a bunch of sockets using random network protocols. Then when a syscall needs an fd, it gets passed one of these at random. File descriptors aren't the only thing Trinity knows about. Every syscall has its arguments annotated, and where possible it tries to provide something at least semi-sensible. "Length" arguments for example get passed one of a whole bunch of potentially interesting values. (Powers of 2 +/-1 are a good choice for triggering off-by-one bugs it seems). Trinity also shares those file descriptors between multiple threads, which causes havoc sometimes. If a child process successfully creates an mmap, the pointer is stored, and fed to subsequent syscalls, sometimes with hilarious results.
package is approved, even if I was surprised to have it run without needing any option Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL", "Unknown or generated". 537 files have unknown license. Detailed output of licensecheck in /home/misc/checkout/git/FedoraReview/1055771-trinity/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://codemonkey.org.uk/projects/trinity/trinity-1.3.tar.xz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: trinity-1.3-1.fc20.x86_64.rpm trinity-1.3-1.fc20.src.rpm trinity.x86_64: W: spelling-error %description -l en_US syscalls -> miscalls trinity.x86_64: W: spelling-error %description -l en_US fuzzers -> fuzzes, buzzers, Fuzzbuster trinity.x86_64: W: spelling-error %description -l en_US syscall -> scallop trinity.x86_64: W: spelling-error %description -l en_US fd -> FD, dd, ff trinity.x86_64: W: spelling-error %description -l en_US startup -> start up, start-up, upstart trinity.x86_64: W: spelling-error %description -l en_US sysfs -> sysops trinity.x86_64: W: spelling-error %description -l en_US procfs -> profs, proofs, process trinity.x86_64: W: spelling-error %description -l en_US dev -> deb, derv, div trinity.x86_64: W: spelling-error %description -l en_US mmap -> map, m map, mamma trinity.x86_64: W: no-manual-page-for-binary trinity trinity.src: W: spelling-error %description -l en_US syscalls -> miscalls trinity.src: W: spelling-error %description -l en_US fuzzers -> fuzzes, buzzers, Fuzzbuster trinity.src: W: spelling-error %description -l en_US syscall -> scallop trinity.src: W: spelling-error %description -l en_US fd -> FD, dd, ff trinity.src: W: spelling-error %description -l en_US startup -> start up, start-up, upstart trinity.src: W: spelling-error %description -l en_US sysfs -> sysops trinity.src: W: spelling-error %description -l en_US procfs -> profs, proofs, process trinity.src: W: spelling-error %description -l en_US dev -> deb, derv, div trinity.src: W: spelling-error %description -l en_US mmap -> map, m map, mamma trinity.src:42: W: configure-without-libdir-spec 2 packages and 0 specfiles checked; 0 errors, 20 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint trinity trinity.x86_64: W: spelling-error %description -l en_US syscalls -> miscalls trinity.x86_64: W: spelling-error %description -l en_US fuzzers -> fuzzes, buzzers, Fuzzbuster trinity.x86_64: W: spelling-error %description -l en_US syscall -> scallop trinity.x86_64: W: spelling-error %description -l en_US fd -> FD, dd, ff trinity.x86_64: W: spelling-error %description -l en_US startup -> start up, start-up, upstart trinity.x86_64: W: spelling-error %description -l en_US sysfs -> sysops trinity.x86_64: W: spelling-error %description -l en_US procfs -> profs, proofs, process trinity.x86_64: W: spelling-error %description -l en_US dev -> deb, derv, div trinity.x86_64: W: spelling-error %description -l en_US mmap -> map, m map, mamma trinity.x86_64: W: no-manual-page-for-binary trinity 1 packages and 0 specfiles checked; 0 errors, 10 warnings. # echo 'rpmlint-done:' Requires -------- trinity (rpmlib, GLIBC filtered): /bin/bash /bin/sh libc.so.6()(64bit) rtld(GNU_HASH) Provides -------- trinity: trinity trinity(x86-64) Generated by fedora-review 0.4.0 (cf29f98) last change: 2013-02-08 Command line :./try-fedora-review -b 1055771 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thank you for the review, Michael! New Package SCM Request ======================= Package Name: trinity Short Description: System call fuzz tester Owners: jjames Branches: f20 InitialCC:
Git done (by process-git-requests).
trinity-1.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/trinity-1.3-1.fc20
trinity-1.3-1.fc20 has been pushed to the Fedora 20 testing repository.
trinity-1.3-1.fc20 has been pushed to the Fedora 20 stable repository.