Bug 1055836 - libgit2-0.20 is available
Summary: libgit2-0.20 is available
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libgit2
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Veeti Paananen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 994859 1023724
TreeView+ depends on / blocked
 
Reported: 2014-01-21 03:42 UTC by Ankur Sinha (FranciscoD)
Modified: 2014-03-27 04:41 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-03-27 04:41:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ankur Sinha (FranciscoD) 2014-01-21 03:42:47 UTC
A new upstream version is available:

https://github.com/libgit2/libgit2/releases 

I see a failed build in koji. I'll see if I can fix it.

Thanks,
Ankur

Comment 1 Christopher Meng 2014-01-21 03:47:32 UTC
We need to merge the changes from libxdiff spot(TC@RH) upstream, then libgit2 can be built correctly.

Comment 2 Ankur Sinha (FranciscoD) 2014-01-21 03:49:59 UTC
(In reply to Christopher Meng from comment #1)
> We need to merge the changes from libxdiff spot(TC@RH) upstream, then
> libgit2 can be built correctly.

Ah. Yikes. Any links or upstream tickets where we can track this?

Comment 3 Christopher Meng 2014-01-21 04:06:17 UTC
You can check some fragments at: https://github.com/libgit2/libgit2/issues/1658

Comment 4 Ankur Sinha (FranciscoD) 2014-01-21 04:50:59 UTC
Thanks Christopher,

The current build error is because of this:

/builddir/build/BUILD/libgit2-0.20.0/src/blame_git.c: In function 'diff_hunks':
/builddir/build/BUILD/libgit2-0.20.0/src/blame_git.c:351:7: error: 'xdemitconf_t' has no member named 'emit_func'
  xecfg.emit_func = (void(*)(void))my_emit;
       ^
make[2]: *** [CMakeFiles/libgit2_clar.dir/src/blame_git.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....


Spot's version of xdiff indeed does not have emit_func.

Either his xdiff will have to be patched to include it, or libgit2 will have to be patched not to use it. The latter will be preferred and is what spot is trying to get upstream to do. (unless spot missed out the function by mistake when merging the two xdiff versions , which is highly unlikely). 

Thanks,
Warm regards,
Ankur

Comment 5 Mathieu Bridon 2014-03-27 04:41:15 UTC
libgit2 0.20 was built into Rawhide.

http://koji.fedoraproject.org/koji/buildinfo?buildID=506869

Closing.


Note You need to log in before you can comment on or make changes to this bug.