Bug 1056212

Created attachment 853403 [details]
screenshot

I suggest that requiring pyhunspell by default is a good idea.

(In reply to Martin Holec from comment #0)
> Actual results: 
> PackageKit window pop-up with following description: "python requires
> additional software". There should be some meaningful description e.g.:
> "ibus-typing-booster requires additional software" or something like that.

Apart from that it says “python requires ...” instead of
“ibus-typing-booster requires ...” the dialog is quite understandable,
I think. The package name hunspell-cz is also shown clearly in the dialog.

This is the code ibus-typing-booster uses to install a package:

https://git.fedorahosted.org/cgit/ibus-typing-booster.git/tree/ibus-typing-booster/setup/pkginstall.py

I have no idea how I can influence the text shown by this dialog.

> Expected results:
>   * Dialog providing installation of Czech dictionary should pop-up.

It does, doesn’t it?

>   * You can install Czech dictionary using PackageKit.

And that works.

>   * You should get Czech word suggestions during typing.

Works for me as well. I can install the Czech dictionary that
way and see Czech suggestions after doing that.

The setup tool for ibus-typing-booster has 2 buttons to install
stuff, one for the dictionary and one for pyhunspell, the interface
to the spell checker.

Both the dictionary and the spell checker interface are optional.

ibus-typing-booster also learns from user input and this actually
produces much better suggestions than the dictionary because it uses
the last 2 words as context (in applications supporting surrounding
text like most gnome-applications except gnome-terminal it gets the
last 2 words by fetching the surrounding text from the application, in
applications not supporting surrounding text it uses the last two
words remembered from typing). If the user has typed these last two
words before, he will get a much better suggestion than by just using
a dictionary.

If there are very many suggestions, it is not so useful for speeding
up typing. If no context is available and only a dictionary, one will
get so many suggestions after typing a single letter that it is almost
useless.  Selecting amoung dozends or even hundreds of suggestions is
often slower than just finishing to type the word. If context is
available and user input for the previous 2 words can be found in the
user database because the user has typed it before or has used the
feature to let ibus-typing-booster learn from a user supplied text
file, then the predictions are far better. The desired word is very
often the first match on top of the candidate list in that case.

So using the feature in the setup tool to let ibus-typing-booster
learn from a user supplied text file is much more helpful than the dictionary.

Using the dictionary is basically only a last ditch fallback if no
user input is available.

If only the dictionary is installed but not pyhunspell, one will get
only exact suggestions from the dictionary.

If pyhunspell is installed as well, one will also get spell checking
corrections if the word entered so far has typing errors.

Requiring hunspell-cs from the rpm is not possible because the rpm is the same for all languages and it should not require all hunspell-*.

(In future I plan to reduce the number of engines a lot and make it
more multilingual, i.e. support many languages with a single engine
so it is not a good idea to split the package into many subpackes for
each language now).

To summarize, both pyhunspell and hunspell-cs are really optional and only
marginally useful compared to good user data.

I’ll add “pyhunspell” to the rpm requires now because that is the same
for all languages and does not force a split of the package and it
saves at least one (optional) installation step for the user.
“pyhunspell” is very small so it should not hurt much to require it.

(In reply to Mike FABIAN from comment #3)

> To summarize, both pyhunspell and hunspell-cs are really optional and only
> marginally useful compared to good user data.
> 
> I’ll add “pyhunspell” to the rpm requires now because that is the same
> for all languages and does not force a split of the package and it
> saves at least one (optional) installation step for the user.
> “pyhunspell” is very small so it should not hurt much to require it.

I cannot  add “pyhunspell” to “Requires:” in ibus-typing-booster.spec for
rhel7 because “pyhunspell” does not even exist in rhel7:

https://brewweb.devel.redhat.com/packageinfo?packageID=38235

Closing as WONTFIX then because I cannot require pyhunspell.

Please stick to bug description and ignore general expected results imported from Test Case.

Actual results: 
PackageKit window pop-up with following description: "python requires additional software". There should be some meaningful description e.g.: "ibus-typing-booster requires additional software" or something like that.

(In reply to Mike FABIAN from comment #3)
> (In reply to Martin Holec from comment #0)
> > Actual results: 
> > PackageKit window pop-up with following description: "python requires
> > additional software". There should be some meaningful description e.g.:
> > "ibus-typing-booster requires additional software" or something like that.
> 
> Apart from that it says “python requires ...” instead of
> “ibus-typing-booster requires ...” the dialog is quite understandable,
> I think. The package name hunspell-cz is also shown clearly in the dialog.
> 
> This is the code ibus-typing-booster uses to install a package:
> 
> https://git.fedorahosted.org/cgit/ibus-typing-booster.git/tree/ibus-typing-
> booster/setup/pkginstall.py
> 
> I have no idea how I can influence the text shown by this dialog.

Just ask right guy...

Discussed it with Richard.

This is not so easy. See: https://bugzilla.redhat.com/show_bug.cgi?id=1064923

Can yum or dnf be used instead of packagekit?

I thought "ibus-typing-booster install dictionary integration" is bug 1056197 ?

(In reply to Jens Petersen from comment #9)
> Can yum or dnf be used instead of packagekit?

That would make it more distribution specific, wouldn’t it?

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.

The comment above is incorrect. The correct version is bellow.
I'm sorry for any inconvenience.
---------------------------------------------------------------

This request was NOT resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you need
to escalate this bug.

Closing as WONTFIX, there is no easy way to fix this and pyhunspell is optional anyway.