Spec URL: http://echevemaster.fedorapeople.org/python-nose-parameterized/python-nose-parameterized.spec SRPM URL: http://echevemaster.fedorapeople.org/python-nose-parameterized/python-nose-parameterized-0.3.3-1.fc19.src.rpm Description: Library that improving nose test generators with a decorator that fixes the frequent requirement of a second function, the difficulty to separate the data from the tests and the impossibility of working with subclases of unittest.TestCase Fedora Account System Username: echevemaster Tested on koji http://koji.fedoraproject.org/koji/taskinfo?taskID=6438434
- requires are incorrect, as the main rpm pull python 3 package, while this should be only on the python3 subpackage. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/misc/checkout/git/FedoraReview/1056435-python-nose- parameterized/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -nose-parameterized [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-nose-parameterized-0.3.3-1.fc20.noarch.rpm python3-nose-parameterized-0.3.3-1.fc20.noarch.rpm python-nose-parameterized-0.3.3-1.fc20.src.rpm python-nose-parameterized.noarch: W: spelling-error %description -l en_US subclases -> subclass, subleases python-nose-parameterized.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python-nose-parameterized.noarch: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case python3-nose-parameterized.noarch: W: spelling-error %description -l en_US subclases -> subclass, subleases python3-nose-parameterized.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python3-nose-parameterized.noarch: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case python-nose-parameterized.src: W: spelling-error %description -l en_US subclases -> subclass, subleases python-nose-parameterized.src: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python-nose-parameterized.src: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case 3 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python3-nose-parameterized python-nose-parameterized python3-nose-parameterized.noarch: W: spelling-error %description -l en_US subclases -> subclass, subleases python3-nose-parameterized.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python3-nose-parameterized.noarch: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case python-nose-parameterized.noarch: W: spelling-error %description -l en_US subclases -> subclass, subleases python-nose-parameterized.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python-nose-parameterized.noarch: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case 2 packages and 0 specfiles checked; 0 errors, 6 warnings. # echo 'rpmlint-done:' Requires -------- python3-nose-parameterized (rpmlib, GLIBC filtered): python(abi) python-nose-parameterized (rpmlib, GLIBC filtered): python(abi) python-nose python-six python3-nose python3-six Provides -------- python3-nose-parameterized: python3-nose-parameterized python-nose-parameterized: python-nose-parameterized Source checksums ---------------- https://pypi.python.org/packages/source/n/nose-parameterized/nose-parameterized-0.3.3.tar.gz : CHECKSUM(SHA256) this package : 964ec3b2489047f62ea6696149691f27b37d3e9cedd7f552458b0e0c22209642 CHECKSUM(SHA256) upstream package : 964ec3b2489047f62ea6696149691f27b37d3e9cedd7f552458b0e0c22209642 Generated by fedora-review 0.4.0 (cf29f98) last change: 2013-02-08 Command line :./try-fedora-review -b 1056435 Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
@misc, thanks for take the review. Spec URL: http://echevemaster.fedorapeople.org/python-nose-parameterized/python-nose-parameterized.spec SRPM URL: http://echevemaster.fedorapeople.org/python-nose-parameterized/python-nose-parameterized-0.3.3-2.fc19.src.rpm [echevemaster@localhost SPECS]$ rpm -qpR ../RPMS/noarch/python-nose-parameterized-0.3.3-2.fc19.noarch.rpm python(abi) = 2.7 python-nose python-six rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 [echevemaster@localhost SPECS]$ rpm -qpR ../RPMS/noarch/python3-nose-parameterized-0.3.3-2.fc19.noarch.rpm python(abi) = 3.3 python3-nose python3-six rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1
Ok, approved
New Package SCM Request ======================= Package Name: python-nose-parameterized Short Description: Decorator for parameterized testing with Nose Owners: echevemaster Branches: f19 f20 el6 el7 InitialCC:
Git done (by process-git-requests).
python-nose-parameterized-0.3.3-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-nose-parameterized-0.3.3-2.fc20
python-nose-parameterized-0.3.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-nose-parameterized-0.3.3-2.fc19
python-nose-parameterized-0.3.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-nose-parameterized-0.3.3-2.el6
python-nose-parameterized-0.3.3-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
python-nose-parameterized-0.3.3-2.fc19 has been pushed to the Fedora 19 stable repository.
python-nose-parameterized-0.3.3-2.fc20 has been pushed to the Fedora 20 stable repository.
python-nose-parameterized-0.3.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.