Spec URL: https://raw2.github.com/remicollet/remirepo/d0c5fe8be01e475c25c86eb0130d298fc9217618/ssdeep/ssdeep.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/ssdeep-2.10-1.remi.src.rpm Description: ssdeep is a program for computing context triggered piecewise hashes (CTPH). Also called fuzzy hashes, CTPH can match inputs that have homologies. Such inputs have sequences of identical bytes in the same order, although bytes in between these sequences may be different in both content and length. Fedora Account System Username: remi Targets: Fedora and EPEL >= 5 Copr test builds in http://copr.fedoraproject.org/coprs/remi/morephp/monitor/
There is one minor issue with this package: The configure script peeks into the runtime system's file system and appends some directories to CPPFLAGS and LDFLAGS if it finds them. In a mock environment, this causes -I/usr/local/include and -L/usr/local/lib to be appended to GCC calls. There are many ways to fix and/or work-around this issue, e.g.: 1) A clean way would be to comment out the section (grep for "for spfx") in configure and configure.ac and patch these files. (apply "touch configure configure.ac -r aclocal.m4" after %patch to avoid the autotools being re-run) 2) A less clean way would be to sed out -I/usr/local/include and -L/usr/local/lib from Makefile after having run %configure. I'd go for 1)
Probably no effect, but fixing seems cleaner: https://github.com/remicollet/remirepo/commit/774638daf0861005ef7839cf754b04a8aab5549a Spec: https://raw2.github.com/remicollet/remirepo/774638daf0861005ef7839cf754b04a8aab5549a/ssdeep/ssdeep.spec Srpm: http://rpms.famillecollet.com/SRPMS/ssdeep-2.10-2.remi.src.rpm
Notice: this library is GPLv2+ but also "Perl Artistic License" (for inclusion into the PECL). http://news.php.net/php.pecl.dev/7625 I don't think this exception have to be noticed in this package but rather in the pecl/ssdeep extension one.
Taking for review
APPROVED. 2 comments: - By removing the offending lines from configure in your *build-patch, you are destroying configure's line numbering. If you'd comment them out instead, line numbers would remain intact (which is useful in case of problems). - I dislike package which install headers with fairly generic names (fuzzy.h) directly into /usr/include, but this is just my personal preference.
Thanks for the review ! (In reply to Ralf Corsepius from comment #5) > - I dislike package which install headers with fairly generic names > (fuzzy.h) directly into /usr/include, but this is just my personal > preference. Me too... but without any .pc file it will make uneasy for "consumer" to use this library... choice is not always trivial... New Package SCM Request ======================= Package Name: ssdeep Short Description: Compute context triggered piecewise hashes Owners: remi Branches: f20 el5 el6 epel7 InitialCC:
Git done (by process-git-requests).
ssdeep-2.10-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/ssdeep-2.10-2.el5
ssdeep-2.10-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ssdeep-2.10-2.fc20
ssdeep-2.10-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ssdeep-2.10-2.el6
ssdeep-2.10-2.el5 has been pushed to the Fedora EPEL 5 testing repository.
ssdeep-2.10-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
works for me - thank you. Tested even the header files with (pip install pydeep) and it is indeed what's expected by other packages. Best regards Michal Ambroz
ssdeep-2.10-2.fc20 has been pushed to the Fedora 20 stable repository.
ssdeep-2.10-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
ssdeep-2.10-2.el5 has been pushed to the Fedora EPEL 5 stable repository.