Bug 1056577 - osinfo - property inheritance doesn't cover minor version
Summary: osinfo - property inheritance doesn't cover minor version
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.6.0
Assignee: Roy Golan
QA Contact: bugs@ovirt.org
URL:
Whiteboard: virt
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-22 13:50 UTC by Roy Golan
Modified: 2016-02-10 19:47 UTC (History)
10 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-03-30 10:10:44 UTC
oVirt Team: Virt
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 25740 0 master ABANDONED core, engine: New property override behaviour in osinfo Never
oVirt gerrit 39033 0 master ABANDONED core: osinfo - use latest version of a key rather then genaral or derived Never

Description Roy Golan 2014-01-22 13:50:27 UTC
Description of problem:

the lookup algorithem for a derived value by version is naive and rely on making
the default version-less values. 
this doesn't scale when features update and have a default set in a later version

os.base.k.value = X
os.derived.k.value.3.2 = Y

os.derived.k.value.3.3 = ?   - this should be Y. instead it X

to overcome that we duplicate a property and bump the version value
os.derived.k.value.3.3 = Y

Version-Release number of selected component (if applicable):

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:

we be able to get Y for os.derived.k.value.3.3 without adding an entry

Additional info:

Comment 1 Itamar Heim 2014-01-26 08:11:54 UTC
Setting target release to current version for consideration and review. please
do not push non-RFE bugs to an undefined target release to make sure bugs are
reviewed for relevancy, fix, closure, etc.

Comment 2 Michal Skrivanek 2014-08-14 13:37:53 UTC
Roy, you need to revive and finish the patch I think

Comment 3 Michal Skrivanek 2014-10-31 08:38:55 UTC
Roy? I think it's really worth finishing this one eventually, it's a great enhancement

Comment 4 Michal Skrivanek 2014-12-01 12:36:04 UTC
nothing going on so far, pushing out of 3.5

Comment 5 Roy Golan 2015-03-30 10:10:44 UTC
the out of the box default values is good enough so there is no need for that change. 

see the merged https://gerrit.ovirt.org/#/c/39077/ or https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=829815c6a245c4ace32a248123c13fb37e8bb14e


Note You need to log in before you can comment on or make changes to this bug.