Spec URL: http://www.scrye.com/~kevin/fedora/review/libnftnl/libnftnl.spec SRPM URL: http://www.scrye.com/~kevin/fedora/review/libnftnl/libnftnl-0-0.6.20140122git.fc21.src.rpm Description: A library for low-level interaction with nftables Netlink's API over libmnl. Fedora Account System Username: kevin NOTES: * This is a rename request for the existing libnftables package. Upstream has renamed. Orig review bug: 1036319 * There is a 1.0.0 version, but it's got a few serious issues, so I am sticking to snapshots until the next release. * rpmlint says: libnftnl.armv7hl: W: spelling-error Summary(en_US) nftables -> notables, inflatables, tables libnftnl.armv7hl: W: spelling-error Summary(en_US) libmnl -> limn libnftnl.armv7hl: W: spelling-error %description -l en_US nftables -> notables, inflatables, tables libnftnl.armv7hl: W: spelling-error %description -l en_US libmnl -> limn libnftnl.i686: W: spelling-error Summary(en_US) nftables -> notables, inflatables, tables libnftnl.i686: W: spelling-error Summary(en_US) libmnl -> limn libnftnl.i686: W: spelling-error %description -l en_US nftables -> notables, inflatables, tables libnftnl.i686: W: spelling-error %description -l en_US libmnl -> limn libnftnl.src: W: spelling-error Summary(en_US) nftables -> notables, inflatables, tables libnftnl.src: W: spelling-error Summary(en_US) libmnl -> limn libnftnl.src: W: spelling-error %description -l en_US nftables -> notables, inflatables, tables libnftnl.src: W: spelling-error %description -l en_US libmnl -> limn libnftnl.x86_64: W: spelling-error Summary(en_US) nftables -> notables, inflatables, tables libnftnl.x86_64: W: spelling-error Summary(en_US) libmnl -> limn libnftnl.x86_64: W: spelling-error %description -l en_US nftables -> notables, inflatables, tables libnftnl.x86_64: W: spelling-error %description -l en_US libmnl -> limn libnftnl-devel.armv7hl: W: no-documentation libnftnl-devel.i686: W: no-documentation libnftnl-devel.x86_64: W: no-documentation 10 packages and 0 specfiles checked; 0 errors, 19 warnings. All can be ignored, IMHO. * scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6442676
Because libnftables passed review (bug #1036319) recently and there's been no significant change since then I won't put a complete list of MUST & SHOULD items here. I run the srpm & spec through fedora-review and checked the spec file and I don't see anything to point out. It also has correct Provides & Obsoletes so I consider this package APPROVED.
Obsoletes/Provides for the -devel package are missing, though, if you *really* want to be accurate.
(In reply to Michael Schwendt from comment #2) > Obsoletes/Provides for the -devel package are missing, though, if you > *really* want to be accurate. Thanks. Fixed. Updated spec: http://www.scrye.com/~kevin/fedora/review/libnftnl/libnftnl.spec New Package SCM Request ======================= Package Name: libnftnl Short Description: Library for low-level interaction with nftables Netlink's API over libmnl Owners: twoerner kevin jpopelka Branches: devel InitialCC:
Git done (by process-git-requests).
imported and built in rawhide.