Bug 1056866 - Error message should be shown when uploading unsupported Open Document Format (e.g. fodt)
Error message should be shown when uploading unsupported Open Document Format...
Status: CLOSED CURRENTRELEASE
Product: Zanata
Classification: Community
Component: Component-Logic (Show other bugs)
3.2
Unspecified Unspecified
unspecified Severity high
: ---
: 3.3
Assigned To: Damian Jansen
Zanata-QA Mailling List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-22 23:53 EST by Damian Jansen
Modified: 2014-03-20 01:47 EDT (History)
3 users (show)

See Also:
Fixed In Version: 3.3.0-SNAPSHOT (20140210-0043)
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2014-03-20 01:47:07 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Test fodt file (22.17 KB, application/xml)
2014-01-22 23:53 EST, Damian Jansen
no flags Details
Test fodp file (66.07 KB, application/xml)
2014-01-23 00:09 EST, Damian Jansen
no flags Details

  None (edit)
Description Damian Jansen 2014-01-22 23:53:59 EST
Created attachment 854183 [details]
Test fodt file

Description of problem:
Cannot upload a .fodt file, responds with
- Invalid document format for test-odt.fodt.
- Transaction failed
There seems to be no indication in the logs to what happened.

Version-Release number of selected component (if applicable):
dev

How reproducible:
Easy always

Steps to Reproduce:
1. Sign in as admin / maintainer, go to a project and project version
2. Click Source Documents, Upload Document
3. Select the attached document and click Upload

Actual results:
- Invalid document format for test-odt.fodt.
- Transaction failed

Expected results:
Upload and save

Additional info:
The same document, saved as an .odt, seems to work fine.
Comment 1 Damian Jansen 2014-01-23 00:09:58 EST
Created attachment 854189 [details]
Test fodp file

Same goes for .fodp (OpenDoc' Presentation)
Comment 2 Damian Jansen 2014-01-23 00:15:19 EST
Further testing indicates it applies to all Libreoffice .f*** (Open Document format) files.

Tested using LibreOffice 3.4.5 on RHEL6.4
Comment 3 Sean Flanigan 2014-01-23 00:22:33 EST
I haven't heard of .fodt before, so I looked it up on wikipedia:

"The OpenDocument format supports the following two ways of document representation:

"As a single XML document - also known as Flat XML or Uncompressed XML Files. Single OpenDocument XML files are not widely used. Filename extensions for a single OpenDocument XML documents are not defined in the OpenDocument technical specification, but commonly used are .xml, .fodt, .fods, ... etc."

https://en.wikipedia.org/wiki/OpenDocument_technical_specification#Document_Representation


So, we're talking about a single XML file instead of the usual "multiple XML files inside a ZIP container".

As if the (compressed) ODT files weren't taking up enough space...
Comment 4 Damian Jansen 2014-01-28 00:04:42 EST
It appears that it isn't our parsing of the documents that is wrong, but the fact we incorrectly state we support them at all.

Fix: Remove .fod* files from the list of supported filetypes in 
zanata-war/src/main/resources/messages.properties tag jsf.SupportedUploadFormats
Comment 5 Damian Jansen 2014-01-29 00:54:24 EST
https://github.com/zanata/zanata-server/pull/346
Comment 6 Ding-Yi Chen 2014-02-09 20:02:11 EST
VERIFIED with Zanata 3.3.0-SNAPSHOT (20140210-0043)
Comment 7 Sean Flanigan 2014-03-20 01:47:07 EDT
Closing VERIFIED bugs for Zanata server 3.3.2.

Note You need to log in before you can comment on or make changes to this bug.