Description of problem: Clicking on 'Feedback' opens new tab but there's no URL in address bar Version-Release number of selected component (if applicable): 100% How reproducible: ovirt-engine-3.4.0-0.5.beta1.el6.noarch Steps to Reproduce: 1. click on Feedback in top right corner 2. 3. Actual results: new tab but without any url Expected results: some page should be opened in new tab Additional info:
Created attachment 855057 [details] screen-shot: after clicking 'Feedback'
the URL is actually a "mailto:..." URL, and it is supposed to open your default e-mail client. I am not sure about it, but I assume that the application doesn't know what type of URL the 'Feedback' will lead to (the URL is brandable/configurable), so just in case - in order to not 'override' the ovirt-engine GUI with the Feedback URL content by mistake - it does the URL "redirection" in the context of a new tab. I assume that behavior of opening a new tab is different across different browsers (in my Chrome, for example, it does show the "address" in the address bar, and suggests to open Evolution, which is, apparently, my default e-mail client - see attachment 855057 [details]). I am not entirely sure what we can do about it. @Alex - any improvement suggestions that you can think of?
Well for ovirt the feedback URL is mailto:... and different browsers will behave differently. The reason the new tab is opened is because the URL can be a regular URL and we don't want clicking the link to close the webadmin. In theory we could check to see if the URL is a 'mailto' and not open a new tab but the user can configure their browser to have mail go to some web mail like gmail. At which point it will close webadmin again. Or if there is no possible email client, nothing at all will happen, making it appear that the link is broken. Maybe if the URL is a mailto link, we can open up the new tab with some static page that says, attempting to open up your email client? At least that way if the user has no configured email client (as appears to be the case with Jiri, they know we tried something). Other than that I don't know what we could do to improve the situation.
creating a page of "attempting to open your local e-mail client..." is a nice idea, however it seems to me a bit of an overkill to create an entire page just for 'mailto' Feedback URLs. I just thought of a different idea: Displaying a tool-tip when hovering on the 'Feedback' button. The tool-tip text will be brandable (just like the Feedback text/URL) and if the tool-tip text would be empty - we can display the URL itself in the tool-tip, maybe followed by "(will be opened in a new tab)". That way, the user will have a general idea what this button is about to do. @Alex - what do you think?
Setting target release to current version for consideration and review. please do not push non-RFE bugs to an undefined target release to make sure bugs are reviewed for relevancy, fix, closure, etc.
I think providing a little more feedback to the user is basically what I was suggesting with the page, but as you said probably a little bit of overkill. Providing a tooltip would be a nice addition and should be easy to accomplish.
ok, rhevm-webadmin-portal-3.5.0-0.10.master.el6ev.noarch little BZ1138660 about meaningfulness
oVirt 3.5 has been released and should include the fix for this issue.