Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1057609

Summary: engine: no warning issued to a user that the RO property will not be retained before detaching a RO disk
Product: [Retired] oVirt Reporter: Dafna Ron <dron>
Component: ovirt-engine-coreAssignee: Allon Mureinik <amureini>
Status: CLOSED WONTFIX QA Contact: bugs <bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: abaron, acanan, acathrow, amureini, gklein, iheim, yeylon
Target Milestone: ---Keywords: Reopened, Triaged
Target Release: 3.4.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-17 16:20:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
logs none

Description Dafna Ron 2014-01-24 13:09:10 UTC 
Created attachment 854970 [details]
logs

Description of problem:

if we detach and reattach a read-only disk, something in the db goes wrong and the read-only appears to be removed from the disk (although disk is sent as read-only we can still write on it https://bugzilla.redhat.com/show_bug.cgi?id=1057606) 
detach should not remove the read only from the disk. 


Version-Release number of selected component (if applicable):

ovirt-engine-backend-3.4.0-0.5.beta1.el6.noarch
[root@cougar06 ~]# rpm -qa |grep vdsm 
vdsm-4.14.1-2.el6.x86_64
vdsm-python-4.14.1-2.el6.x86_64
vdsm-cli-4.14.1-2.el6.noarch
vdsm-python-zombiereaper-4.14.1-2.el6.noarch
vdsm-xmlrpc-4.14.1-2.el6.noarch


How reproducible:

100%

Steps to Reproduce:
1. create a vm with read only disk 
2. detach the disk from the vm 
3. re-attach the disk (it appears as r/w in webadmin)
4. run the vm (vm is run with read only in ovf)
5. install os on it

Actual results:

detaching the disk seem to remove read-only from the disk 

Expected results:

detach should not remove the read-only

Additional info:
Comment 1 Allon Mureinik 2014-01-24 16:22:03 UTC 
"Read Only" is not a property of the disk - it's a property of how the disk is plugged to the VM.

If you detach it (as opposed to unplugging), you lose the relationship with the VM. When you attach it, you re-create this relationship.
This is the expected behavior, closing.
Comment 2 Dafna Ron 2014-01-24 16:31:28 UTC 
in that case, I am reopening but changing the headline 
If the property is not retained when we detach the disk, a warning should be issued to the user.
Comment 3 Itamar Heim 2014-01-26 08:11:42 UTC 
Setting target release to current version for consideration and review. please
do not push non-RFE bugs to an undefined target release to make sure bugs are
reviewed for relevancy, fix, closure, etc.
Comment 4 Ayal Baron 2014-02-17 16:20:57 UTC 
Read only is a VM to Disk relationship property, not a disk property.  Everything that is relevant to this relationship is lost once you sever the relationship.  We will not warn for each and every such property.