SPEC: http://pbrobinson.fedorapeople.org/libusbg.spec SRPM: http://pbrobinson.fedorapeople.org/libusbg-0.1.0-1.fc20.src.rpm Description: libusbg is a C library encapsulating the kernel USB gadget-configfs userspace API functionality. It provides routines for creating and parsing USB gadget devices using the configfs API. Currently, all USB gadget configfs functions that can be enabled in kernel release 3.11 (Linux for Workgroups!) are supported. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6453042
1. Remove Requires: pkgconfig(RPM will add it for you) 2. graphviz? configure: WARNING: dot not found - will not generate graphics for doxygen documentation 3. Tex helps? checking for x86_64-redhat-linux-gnu-latex... no checking for latex... no configure: WARNING: latex not found - will not generate doxygen PostScript documentation checking for pdflatex... no configure: WARNING: pdflatex not found - will not generate doxygen PDF documentation
We don't need nor want pdf or PS based documentation
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "GPL (v2 or later)". Detailed output of licensecheck: GPL (v2 or later) ----------------- libusbg-0.1.0/examples/gadget-acm-ecm.c libusbg-0.1.0/examples/show-gadgets.c LGPL (v2.1 or later) -------------------- libusbg-0.1.0/include/usbg/usbg.h libusbg-0.1.0/src/usbg.c [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: libusbg-0.1.0-1.fc21.i686.rpm libusbg-utils-0.1.0-1.fc21.i686.rpm libusbg-devel-0.1.0-1.fc21.i686.rpm libusbg-0.1.0-1.fc21.src.rpm libusbg.i686: W: spelling-error Summary(en_US) configfs -> configure libusbg.i686: W: spelling-error Summary(en_US) userspace -> user space, user-space, users pace libusbg.i686: W: spelling-error %description -l en_US configfs -> configure libusbg.i686: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace libusbg-utils.i686: W: no-manual-page-for-binary gadget-acm-ecm libusbg-utils.i686: W: no-manual-page-for-binary show-gadgets libusbg-devel.i686: W: no-documentation libusbg.src: W: spelling-error Summary(en_US) configfs -> configure libusbg.src: W: spelling-error Summary(en_US) userspace -> user space, user-space, users pace libusbg.src: W: spelling-error %description -l en_US configfs -> configure libusbg.src: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace 4 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint libusbg-devel libusbg-utils libusbg libusbg-devel.i686: W: no-documentation libusbg-utils.i686: W: no-manual-page-for-binary gadget-acm-ecm libusbg-utils.i686: W: no-manual-page-for-binary show-gadgets libusbg.i686: W: spelling-error Summary(en_US) configfs -> configure libusbg.i686: W: spelling-error Summary(en_US) userspace -> user space, user-space, users pace libusbg.i686: W: spelling-error %description -l en_US configfs -> configure libusbg.i686: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace 3 packages and 0 specfiles checked; 0 errors, 7 warnings. # echo 'rpmlint-done:' Requires -------- libusbg-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libusbg(x86-32) libusbg.so.0 pkgconfig libusbg-utils (rpmlib, GLIBC filtered): libc.so.6 libusbg(x86-32) libusbg.so.0 rtld(GNU_HASH) libusbg (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6 rtld(GNU_HASH) Provides -------- libusbg-devel: libusbg-devel libusbg-devel(x86-32) pkgconfig(libusbg) libusbg-utils: libusbg-utils libusbg-utils(x86-32) libusbg: libusbg libusbg(x86-32) libusbg.so.0 Source checksums ---------------- https://github.com/libusbg/libusbg/archive/v0.1.0.tar.gz : CHECKSUM(SHA256) this package : 82fa5c71741a70477148ed455c307611075a4f9af6886ab3e7a4471377dfd2c7 CHECKSUM(SHA256) upstream package : 82fa5c71741a70477148ed455c307611075a4f9af6886ab3e7a4471377dfd2c7 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -rvn libusbg-0.1.0-1.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ---------------------------- 1. In -devel, remove: Requires: pkgconfig 2. In -utils, remove: Requires: %{name}%{?_isa} = %{version}-%{release} As RPM will find the deps correctly: libusbg.so.0 I'd like to see your new spec, then I will approve. Thanks.
ping
> 1. In -devel, remove: > > Requires: pkgconfig OK > 2. In -utils, remove: > > Requires: %{name}%{?_isa} = %{version}-%{release} > > As RPM will find the deps correctly: What about for multilib? > I'd like to see your new spec, then I will approve. Why? They are minor bits that can easily fixed before commit
> 2. In -utils, remove: > > Requires: %{name}%{?_isa} = %{version}-%{release} No. Notice: https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package In case it's not clear, that one is not specific to -devel subpackages. The full story is somewhat more complicated and has been discussed on various mailing-lists over the past years.
(In reply to Michael Schwendt from comment #6) > > 2. In -utils, remove: > > > > Requires: %{name}%{?_isa} = %{version}-%{release} > > No. > > Notice: > https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > > In case it's not clear, that one is not specific to -devel subpackages. > > The full story is somewhat more complicated and has been discussed on > various mailing-lists over the past years. Hmm... I just read again and think that preserving it is right. PACKAGE APPROVED.
Thanks for the review New Package GIT Request ======================= Package Name: libusbg Short Description: Library for USB gadget-configfs userspace functionality Owners: Branches: F-19 F-20 InitialCC:
No FAS account provided.
New Package GIT Request ======================= Package Name: libusbg Short Description: Library for USB gadget-configfs userspace functionality Owners: pbrobinson Branches: F-19 F-20 InitialCC:
Git done (by process-git-requests).