Hide Forgot
Spec URL: https://raw.github.com/siwinski/rpms/16b086af367c53e92f63ca8c1af01784e71081ec/php-goutte.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-goutte-1.0.3-1.20140118gite83f8f9.fc20.src.rpm Description: Goutte is a screen scraping and web crawling library for PHP. Goutte provides a nice API to crawl websites and extract data from the HTML/XML responses. Fedora Account System Username: siwinski
Created attachment 865077 [details] phpci.log phpcompatinfo version 2.26.0.
Created attachment 865078 [details] review.txt Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1058196 Buildroot used: fedora-rawhide-x86_64
MUST [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/php/Goutte [!]: outdated documentation => CHANGELOG is obviously outdated - drop it as it have no value - request upstream to drop it or update it SHOULD [!]: Dist tag is present (not strictly required in GL). => %{?dist} [!]: Latest version is packaged. => version 1.0.5 (19 days ago) prefered than git snapshot
(In reply to Remi Collet from comment #3) > MUST > > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/php/Goutte Wow... ooops! > [!]: outdated documentation > => CHANGELOG is obviously outdated > - drop it as it have no value Dropped > - request upstream to drop it or update it https://github.com/fabpot/Goutte/issues/133 > SHOULD > > [!]: Dist tag is present (not strictly required in GL). > => %{?dist} :( How many times am I going to make that mistake? > [!]: Latest version is packaged. > => version 1.0.5 (19 days ago) prefered than git snapshot Updated to latest version 1.0.5 Update diff: https://github.com/siwinski/rpms/commit/ae10e782de32256bde6cff92d8d267482cb5f4b0 Spec URL: https://raw2.github.com/siwinski/rpms/ae10e782de32256bde6cff92d8d267482cb5f4b0/php-goutte.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-goutte-1.0.5-1.fc20.src.rpm
[x]: Package must own all directories that it creates. [x]: outdated documentation [x]: Dist tag is present (not strictly required in GL). [x]: Latest version is packaged. Not blocker. == APPROVED ==
THANKS for the review! New Package SCM Request ======================= Package Name: php-goutte Short Description: A simple PHP web scraper Owners: siwinski Branches: f19 f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
php-goutte-1.0.5-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-goutte-1.0.5-1.fc20
php-goutte-1.0.5-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-goutte-1.0.5-1.fc19
php-goutte-1.0.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-goutte-1.0.5-1.el6
php-goutte-1.0.5-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
php-goutte-1.0.5-1.fc19 has been pushed to the Fedora 19 stable repository.
php-goutte-1.0.5-1.fc20 has been pushed to the Fedora 20 stable repository.
php-goutte-1.0.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository.