Bug 105836 - kdemultimedia bad source code
kdemultimedia bad source code
Product: Red Hat Linux
Classification: Retired
Component: kdemultimedia (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ngo Than
David Lawrence
Depends On:
  Show dependency treegraph
Reported: 2003-09-28 07:05 EDT by d.binderman
Modified: 2007-04-18 12:57 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2004-06-03 11:30:10 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description d.binderman 2003-09-28 07:05:00 EDT
From Bugzilla Helper:
User-Agent: Mozilla/4.6 [en-gb]C-CCK-MCD NetscapeOnline.co.uk  (Win98; I)

Description of problem:

Hello there,

I have just tried to compile package kdemultimedia-3.1-4 from Redhat 9.0
with the compiler flag -Wall. The compiler said

resample.c:1288: warning: operation on `dest' may be undefined
resample.c:1289: warning: operation on `dest' may be undefined

The source code is

  *dest++ = *(dest - 1) / 2;
  *dest++ = *(dest - 1) / 2;

Better source code would be

  *dest = *(dest - 1) / 2;
  *dest = *(dest - 1) / 2;

Also, the compiler said

cdtext.c:211: warning: `return' with no value, in function returning non-void
cdtext.c:402: warning: this function may return with or without a value

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. compile with flag -Wall.

Additional info
Comment 1 Ngo Than 2004-06-03 11:30:10 EDT
it seems to be fixed in kde 3.2.x.

Note You need to log in before you can comment on or make changes to this bug.