Spec URL: http://cicku.me/perl-WebService-Linode.spec SRPM URL: http://cicku.me/perl-WebService-Linode-0.17-1.fc21.src.rpm Description: This module implements the Linode.com api methods. Linode methods have had dots replaced with underscores to generate the perl method name. All keys and parameters have been lower cased but returned data remains otherwise the same. For additional information see http://www.linode.com/api/ . Fedora Account System Username: cicku
FIX: Missing the perl(Data::Dumper) BR, from lib/WebService/Linode/Base.pm:10 and t/01-domains.t:4 FIX: Remove the JSON and LWP::UserAgent from the explicit runtime deps. Those will be picked up automatically. TODO: Add `perl' to your BRs as it's called in the SPEC. TODO: Package `examples' in the %doc. NOTE: I think it'd be better to require perl(LWP::Protocol::https) instead of the perl(Mozilla::CA) and perl(Crypt::SSLeay) combo, however I know you're just following the upstream's recommendation. Perhaps try if the module works with LWP::Protocol::https only and suggest the switch to upstream if you feel like it? In my opinion it'd be a bit cleaner. Anyhow, this really isn't important for the review and I haven't checked whether this makes any sense either :) Just a thought. Fix the points marked as FIX and I'll approve the package.
Ignore your thought for a while ;) But I've filed an issue at upstream: Fixed: Spec URL: http://cicku.me/perl-WebService-Linode.spec SRPM URL: http://cicku.me/perl-WebService-Linode-0.18-1.fc21.src.rpm
Alright, approving.
(In reply to Petr Šabata from comment #3) > Alright, approving. Upstream changed the code based on your suggestion! Bingo! ;) New Package SCM Request ======================= Package Name: perl-WebService-Linode Short Description: Perl Interface to the Linode.com API Owners: cicku Branches: f20 el6 epel7 InitialCC: perl-sig
Git done (by process-git-requests).
*** Bug 1056336 has been marked as a duplicate of this bug. ***
Ping; have you pushed and built the package?