Bug 1058809 - Review Request: mod_intercept_form_submit - Apache module to intercept login form submission and run PAM authentication.
Summary: Review Request: mod_intercept_form_submit - Apache module to intercept login ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Cholasta
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-28 14:47 UTC by Jan Pazdziora (Red Hat)
Modified: 2014-02-22 00:51 UTC (History)
4 users (show)

Fixed In Version: mod_authnz_pam-0.8.1-1.fc20
Clone Of:
Environment:
Last Closed: 2014-02-22 00:51:15 UTC
Type: ---
Embargoed:
jcholast: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jan Pazdziora (Red Hat) 2014-01-28 14:47:36 UTC
Spec URL: http://fedorapeople.org/cgit/adelton/public_git/mod_intercept_form_submit.git/plain/mod_intercept_form_submit.spec
SRPM URL: http://copr-be.cloud.fedoraproject.org/results/adelton/identity_demo/fedora-19-x86_64/mod_intercept_form_submit-0.9.4-1.fc19/mod_intercept_form_submit-0.9.4-1.fc19.src.rpm
Description: mod_intercept_form_submit can intercept submission of application login
forms. It retrieves the login and password information from the POST
HTTP request, runs PAM authentication with those credentials, and sets
the REMOTE_USER environment variable if the authentication passes.
Fedora Account System Username: adelton

Comment 1 Jan Cholasta 2014-01-29 11:46:21 UTC
$ rpmlint mod_intercept_form_submit-0.9.4-1.fc19.src.rpm 
mod_intercept_form_submit.src: W: spelling-error Summary(en_US) login -> loin, logic, lo gin
mod_intercept_form_submit.src: W: summary-ended-with-dot C Apache module to intercept login form submission and run PAM authentication.
mod_intercept_form_submit.src: W: spelling-error %description -l en_US login -> loin, logic, lo gin
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint mod_intercept_form_submit-0.9.4-1.fc20.x86_64.rpm 
mod_intercept_form_submit.x86_64: W: spelling-error Summary(en_US) login -> loin, logic, lo gin
mod_intercept_form_submit.x86_64: W: summary-ended-with-dot C Apache module to intercept login form submission and run PAM authentication.
mod_intercept_form_submit.x86_64: W: spelling-error %description -l en_US login -> loin, logic, lo gin
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


Things to fix:

  * Summary should not end with a dot.

  * You should consider replacing the "Requires: httpd" with "Requires: httpd-mmn = %{_httpd_mmn}", see <https://fedoraproject.org/wiki/PackagingDrafts/ApacheHTTPModules>.

  * In %files section, the "%config(noreplace) %{_httpd_modconfdir}/*.conf" line should read "%config(noreplace) %{_httpd_modconfdir}/55-intercept_form_submit.conf".

  * Use one of the prescribed changelog formats, see <https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs>.

Comment 4 Jan Cholasta 2014-01-30 13:11:36 UTC
Did you delete the changelog on purpose or was it an accident?

Comment 5 Jan Pazdziora (Red Hat) 2014-01-30 13:37:02 UTC
(In reply to Jan Cholasta from comment #4)
> Did you delete the changelog on purpose or was it an accident?

Kinda on purpose. The guidelines say that you should not be describing the details of individual changes which is what the changelog did. Besides, for new package in Fedora, there really is no point having more that one line there.

Comment 6 Jan Cholasta 2014-01-30 13:56:01 UTC
OK. ACK.

Comment 7 Jan Pazdziora (Red Hat) 2014-01-30 14:44:06 UTC
New Package SCM Request
=======================
Package Name: mod_intercept_form_submit
Short Description: Apache module to intercept login form submission and run PAM authentication
Owners: adelton
Branches: f20 f21
InitialCC:

Comment 8 Gwyn Ciesla 2014-01-30 14:52:20 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2014-01-31 02:16:49 UTC
mod_authnz_pam-0.8.1-1.fc20,mod_intercept_form_submit-0.9.5-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/mod_authnz_pam-0.8.1-1.fc20,mod_intercept_form_submit-0.9.5-1.fc20

Comment 10 Fedora Update System 2014-02-01 04:04:13 UTC
Package mod_authnz_pam-0.8.1-1.fc20, mod_intercept_form_submit-0.9.5-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing mod_authnz_pam-0.8.1-1.fc20 mod_intercept_form_submit-0.9.5-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-1873/mod_authnz_pam-0.8.1-1.fc20,mod_intercept_form_submit-0.9.5-1.fc20
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2014-02-22 00:51:15 UTC
mod_authnz_pam-0.8.1-1.fc20, mod_intercept_form_submit-0.9.5-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.