Bug 1058957
| Summary: | [AAA] rhevm-config output when failing to change password is easy to miss and doesn't give any context | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Matt Reid <mreid> |
| Component: | ovirt-engine-config | Assignee: | Yair Zaslavsky <yzaslavs> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jiri Belka <jbelka> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.2.0 | CC: | aberezin, acathrow, alonbl, gklein, iheim, oourfali, Rhev-m-bugs, yeylon |
| Target Milestone: | --- | ||
| Target Release: | 3.4.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | infra | ||
| Fixed In Version: | org.ovirt.engine-root-3.4.0-14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1099562 | ||
PasswordValueHelper.validate should change - I suggest we try to perform some validations -in case of --admin-pass-file with file that does not exist (for example) we can report a more detailed error message. In case the password change is not via interactive mode or the admin-pass-file - IMHO we should still print some error description that explains that the only possible way to change the password is via admin-pass-file or interactive. Maybe it can be rephrased, and advise the user to check help for more details. This bug is referenced in ovirt-engine-3.4.0-beta3 logs. Moving to ON_QA [root@jb-rhevm34 ~]# rhevm-config -s AdminPassword=admin2 Cannot set value admin2 to key AdminPassword. It appears you tried to change a password for AdminPassword in a wrong way.You should use interactive mode or provide a file cotaining the password. Run the utility with --help for more information. There's typo - missing space between 'way.You', please correct. Thx! ok, av7. Closing as part of 3.4.0 |
Description of problem: I hit an issue with the RHEV REST API and in trying to troubleshoot it, attempted to change the password, since I wasn't sure at first if it was the same password as logging into the RHEVM Admin portal. I ran the command to try and change the password, scanned the output, and thought it had changed. When I went back to the admin portal and the /api site to try to log into both of them again, I was surprised to see the password remained unchanged. # rhevm-config -s AdminPassword=admin2 Cannot set value admin2 to key AdminPassword. ### Notes: ### 1. Passwords: password can be set in interactive mode ie: ### engine-config - AdminPassword=interactive ### or via file with one of the following options: ### engine-config -s AdminPassword --admin-pass-file=/tmp/mypass ### engine-config -s AdminPassword=/tmp/mypass ### 2. In order for your change(s) to take effect, ### restart the oVirt engine service (using: 'service ovirt-engine restart'). ############################################################################### > # | Seeing a wall of text output like that, with the failure/refusal in the middle, isn't highly recognizable, when I see that print out, I'm looking at the last few lines to see what the result was, and that's all just informational stuff. I don't see anything saying at the end that my request failed or succeeded. Running the command a few more times, eventually I did see the message in the middle, so at least I know it didn't change it. But it doesn't give me anything actionable. Why wasn't it set? Does it violate a password policy? Can I just not set it manually like that? None of the informational notes show you how to set it manually. The error could be more helpful, and more noticeable, I think. Version-Release number of selected component (if applicable): rhev 3.2 Actual results: Cannot set password, no recourse offered. Expected results: Why was it unable to set the password? What should I try next? Also, consider moving the password failure message to be the last thing output, or have a summary string saying it failed at the end, please don't expect me to go back and read through all of that information to see what's important. Additional info: