Bug 1058976 - Adjust /usr/share/spamassassin/sa-update.cron to changes in spampd
Summary: Adjust /usr/share/spamassassin/sa-update.cron to changes in spampd
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: spamassassin
Version: 20
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Warren Togami
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-28 22:14 UTC by Bojan Smojver
Modified: 2014-06-10 07:01 UTC (History)
6 users (show)

Fixed In Version: spamassassin-3.4.0-4.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-01 22:21:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Bojan Smojver 2014-01-28 22:14:38 UTC
Description of problem:
As of spampd-2.30-16.fc20, spampd has been converted to systemd and no PID file is written (it runs in foreground). So, instead of checking for existence of the PID file, spamassassin should see whether spampd is running and then reload it accordingly.

The simplest way to do this is to run:

systemctl try-restart spampd.service

Or one can do the status check and then act accordingly. See:

https://bugzilla.redhat.com/show_bug.cgi?id=678137#c5

Version-Release number of selected component (if applicable):
spamassassin-3.3.2-18.fc20.x86_64

How reproducible:
Always.

Steps to Reproduce:
1. Run spampd.

Actual results:
The spampd service will not get restarted, because there is no PID file.

Expected results:
Service restart.

Additional info:
https://bugzilla.redhat.com/show_bug.cgi?id=1038388

Comment 1 Kevin Fenzi 2014-02-02 18:02:06 UTC
ok. I have made some minor changes to hopefully fix this for now... the entire sa-update cron script needs some reworking to systemd at some point. ;( 

Anyhow, can you try this scratch build and see if there's any issues: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=6481897

Comment 2 Bojan Smojver 2014-02-03 02:51:49 UTC
(In reply to Kevin Fenzi from comment #1)
> ok. I have made some minor changes to hopefully fix this for now... the
> entire sa-update cron script needs some reworking to systemd at some point.
> ;( 
> 
> Anyhow, can you try this scratch build and see if there's any issues: 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=6481897

Had a look at the sa-update cron script there and the logic seems correct to me in terms of spampd (see if it's running with pgrep, set SAUPDATE to yes, do a condrestart etc.).

Comment 3 Bojan Smojver 2014-02-25 22:20:43 UTC
Could we get this into F-20?

Comment 4 Kevin Fenzi 2014-02-26 03:28:05 UTC
Can you test this 3.4.0 upgrade scratch build?

http://koji.fedoraproject.org/koji/taskinfo?taskID=6571306

I need to sort out if this will upgrade smoothly, then push that along with this. ;)

Comment 5 Bojan Smojver 2014-02-26 05:23:01 UTC
(In reply to Kevin Fenzi from comment #4)
> Can you test this 3.4.0 upgrade scratch build?
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=6571306
> 
> I need to sort out if this will upgrade smoothly, then push that along with
> this. ;)

Yeah, that worked for me. I ran /usr/share/spamassassin/sa-update.cron by hand and it did restart spampd. Mail log appears to be showing spampd checking mail for spam.

Comment 6 Kevin Fenzi 2014-02-26 22:49:29 UTC
Do you see any spamd logs getting mixed into /var/log/messages?

Or everything looks normal?

Comment 7 Bojan Smojver 2014-02-26 23:55:54 UTC
(In reply to Kevin Fenzi from comment #6)
> Do you see any spamd logs getting mixed into /var/log/messages?
> 
> Or everything looks normal?

The only thing I see there that has word spam is start/stop of spampd, which is normal.

Note that I use spampd, not spamd.

Comment 8 Bojan Smojver 2014-02-27 00:43:27 UTC
I think you really should put the build in testing and see what more users have to say about it.

Comment 9 Bojan Smojver 2014-03-19 02:52:26 UTC
(In reply to Bojan Smojver from comment #8)
> I think you really should put the build in testing and see what more users
> have to say about it.

Ping...

Comment 10 Kevin Fenzi 2014-03-19 16:07:25 UTC
Yes, I am still completely aware of this bug. 

I'm heading out on a trip, but will try and push a test version either before then if I have time or after.

Comment 11 Fedora Update System 2014-03-19 16:55:58 UTC
spamassassin-3.4.0-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/spamassassin-3.4.0-3.fc20

Comment 12 Fedora Update System 2014-03-21 09:37:33 UTC
Package spamassassin-3.4.0-3.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing spamassassin-3.4.0-3.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-4171/spamassassin-3.4.0-3.fc20
then log in and leave karma (feedback).

Comment 13 Fedora Update System 2014-05-23 17:14:40 UTC
spamassassin-3.4.0-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/spamassassin-3.4.0-4.fc20

Comment 14 Fedora Update System 2014-05-24 23:27:06 UTC
Package spamassassin-3.4.0-4.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing spamassassin-3.4.0-4.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-6643/spamassassin-3.4.0-4.fc20
then log in and leave karma (feedback).

Comment 15 Fedora Update System 2014-06-01 22:21:27 UTC
spamassassin-3.4.0-4.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Eddie Lania 2014-06-10 07:01:53 UTC
I see spamd messages in both messages and maillog, this has started since lates spammassassin update:

Jun  6 05:53:23 ls3ka systemd: Stopping Spamassassin daemon...
Jun  6 05:53:23 ls3ka systemd: Starting Spamassassin daemon...
Jun  6 05:53:23 ls3ka systemd: Started Spamassassin daemon.
Jun  6 05:53:29 ls3ka spamd: Jun  6 05:53:29.933 [56521] info: spamd: server started on IO::Socket::IP [127.0.0.1]:783, IO::Socket::IP [::1]:783 (running version 3.4.0)
Jun  6 05:53:29 ls3ka spamd: Jun  6 05:53:29.933 [56521] info: spamd: server pid: 56521
Jun  6 05:53:29 ls3ka spamd: Jun  6 05:53:29.936 [56521] info: spamd: server successfully spawned child process, pid 56598
Jun  6 05:53:29 ls3ka spamd: Jun  6 05:53:29.940 [56521] info: spamd: server successfully spawned child process, pid 56599
Jun  6 05:53:29 ls3ka spamd: Jun  6 05:53:29.942 [56521] info: prefork: child states: IS
Jun  6 05:53:29 ls3ka spamd: Jun  6 05:53:29.942 [56521] info: prefork: child states: II
Jun  6 05:54:27 ls3ka clamd: SelfCheck: Database status OK.
Jun  6 05:54:27 ls3ka clamd[37565]: SelfCheck: Database status OK.
Jun  6 05:55:01 ls3ka systemd: Starting Session 2815 of user root.
Jun  6 05:55:01 ls3ka systemd: Started Session 2815 of user root.
Jun  6 06:00:01 ls3ka systemd: Starting Session 2817 of user root.
Jun  6 06:00:01 ls3ka systemd: Started Session 2817 of user root.
Jun  6 06:00:01 ls3ka systemd: Starting Session 2816 of user root.
Jun  6 06:00:01 ls3ka systemd: Started Session 2816 of user root.
Jun  6 06:01:01 ls3ka systemd: Starting Session 2818 of user root.
Jun  6 06:01:01 ls3ka systemd: Started Session 2818 of user root.
Jun  6 06:01:34 ls3ka spamd: Jun  6 06:01:34.280 [56598] info: spamd: connection from localhost6.localdomain6 [::1]:36989 to port 783, fd 6
Jun  6 06:01:34 ls3ka spamd: Jun  6 06:01:34.284 [56598] info: spamd: setuid to sa-milt succeeded
Jun  6 06:01:34 ls3ka spamd: Jun  6 06:01:34.299 [56598] info: spamd: processing message (unknown) for sa-milt:988
Jun  6 06:01:39 ls3ka spamd: Jun  6 06:01:39.604 [56598] info: spamd: identified spam (22.5/4.6) for sa-milt:988 in 5.3 seconds, 11688 bytes.
Jun  6 06:01:39 ls3ka spamd: Jun  6 06:01:39.605 [56598] info: spamd: result: Y 22 - AXB_XMAILER_MIMEOLE_OL_1ECD5,BAYES_80,DCC_CHECK,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DOS_OE_TO_MX,FORGED_MUA_OUTLOOK,FORGED_OUTLOOK_HTML,FROM_MISSP_MSFT,HTML_FONT_LOW_CONTRAST,HTML_MESSA
GE,MIME_HTML_ONLY,MISSING_MID,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,SUBJECT_NEEDS_ENCODING,T_FROM_MISSP_DKIM,URIBL_BLACK,URIBL_DBL_SPAM,URIBL_JP_SURBL,URIBL_WS_SURBL scantime=5.3,size=11688,user=sa-milt,uid=988,required_score=4.6,rhost=localhost6.localdomain6,raddr=::1,
rport=36989,mid=(unknown),bayes=0.946495,autolearn=spam autolearn_force=no
Jun  6 06:01:39 ls3ka spamd: Jun  6 06:01:39.684 [56521] info: prefork: child states: II


Note You need to log in before you can comment on or make changes to this bug.