Spec URL: http://mizdebsk.fedorapeople.org/review/eclipse-m2e-egit/eclipse-m2e-egit.spec SRPM URL: http://mizdebsk.fedorapeople.org/review/eclipse-m2e-egit/eclipse-m2e-egit-0.14.0-0.1.git571dc0a.fc21.src.rpm Description: This package provides M2E SCM Handler for EGit which adds support for git repositories to M2E. Fedora Account System Username: mizdebsk
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6469862
NOTE manual review cause: Error: No Package found for mvn(io.tesla.tycho:tycho-support:pom:) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/gil/1058883-eclipse-m2e-modello/srpm/review- eclipse-m2e-egit/licensecheck.txt [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: eclipse-m2e-egit-0.14.0-0.1.git571dc0a.fc21.noarch.rpm eclipse-m2e-egit-0.14.0-0.1.git571dc0a.fc21.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint eclipse-m2e-egit 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- eclipse-m2e-egit (rpmlib, GLIBC filtered): osgi(org.eclipse.core.runtime) osgi(org.eclipse.egit.core) osgi(org.eclipse.egit.ui) osgi(org.eclipse.jface) osgi(org.eclipse.jgit) osgi(org.eclipse.m2e.core) osgi(org.eclipse.m2e.core.ui) osgi(org.eclipse.m2e.scm) osgi(org.eclipse.swt) osgi(org.eclipse.ui) osgi(slf4j.api) Provides -------- eclipse-m2e-egit: eclipse-m2e-egit osgi(org.sonatype.m2e.egit) Source checksums ---------------- https://github.com/tesla/m2eclipse-egit/archive/571dc0a51c10fc528ea6adffa4119d9587dafb5e/eclipse-m2e-egit-0.14.0-571dc0a.tar.gz : CHECKSUM(SHA256) this package : a1cab03335e510f6fdc871806b5a013f6cda23514e340a2ea44a71a505c80650 CHECKSUM(SHA256) upstream package : a1cab03335e510f6fdc871806b5a013f6cda23514e340a2ea44a71a505c80650 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -vpn eclipse-m2e-egit -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
New Package SCM Request ======================= Package Name: eclipse-m2e-egit Short Description: M2E SCM Handler for EGit Owners: mizdebsk msrb sochotni Branches: f20 InitialCC: java-sig
Git done (by process-git-requests).
Rawhide build completed: http://koji.fedoraproject.org/koji/taskinfo?taskID=6471704 Closing.