Red Hat Bugzilla – Bug 10600
spec file needs a correction
Last modified: 2008-05-01 11:37:55 EDT
Spec file for util-linux 2.10f says 'make "RPM_OPT_FLAGS=$RPM_OPT_FLAGS"'
which is not doing to well if one would need to pass some other flags
here. It should read 'make "OPT==$RPM_OPT_FLAGS"' for a desired effect.
On the top of it 'fdisk' throws multum of "unaligned access" on alpha.
If somebody would want a reworked source rpm file for 2.10h, with
much better working fdisk for disklabels on alpha, then tell me where
to upload that. I am not going to attach it to this message.
Could you attach a patch and/or spec file to this message? Thanks.
Attached is a spec file in question and two extra patches, Alpha specific,
referenced in it. Please note dates. :-)
Created attachment 9161 [details]
compressed archive with modified util-linux specs and extra patches
OPT change in 2.10p-6, the fdisk ones look out of date now. Please tell me if
patches are still needed.
> OPT change in 2.10p-6, the fdisk ones look out of date now.
No, I do not see it. Look at a file MCONFIG in a top directory of
util-linux. Even patched with "redhat" changes it is still using
"OPT" to add other options. There is really no good way to pass
automatically such platform dependendent flags like '-mcpu=ev4 -Wa,-mev45'
from ~/.rpmrc, or whatever else you may want there, other than with
a proposed change.
Also of alpha specific patches one about warning seems to be indeed
obsolete (my name shows up in a header comment of fdisk.c :-) but the
other one is still pretty vital for Alpha if "not official" and it
does change an fdisk behaviour in this particular case. Also 'bdsfdisk'
for scripted writes of disklabels (Jeff, i.e. jbj, got that one from me
a while ago) depends on this. Mind you, this is not tested; just a quick
peek at the current code.
I haven't built the new util-linux yet, I will tonight. If it needs any more
patches when you see it, reopen this bug.